From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <e@yhbt.net>
X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net
X-Spam-Level: 
X-Spam-Status: No, score=-4.0 required=3.0 tests=ALL_TRUSTED,BAYES_00
	shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2
Received: from localhost (dcvr.yhbt.net [127.0.0.1])
	by dcvr.yhbt.net (Postfix) with ESMTP id 545251F5AE;
	Wed, 29 Jul 2020 09:20:24 +0000 (UTC)
Date: Wed, 29 Jul 2020 09:20:23 +0000
From: Eric Wong <e@yhbt.net>
To: Josh Natanson <josh@natanson.net>
Cc: clogger-public@yhbt.net
Subject: Re: Clogger request_time formatting
Message-ID: <20200729092023.GA24100@dcvr>
References: <CAPdx2szjqUuFjUtrgoeXXwmz0HzfdnWe+2h2Sp_ywDkTDVL0-g@mail.gmail.com>
 <20200726044647.GA19757@dcvr>
 <CAPdx2syrR-EKP20V3Ag5WikUknzZ42bo6zYg1r51+aosHBKaLA@mail.gmail.com>
 <20200727183856.GA26578@dcvr>
 <CAPdx2sz4Cm=yzhRBqC9bwVFRAKh82GEUUHHZ7gquYnsL1F1M7Q@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <CAPdx2sz4Cm=yzhRBqC9bwVFRAKh82GEUUHHZ7gquYnsL1F1M7Q@mail.gmail.com>
List-Id: <clogger-public.yhbt.net>

Josh Natanson <josh@natanson.net> wrote:
> Thanks.  I had some time to work on this, and I'm a little stuck.  The
> changes I've made are working as expected (both new syntax & legacy)
> when frozen into a test rails application. I've written a test for the
> new syntax, but I'm not getting the same behavior there - it looks to
> behave the same as the legacy option.  I can't see why the same code
> would behave differently in an app vs. the test, and I'm having some
> challenges getting useful debug out of the code in test.  I'm sure I'm
> just unfamiliar with something about the gem's layout, but maybe you
> have some ideas?

Ah, you're aware there's both a C extension and pure-Ruby
implementation in the same tree, right?

I only see changes to the pure-Ruby code.  Btw, I can help with
the C stuff, too, if you're not a C hacker.

Perhaps setting CLOGGER_PURE=1 lets your app work as expected?

The very short GNUmakefile has two targets for testing these
independently:

	make test-ext
	make test-pure
	# (or gmake if you're on *BSD)

> Here's the changes so far.  Don't mind the names, I'm planning to come
> up with something better before submitting.

All the rest seemed fine to me :>

Btw, please don't top-post and trim quotes.  Mostly old school
Usenet conventions, though when in doubt, I don't think quoting
is necessary at all with reliable archives, nowadays.  (it saves
storage + bandwidth for all)

Thanks.