From: Eric Wong <bofh@yhbt.net>
To: clogger-public@yhbt.net
Cc: Stefan Sundin <git@stefansundin.com>
Subject: [PATCH] test_broken_header_response: allow NoMethodError w/ rack 2
Date: Fri, 2 Feb 2024 07:45:22 +0000 [thread overview]
Message-ID: <20240202074522.M253875@dcvr> (raw)
In-Reply-To: <20240128012812.76997-3-git@stefansundin.com>
Just a minor problem I noticed on my other machine since I'm way
behind on upgrades in `production'... Also 2 more minor patches
being worked on (will post on https://yhbt.net/clogger-public/
w/o Cc in a bit)
-----8<------
Subject: [PATCH] test_broken_header_response: allow NoMethodError w/ rack 2
Debian 11 (oldstable) packages rack 2.1.4 which fails with
NoMethodError when passed an invalid response header. rack
2.2.6.4 on Debian 12 (stable) doesn't raise, however.
---
test/test_clogger.rb | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/test/test_clogger.rb b/test/test_clogger.rb
index 5646025..955946b 100644
--- a/test/test_clogger.rb
+++ b/test/test_clogger.rb
@@ -485,7 +485,10 @@ def test_broken_header_response
if IS_RACK3 then
assert_raise(ArgumentError) { cl.call(@req) }
else
- assert_nothing_raised { cl.call(@req) }
+ begin
+ cl.call(@req)
+ rescue NoMethodError # rack 2.1.4 raises, but not 2.2.6.4
+ end
end
end
next prev parent reply other threads:[~2024-02-02 7:45 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-23 3:08 rack 3.x compatibility Stefan Sundin
2024-01-23 3:08 ` [PATCH 1/2] update deprecated license identifier Stefan Sundin
2024-01-23 3:08 ` [PATCH 2/2] rack 3.x compatibility Stefan Sundin
2024-01-23 12:47 ` Eric Wong
2024-01-28 1:22 ` v2 Stefan Sundin
2024-01-28 1:22 ` [PATCH v2 1/2] update deprecated license identifier Stefan Sundin
2024-01-28 1:23 ` [PATCH v2 2/2] rack 3.x compatibility Stefan Sundin
2024-02-02 7:45 ` Eric Wong [this message]
2024-02-01 7:58 ` v2 Eric Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://yhbt.net/clogger/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240202074522.M253875@dcvr \
--to=bofh@yhbt.net \
--cc=clogger-public@yhbt.net \
--cc=git@stefansundin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhbt.net/clogger.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).