From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: X-Spam-Status: No, score=-4.1 required=3.0 tests=ALL_TRUSTED,AWL,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, T_SCC_BODY_TEXT_LINE shortcircuit=no autolearn=ham autolearn_force=no version=3.4.6 Received: from localhost (dcvr.yhbt.net [127.0.0.1]) by dcvr.yhbt.net (Postfix) with ESMTP id 53FD61F405; Fri, 2 Feb 2024 07:45:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=yhbt.net; s=selector1; t=1706859922; bh=vaiPnr/PrEXgyiOE0zDjtiug7dyqIqzoaONBLhK4vyA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=JszJRP06XOb3P9UfnfCehu9HxXsbehMtRrMLMEQ1nDP8yJRWovH36o3kyFuDZKdNN lBwgA9eGxZO+aJm/sXiIWNRl6xyHAJ1eO6M/jHL+8hl7oI7ydKHJ66DvFe6KoNHrIe bc12z6aP7qIzivsD9qllklJjductaKBCSsoE6cKY= Date: Fri, 2 Feb 2024 07:45:22 +0000 From: Eric Wong To: clogger-public@yhbt.net Cc: Stefan Sundin Subject: [PATCH] test_broken_header_response: allow NoMethodError w/ rack 2 Message-ID: <20240202074522.M253875@dcvr> References: <20240123124730.M353391@dcvr> <20240128012812.76997-1-git@stefansundin.com> <20240128012812.76997-3-git@stefansundin.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20240128012812.76997-3-git@stefansundin.com> List-Id: Just a minor problem I noticed on my other machine since I'm way behind on upgrades in `production'... Also 2 more minor patches being worked on (will post on https://yhbt.net/clogger-public/ w/o Cc in a bit) -----8<------ Subject: [PATCH] test_broken_header_response: allow NoMethodError w/ rack 2 Debian 11 (oldstable) packages rack 2.1.4 which fails with NoMethodError when passed an invalid response header. rack 2.2.6.4 on Debian 12 (stable) doesn't raise, however. --- test/test_clogger.rb | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/test/test_clogger.rb b/test/test_clogger.rb index 5646025..955946b 100644 --- a/test/test_clogger.rb +++ b/test/test_clogger.rb @@ -485,7 +485,10 @@ def test_broken_header_response if IS_RACK3 then assert_raise(ArgumentError) { cl.call(@req) } else - assert_nothing_raised { cl.call(@req) } + begin + cl.call(@req) + rescue NoMethodError # rack 2.1.4 raises, but not 2.2.6.4 + end end end