* [PATCH 4/6] prevent potential premature GC in byte_xs
@ 2014-02-15 23:09 7% ` Eric Wong
0 siblings, 0 replies; 1+ results
From: Eric Wong @ 2014-02-15 23:09 UTC (permalink / raw)
To: clogger
If we convert an object to string, there is a potential the
compiler may optimize away the converted string if escaping
is needed. Prevent that with RB_GC_GUARD.
---
ext/clogger_ext/clogger.c | 9 +++------
1 file changed, 3 insertions(+), 6 deletions(-)
diff --git a/ext/clogger_ext/clogger.c b/ext/clogger_ext/clogger.c
index ed01534..8b05c34 100644
--- a/ext/clogger_ext/clogger.c
+++ b/ext/clogger_ext/clogger.c
@@ -166,10 +166,11 @@ static inline int need_escape(unsigned c)
}
/* we are encoding-agnostic, clients can send us all sorts of junk */
-static VALUE byte_xs_str(VALUE from)
+static VALUE byte_xs(VALUE obj)
{
static const char esc[] = "0123456789ABCDEF";
unsigned char *new_ptr;
+ VALUE from = rb_obj_as_string(obj);
const unsigned char *ptr = (const unsigned char *)RSTRING_PTR(from);
long len = RSTRING_LEN(from);
long new_len = len;
@@ -203,14 +204,10 @@ static VALUE byte_xs_str(VALUE from)
}
assert(RSTRING_PTR(rv)[RSTRING_LEN(rv)] == '\0');
+ RB_GC_GUARD(from);
return rv;
}
-static VALUE byte_xs(VALUE from)
-{
- return byte_xs_str(rb_obj_as_string(from));
-}
-
static void clogger_mark(void *ptr)
{
struct clogger *c = ptr;
--
1.9.0.rc3.13.gda73b5f
^ permalink raw reply related [relevance 7%]
Results 1-1 of 1 | reverse | options above
-- pct% links below jump to the message on this page, permalinks otherwise --
2014-02-15 23:09 [PATCH 1/6] blocking_helpers: remove fstat wrapper Eric Wong
2014-02-15 23:09 7% ` [PATCH 4/6] prevent potential premature GC in byte_xs Eric Wong
Code repositories for project(s) associated with this public inbox
https://yhbt.net/clogger.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).