clogger RubyGem user+dev discussion/patches/pulls/bugs/help
 help / color / mirror / code / Atom feed
From: Ben Armstrong <BArmstrong@dymaxion.ca>
To: Eric Wong <e@80x24.org>
Cc: <clogger-public@bogomips.org>
Subject: Re: gem fails to build on Win 7 32 bit, DevKit 3.7.2 (rubyinstaller.org)
Date: Tue, 26 Jul 2016 06:35:27 -0300	[thread overview]
Message-ID: <c14835f8-4b0c-2084-eb7b-04df53057bd8@dymaxion.ca> (raw)
In-Reply-To: <20160725210439.GA29810@starla>

On 25/07/16 06:04 PM, Eric Wong wrote:
> Is the pure-Ruby version acceptable for you?
>
> I wonder if extconf.rb should just bail out with
>
> 	if RUBY_PLATFORM =~ /win32/i
> 	  raise "C ext not supported on RUBY_PLATFORM=#{RUBY_PLATFORM}"
> 	end

That might work for me, except there are several Windows platform
strings, and mine is i386-mingw32. In my test, I simply did an
unconditional raise and the gem built fine.

See:
http://stackoverflow.com/questions/170956/how-can-i-find-which-operating-system-my-ruby-program-is-running-on

However, after my successful build of the patched gem, when I re-enabled
clogger in my rails 3 app in config/application.rb like this, it
resulted in an empty log/access.log:

    config.middleware.use 'Clogger',
      :format => Clogger::Format::Combined,
      :logger => File.open("log/access.log", "ab")

Odd, as this worked fine for me once upon a time when the application
ran on Ruby 1.8.7. (It was only when we made the switch to Ruby 1.8.7 ->
2.2.4 that clogger broke and we temporarily disabled this feature.)

> if this can't be fixed...

Do you want to go that way anyway? I certainly could provide the
Makefile and mkmf.log, except ...

> On a side note: I hope to drop the C extension if the pure
> Ruby version can offer acceptable performance nowadays.  I'd be
> much happier if there's zero chance of somebody downloading an
> unauditable pre-compiled binary.


Sounds reasonable. If this is the way you're heading, I wonder if it's
worth the effort to debug the C.

Thanks,

Ben


  reply	other threads:[~2016-07-26  9:35 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-25 15:07 gem fails to build on Win 7 32 bit, DevKit 3.7.2 (rubyinstaller.org) Ben Armstrong
2016-07-25 21:04 ` Eric Wong
2016-07-26  9:35   ` Ben Armstrong [this message]
2016-07-26 15:24     ` Ben Armstrong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://yhbt.net/clogger/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c14835f8-4b0c-2084-eb7b-04df53057bd8@dymaxion.ca \
    --to=barmstrong@dymaxion.ca \
    --cc=clogger-public@bogomips.org \
    --cc=e@80x24.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://yhbt.net/clogger.git/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).