From: Eric Wong <e@80x24.org>
To: cmogstored-public@bogomips.org
Cc: Eric Wong <e@80x24.org>
Subject: [PATCH] http_dav: log 500 errors from DELETE requests
Date: Thu, 5 Feb 2015 21:56:46 +0000 [thread overview]
Message-ID: <1423173406-21936-1-git-send-email-e@80x24.org> (raw)
Errors on failed unlink can be a prelude to a bigger problem, so
log it locally ourselves even if the tracker will notice it.
This commit was tested manually by setting up cmogstored to point to a
read-only mount point on my system and attempting a DELETE request on
it.
---
http_dav.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/http_dav.c b/http_dav.c
index 8487e13..ad7c80d 100644
--- a/http_dav.c
+++ b/http_dav.c
@@ -46,6 +46,8 @@ forbidden:
PRESERVE_ERRNO(do {
mog_http_resp(mfd, "500 Internal Server Error", true);
} while(0));
+ syslog(LOG_ERR, "Failed to unlink %s (in %s): %m",
+ path, http->svc->docroot);
}
void mog_http_mkcol(struct mog_fd *mfd, char *buf)
--
EW
reply other threads:[~2015-02-05 21:56 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://yhbt.net/cmogstored/README
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1423173406-21936-1-git-send-email-e@80x24.org \
--to=e@80x24.org \
--cc=cmogstored-public@bogomips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhbt.net/cmogstored.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).