From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: X-Spam-Status: No, score=-4.0 required=3.0 tests=ALL_TRUSTED,BAYES_00 shortcircuit=no autolearn=ham autolearn_force=no version=3.4.0 Received: from localhost (dcvr.yhbt.net [127.0.0.1]) by dcvr.yhbt.net (Postfix) with ESMTP id A89361FEAA; Sun, 17 Jul 2016 05:16:25 +0000 (UTC) From: Eric Wong To: cmogstored-public@bogomips.org Cc: Eric Wong Subject: [PATCH] test/mgmt: relax checks for iostat mapping Date: Sun, 17 Jul 2016 05:16:24 +0000 Message-Id: <20160717051624.8792-1-e@80x24.org> List-Id: In the age of virtualized devices and fast solid-state storage, iostat information isn't as useful at it was a decade ago and probably less useful in tests. So relax the tests. --- test/mgmt.rb | 14 +++++++++++--- 1 file changed, 11 insertions(+), 3 deletions(-) diff --git a/test/mgmt.rb b/test/mgmt.rb index 64f7bfc..28ef255 100644 --- a/test/mgmt.rb +++ b/test/mgmt.rb @@ -347,7 +347,11 @@ class TestMgmt < Test::Unit::TestCase break if str =~ /^666\t/ end util = RUBY_PLATFORM =~ /linux/ ? %r{\d+\.\d\d} : %r{\d+(?:\.\d+)?} - assert_match(/^666\t#{util}\n/, str, swarn(str.inspect)) + if str =~ /^666\t-\n/ + warn "'watch' may not work correctly on virtual disks\n" + else + assert_match(/^666\t#{util}\n/, str, swarn(str.inspect)) + end assert_equal ".\n", @client.gets end if `which iostat 2>/dev/null`.chomp.size != 0 && RUBY_PLATFORM !~ /kfreebsd-gnu/ @@ -363,8 +367,12 @@ class TestMgmt < Test::Unit::TestCase lines = [] lines << @client.gets lines << @client.gets - assert_match(/^(666|999)\t#{util}\n/, lines[0], swarn(lines.inspect)) - assert_match(/^(666|999)\t#{util}\n/, lines[1], swarn(lines.inspect)) + if lines.grep(/^(666|999)\t-\n/)[0] + warn "'watch' may not work correctly on virtual disks\n" + else + assert_match(/^(666|999)\t#{util}\n/, lines[0], swarn(lines.inspect)) + assert_match(/^(666|999)\t#{util}\n/, lines[1], swarn(lines.inspect)) + end assert_not_equal(lines[0], lines[1]) assert_equal ".\n", @client.gets -- EW