* [PATCH] upgrade: avoid syslog call if execve fails
@ 2016-07-18 7:36 Eric Wong
0 siblings, 0 replies; only message in thread
From: Eric Wong @ 2016-07-18 7:36 UTC (permalink / raw)
To: cmogstored-public
We cannot safely call syslog on all platforms under vfork;
but we have normal exit handling to tell us of the presence
of execve errors, just not which.
---
upgrade.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/upgrade.c b/upgrade.c
index cda8700..b01b514 100644
--- a/upgrade.c
+++ b/upgrade.c
@@ -131,7 +131,6 @@ pid_t mog_upgrade_spawn(void)
if (pid == 0) {
mog_svc_upgrade_prepare();
execve(execfile, start.argv, start.envp);
- syslog(LOG_ERR, "execve %s failed for upgrade: %m", execfile);
_exit(2);
} else if (pid > 0) {
mog_process_register(pid, MOG_PROC_UPGRADE);
--
EW
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2016-07-18 7:36 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-07-18 7:36 [PATCH] upgrade: avoid syslog call if execve fails Eric Wong
Code repositories for project(s) associated with this public inbox
https://yhbt.net/cmogstored.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).