From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: X-Spam-Status: No, score=-4.0 required=3.0 tests=ALL_TRUSTED,BAYES_00 shortcircuit=no autolearn=ham autolearn_force=no version=3.4.0 Received: from localhost (dcvr.yhbt.net [127.0.0.1]) by dcvr.yhbt.net (Postfix) with ESMTP id BCD551FEAA for ; Mon, 18 Jul 2016 07:36:58 +0000 (UTC) From: Eric Wong To: cmogstored-public@bogomips.org Subject: [PATCH] upgrade: avoid syslog call if execve fails Date: Mon, 18 Jul 2016 07:36:58 +0000 Message-Id: <20160718073658.11499-1-e@80x24.org> List-Id: We cannot safely call syslog on all platforms under vfork; but we have normal exit handling to tell us of the presence of execve errors, just not which. --- upgrade.c | 1 - 1 file changed, 1 deletion(-) diff --git a/upgrade.c b/upgrade.c index cda8700..b01b514 100644 --- a/upgrade.c +++ b/upgrade.c @@ -131,7 +131,6 @@ pid_t mog_upgrade_spawn(void) if (pid == 0) { mog_svc_upgrade_prepare(); execve(execfile, start.argv, start.envp); - syslog(LOG_ERR, "execve %s failed for upgrade: %m", execfile); _exit(2); } else if (pid > 0) { mog_process_register(pid, MOG_PROC_UPGRADE); -- EW