cmogstored dev/user discussion/issues/patches/etc
 help / color / mirror / code / Atom feed
From: Eric Wong <e@80x24.org>
To: cmogstored-public@bogomips.org
Subject: [PATCH] cmogstored.h: remove unused mog_file.mmptr member
Date: Fri, 16 Dec 2016 11:16:43 +0000	[thread overview]
Message-ID: <20161216111643.12939-1-e@80x24.org> (raw)

This was intended for zero-copy PUT support, but that is
probably not worth it due to checksumming and the general
unpredictability of mmap/munmap performance, especially
on non-Linux systems.
---
 cmogstored.h | 1 -
 1 file changed, 1 deletion(-)

diff --git a/cmogstored.h b/cmogstored.h
index de2b5c2..f5c682e 100644
--- a/cmogstored.h
+++ b/cmogstored.h
@@ -279,7 +279,6 @@ struct mog_file {
 	char *path;
 	size_t pathlen;
 	char *tmppath; /* NULL-ed if rename()-ed away */
-	void *mmptr;
 	struct mog_ioq *ioq;
 	struct mog_svc *svc;
 	struct mog_digest digest;
-- 
EW


                 reply	other threads:[~2016-12-16 11:16 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://yhbt.net/cmogstored/README

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161216111643.12939-1-e@80x24.org \
    --to=e@80x24.org \
    --cc=cmogstored-public@bogomips.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://yhbt.net/cmogstored.git/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).