cmogstored dev/user discussion/issues/patches/etc
 help / color / mirror / code / Atom feed
From: Eric Wong <e@80x24.org>
To: cmogstored-public@bogomips.org
Subject: Re: [PATCH] serve /dev*/usage requests from memory
Date: Wed, 28 Nov 2018 00:19:03 +0000	[thread overview]
Message-ID: <20181128001903.emv5vyh6tcluuvas@dcvr> (raw)
In-Reply-To: <20181127095936.30796-1-e@80x24.org>

Needs the following to pass valgrind tests, too.
Without it, there would be a slow memory leak for rare
device replacements

diff --git a/dev.c b/dev.c
index 40ddeb7..3b52023 100644
--- a/dev.c
+++ b/dev.c
@@ -304,6 +304,8 @@ void mog_dev_free(void *ptr)
 
 	mog_ioq_destroy(&dev->fsckq);
 	mog_ioq_destroy(&dev->ioq);
+	free(dev->usage_txt);
+	CHECK(int, 0, pthread_mutex_destroy(&dev->usage_lock));
 	free(dev);
 }
 

  reply	other threads:[~2018-11-28  0:19 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-27  9:59 [PATCH] serve /dev*/usage requests from memory Eric Wong
2018-11-28  0:19 ` Eric Wong [this message]
2018-12-07 23:56 ` [PATCH 2/1] http_parser: workaround parsing OOM in Ragel 6.10 Eric Wong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://yhbt.net/cmogstored/README

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181128001903.emv5vyh6tcluuvas@dcvr \
    --to=e@80x24.org \
    --cc=cmogstored-public@bogomips.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://yhbt.net/cmogstored.git/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).