cmogstored dev/user discussion/issues/patches/etc
 help / color / mirror / code / Atom feed
* [PATCH] test/mgmt_auto_adjust.rb: improve diagnostic messages
@ 2019-04-27 21:26 Eric Wong
  0 siblings, 0 replies; only message in thread
From: Eric Wong @ 2019-04-27 21:26 UTC (permalink / raw)
  To: cmogstored-public

Chasing down a regression in Linux 5.0:

	https://lkml.kernel.org/r/20190427093319.sgicqik2oqkez3wk@dcvr
---
 test/mgmt_auto_adjust.rb | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/test/mgmt_auto_adjust.rb b/test/mgmt_auto_adjust.rb
index 8ec725f..311747d 100644
--- a/test/mgmt_auto_adjust.rb
+++ b/test/mgmt_auto_adjust.rb
@@ -80,6 +80,7 @@ def test_aio_threads_auto_adjust
          RUBY_PLATFORM !~ /kfreebsd-gnu/
 
   def test_aio_threads_auto_adjust_warn
+    at = Time.now
     @client.write "server aio_threads = 1\r\n"
     assert_equal "\r\n", @client.gets
     stop = Time.now + 60
@@ -87,7 +88,8 @@ def test_aio_threads_auto_adjust_warn
     while (! File.read(@err.path).include?(expect) && Time.now < stop)
       sleep 0.1
     end
-    assert(File.read(@err.path).include?(expect), File.read(@err.path))
+    msg = File.read(@err.path)
+    assert(msg.include?(expect), "msg[#@pid]: #{msg} #{at}")
 
     Dir.mkdir("#@tmpdir/dev333")
     warning = "fewer aio_threads(1) than devices(2)"
@@ -95,6 +97,7 @@ def test_aio_threads_auto_adjust_warn
     while (! File.read(@err.path).include?(warning)) && Time.now < stop
       sleep 0.1
     end
-    assert(File.read(@err.path).include?(warning), File.read(@err.path))
+    msg = File.read(@err.path)
+    assert(msg.include?(warning), "msg[#@pid]: #{msg} #{at}")
   end
 end
-- 
EW


^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2019-04-27 21:26 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-04-27 21:26 [PATCH] test/mgmt_auto_adjust.rb: improve diagnostic messages Eric Wong

Code repositories for project(s) associated with this public inbox

	https://yhbt.net/cmogstored.git/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).