* [PATCH] notify.c: workaround epoll_pwait bug in current Linux 5.0/5.1
@ 2019-05-11 7:56 Eric Wong
0 siblings, 0 replies; only message in thread
From: Eric Wong @ 2019-05-11 7:56 UTC (permalink / raw)
To: cmogstored-public
The bugfix should hit mainline and stable kernels, soon; but
there's no reason for us to be caring if errno is EINTR, or
not...
https://lore.kernel.org/lkml/20190427093319.sgicqik2oqkez3wk@dcvr/
https://lore.kernel.org/lkml/20190507043954.9020-1-deepa.kernel@gmail.com/
---
notify.c | 9 ++++++++-
1 file changed, 8 insertions(+), 1 deletion(-)
diff --git a/notify.c b/notify.c
index 73e772a..1deed82 100644
--- a/notify.c
+++ b/notify.c
@@ -100,7 +100,14 @@ void mog_notify_wait(bool need_usage_file)
mfd = mog_idleq_wait_intr(mog_notify_queue, timeout);
if (mfd)
notify_queue_step(mfd);
- else if (errno == EINTR)
+ else
+ /*
+ * errno == EINTR, but epoll_pwait on some Linux v5.0+/v5.1+
+ * fails to return EINTR. This should be fixed in Linux,
+ * soon:
+ * <20190427093319.sgicqik2oqkez3wk@dcvr>
+ * <20190507043954.9020-1-deepa.kernel@gmail.com>
+ */
note_run();
}
--
EW
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2019-05-11 7:56 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-05-11 7:56 [PATCH] notify.c: workaround epoll_pwait bug in current Linux 5.0/5.1 Eric Wong
Code repositories for project(s) associated with this public inbox
https://yhbt.net/cmogstored.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).