From: Eric Wong <e@80x24.org>
To: kcar-public@bogomips.org
Cc: Eric Wong <e@80x24.org>
Subject: [PATCH] extconf: fix rb_hash_aset deduplication test
Date: Sat, 15 Dec 2018 22:48:49 +0000 [thread overview]
Message-ID: <20181215224849.19276-1-e@80x24.org> (raw)
We must rely on a random string which is already outside
of the Ruby fstring table.
---
ext/kcar/extconf.rb | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/ext/kcar/extconf.rb b/ext/kcar/extconf.rb
index ba69c3c..1608f70 100644
--- a/ext/kcar/extconf.rb
+++ b/ext/kcar/extconf.rb
@@ -24,8 +24,11 @@ end
message('checking if Hash#[]= (rb_hash_aset) dedupes... ')
h = {}
-h[%w(m k m f).join('')] = :foo
-if 'mkmf'.freeze.equal?(h.keys[0])
+x = {}
+r = rand.to_s
+h[%W(#{r}).join('')] = :foo
+x[%W(#{r}).join('')] = :foo
+if x.keys[0].equal?(h.keys[0])
$CPPFLAGS += ' -DHASH_ASET_DEDUPE=1 '
message("yes\n")
else
--
EW
reply other threads:[~2018-12-15 22:49 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://yhbt.net/kcar/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181215224849.19276-1-e@80x24.org \
--to=e@80x24.org \
--cc=kcar-public@bogomips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhbt.net/kcar.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).