kgio RubyGem user+dev discussion/patches/pulls/bugs/help
 help / color / mirror / code / Atom feed
From: Eric Wong <>
Subject: [PATCH] writev: update comment on preserving errno
Date: Wed,  1 Apr 2015 23:18:08 +0000	[thread overview]
Message-ID: <> (raw)

Studying malloc implementations for a while, it's completely
reasonable for "free" to alter errno when making syscalls
to release/compact memory.
 ext/kgio/writev.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/ext/kgio/writev.c b/ext/kgio/writev.c
index 027cdb5..d3ec53e 100644
--- a/ext/kgio/writev.c
+++ b/ext/kgio/writev.c
@@ -90,8 +90,7 @@ static ssize_t custom_writev(int fd, const struct iovec *vec, int iov_cnt, size_
 	result = write(fd, buf, total_len);
-	/* well, it seems that `free` could not change errno
-	 * but lets save it anyway */
+	/* free() may alter errno */
 	i = errno;
 	errno = i;

                 reply	other threads:[~2015-04-01 23:18 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

  List information:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).