kgio RubyGem user+dev discussion/patches/pulls/bugs/help
 help / color / mirror / code / Atom feed
* [PATCH] writev: update comment on preserving errno
@ 2015-04-01 23:18 Eric Wong
  0 siblings, 0 replies; only message in thread
From: Eric Wong @ 2015-04-01 23:18 UTC (permalink / raw)
  To: kgio-public

Studying malloc implementations for a while, it's completely
reasonable for "free" to alter errno when making syscalls
to release/compact memory.
---
 ext/kgio/writev.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/ext/kgio/writev.c b/ext/kgio/writev.c
index 027cdb5..d3ec53e 100644
--- a/ext/kgio/writev.c
+++ b/ext/kgio/writev.c
@@ -90,8 +90,7 @@ static ssize_t custom_writev(int fd, const struct iovec *vec, int iov_cnt, size_
 
 	result = write(fd, buf, total_len);
 
-	/* well, it seems that `free` could not change errno
-	 * but lets save it anyway */
+	/* free() may alter errno */
 	i = errno;
 	free(buf);
 	errno = i;
-- 
EW


^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2015-04-01 23:18 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-04-01 23:18 [PATCH] writev: update comment on preserving errno Eric Wong

Code repositories for project(s) associated with this public inbox

	https://yhbt.net/kgio.git/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).