From: Eric Wong <e@80x24.org>
To: kgio-public@bogomips.org
Cc: Eric Wong <e@80x24.org>
Subject: [PATCH] poll: avoid rb_funcall for rb_hash_clear
Date: Tue, 11 Aug 2015 19:58:43 +0000 [thread overview]
Message-ID: <1439323123-5856-1-git-send-email-e@80x24.org> (raw)
rb_funcall will always be slower, and currently hits the
global method cache in MRI.
---
ext/kgio/extconf.rb | 1 +
ext/kgio/poll.c | 14 +++++++++++++-
2 files changed, 14 insertions(+), 1 deletion(-)
diff --git a/ext/kgio/extconf.rb b/ext/kgio/extconf.rb
index 44888dd..5b0b74a 100644
--- a/ext/kgio/extconf.rb
+++ b/ext/kgio/extconf.rb
@@ -51,6 +51,7 @@
have_func('rb_thread_blocking_region')
have_func('rb_thread_io_blocking_region')
have_func('rb_str_set_len')
+have_func("rb_hash_clear", "ruby.h") # Ruby 2.0+
have_func('rb_time_interval')
have_func('rb_wait_for_single_fd')
have_func('rb_str_subseq')
diff --git a/ext/kgio/poll.c b/ext/kgio/poll.c
index 1f931e7..1d8ebd1 100644
--- a/ext/kgio/poll.c
+++ b/ext/kgio/poll.c
@@ -12,8 +12,18 @@
#endif
static VALUE sym_wait_readable, sym_wait_writable;
+
+#ifdef HAVE_RB_HASH_CLEAR /* Ruby >= 2.0 */
+# define my_hash_clear(h) (void)rb_hash_clear(h)
+#else /* !HAVE_RB_HASH_CLEAR - Ruby <= 1.9.3 */
static ID id_clear;
+static void my_hash_clear(VALUE h)
+{
+ rb_funcall(h, id_clear, 0);
+}
+#endif /* HAVE_RB_HASH_CLEAR */
+
struct poll_args {
struct pollfd *fds;
nfds_t nfds;
@@ -126,7 +136,7 @@ static VALUE poll_result(int nr, struct poll_args *a)
int rc;
if ((nfds_t)nr != a->nfds)
- rb_funcall(a->ios, id_clear, 0);
+ my_hash_clear(a->ios);
for (; nr > 0; fds++) {
if (fds->revents == 0)
continue;
@@ -218,7 +228,9 @@ void init_kgio_poll(void)
sym_wait_readable = ID2SYM(rb_intern("wait_readable"));
sym_wait_writable = ID2SYM(rb_intern("wait_writable"));
+#ifndef HAVE_RB_HASH_CLEAR
id_clear = rb_intern("clear");
+#endif
#define c(x) rb_define_const(mKgio,#x,INT2NUM((int)x))
--
EW
reply other threads:[~2015-08-11 19:58 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://yhbt.net/kgio/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1439323123-5856-1-git-send-email-e@80x24.org \
--to=e@80x24.org \
--cc=kgio-public@bogomips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhbt.net/kgio.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).