From mboxrd@z Thu Jan  1 00:00:00 1970
X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on dcvr.yhbt.net
X-Spam-Level: 
X-Spam-ASN: AS6939 64.71.128.0/18
X-Spam-Status: No, score=-2.1 required=3.0 tests=AWL,BAYES_00,
 MSGID_FROM_MTA_HEADER shortcircuit=no autolearn=unavailable version=3.3.2
Path: news.gmane.org!not-for-mail
From: Eric Wong <normalperson@yhbt.net>
Newsgroups: gmane.comp.lang.ruby.kgio.general
Subject: Re: Current test failures on OpenBSD
Date: Tue, 15 Nov 2011 03:26:29 +0000
Message-ID: <20111115032629.GB3666@dcvr.yhbt.net>
References: <20111115004249.GR10168@jeremyevans.local>
 <20111115004249.GR10168@jeremyevans.local>
NNTP-Posting-Host: lo.gmane.org
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
X-Trace: dough.gmane.org 1321327608 15330 80.91.229.12 (15 Nov 2011 03:26:48
 GMT)
X-Complaints-To: usenet@dough.gmane.org
NNTP-Posting-Date: Tue, 15 Nov 2011 03:26:48 +0000 (UTC)
To: kgio@librelist.org
Original-X-From: kgio@librelist.org Tue Nov 15 04:26:44 2011
Return-path: <kgio@librelist.org>
Envelope-to: gclrkg-kgio@m.gmane.org
List-Archive: <http://librelist.com/archives/kgio/>
List-Help: <http://librelist.com/help.html>
List-Id: <kgio-public@bogomips.org>
List-Post: <mailto:kgio@librelist.org>
List-Subscribe: <mailto:kgio-subscribe@librelist.com>
List-Unsubscribe: <mailto:kgio-unsubscribe@librelist.com>
Precedence: list
Original-Sender: kgio@librelist.org
Xref: news.gmane.org gmane.comp.lang.ruby.kgio.general:64
Archived-At:
 <http://permalink.gmane.org/gmane.comp.lang.ruby.kgio.general/64>
Received: from zedshaw.xen.prgmr.com ([64.71.167.205]) by lo.gmane.org with
 esmtp (Exim 4.69) (envelope-from <kgio@librelist.org>) id 1RQ9fY-0005d0-31
 for gclrkg-kgio@m.gmane.org; Tue, 15 Nov 2011 04:26:44 +0100
Received: from zedshaw.xen.prgmr.com (localhost [IPv6:::1]) by
 zedshaw.xen.prgmr.com (Postfix) with ESMTP id 4E2BB21CB32 for
 <gclrkg-kgio@m.gmane.org>; Tue, 15 Nov 2011 03:29:58 +0000 (UTC)

Jeremy Evans <code@jeremyevans.net> wrote:
> Here are the current test failures on OpenBSD.  I'm using the patch
> below to run all tests even if a test fails.
> 
> Jeremy
> 
>   1) Failure:
> test_accept_flags(TestAcceptFlags) [test/test_accept_flags.rb:25]:
> <false> is not true.

That might be a bad test, is this on MRI 1.8.7 or 1.9.x?
There's a huge difference in how accept() works between them.

Heck, the test /passing/ is probably indicative of a bug in 1.8 code
since that doesn't use both Linux and the kgio_* methods on the given
sockets...

>   1) Failure:
> test_tcp_socket_new_invalid(TestKgioTcpConnect) [test/test_tcp_connect.rb:47]:
> <TypeError> exception expected but was
> Class: <ArgumentError>
> Message: <"invalid TCP port: 1055759040">
> ---Backtrace---
> test/test_tcp_connect.rb:47:in `new'
> test/test_tcp_connect.rb:47:in `test_tcp_socket_new_invalid'
> test/test_tcp_connect.rb:47:in `test_tcp_socket_new_invalid'
> ---------------

Should've been fixed in kgio.git (commit
d064ac9334be079d0e830bc2361c065cbaa52a64)

>   1) Failure:                                                                                                                                         [38/1327]
> test_blocking_accept_flags(TestKgioUNIXServer) [./test/lib_server_accept.rb:37]:
> <false> expected but was
> <true>.

Looks like the same class of failure for all the accept() tests...

kgio also attempts to allow the same listen socket to be shared
between a 1.8.7 and 1.9.2 process during accept()

>   2) Failure:
> test_tryaccept_flags(TestKgioUNIXServer) [./test/lib_server_accept.rb:28]:
> <false> expected but was
> <true>.
> 
>   1) Failure:
> test_blocking_accept_flags(TestKgioTCPServer) [./test/lib_server_accept.rb:37]:
> <false> expected but was
> <true>.
> 
>   2) Failure:
> test_tryaccept_flags(TestKgioTCPServer) [./test/lib_server_accept.rb:28]:
> <false> expected but was
> <true>.