From: Eric Wong <normalperson@yhbt.net>
To: kgio@librelist.org
Subject: Re: Current test failures on OpenBSD
Date: Tue, 15 Nov 2011 13:01:33 -0800 [thread overview]
Message-ID: <20111115210133.GA27689@dcvr.yhbt.net> (raw)
In-Reply-To: 20111115155224.GW10168@jeremyevans.local
Jeremy Evans <code@jeremyevans.net> wrote:
> Should the 5 accept tests that fail on 1.8.7 just be skipped?
Yes, on all systems.
I now recall sockets created from accept() will inherit the O_NONBLOCK
flag on some (or all?) *BSDs from the listen socket. And the listen
socket calling accept() _must_always_ have the O_NONBLOCK flag set when
using green threads.
O_NONBLOCK with Ruby is really an implementation detail and mostly
irrelevant for non-listen sockets. All the *_nonblock methods in Ruby
and the kgio_try* methods always ensure O_NONBLOCK is set to avoid
blocking. When emulating blocking, Ruby/kgio will just select() if it
hits EAGAIN if O_NONBLOCK happens to be set (with either green or native
threads)
> It looks like the tryaccept flag isn't supported on OpenBSD, or at least
> that it doesn't set the returned socket to nonblocking. Should those tests
> be skipped on OpenBSD, or could there a bug in the code?
Buggy tests in general :x
I'll fix the tests and documentation in a few.
next prev parent reply other threads:[~2011-11-15 21:01 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-15 0:42 Current test failures on OpenBSD Jeremy Evans
2011-11-15 3:26 ` Eric Wong
2011-11-15 15:52 ` Jeremy Evans
2011-11-15 21:01 ` Eric Wong [this message]
2011-11-15 21:35 ` Eric Wong
2011-11-16 1:56 ` Jeremy Evans
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://yhbt.net/kgio/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111115210133.GA27689@dcvr.yhbt.net \
--to=normalperson@yhbt.net \
--cc=kgio@librelist.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhbt.net/kgio.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).