kgio RubyGem user+dev discussion/patches/pulls/bugs/help
 help / color / mirror / code / Atom feed
From: Eric Wong <normalperson@yhbt.net>
To: kgio@librelist.org
Subject: Re: Proplems building on Ubuntu 12.10 server 64bit
Date: Wed, 21 Nov 2012 23:19:15 +0000	[thread overview]
Message-ID: <20121121231915.GA8670@dcvr.yhbt.net> (raw)
In-Reply-To: 20121121231403.GA7700@dcvr.yhbt.net

Eric Wong <normalperson@yhbt.net> wrote:
> stuart <stuart@stuartk.com> wrote:
> > I'm having trouble building kgio 2.7.4 on Ubuntu 12.10 x86_64 with JRuby installed by RVM 
> > 
> > It appears that tryopen.c needs #include <errno.h> otherwise I get the error build log below.
> 
> Yes, patch coming.

Pushed to master on git://bogomips.org/kgio

>From 8b4df8ece93ddc4e2fb685905461c1ed27b22295 Mon Sep 17 00:00:00 2001
From: Eric Wong <normalperson@yhbt.net>
Date: Wed, 21 Nov 2012 23:16:00 +0000
Subject: [PATCH] tryopen: include errno.h header just in case

errno.h is not guaranteed to be included in existing headers,
so we need to #include it to ensure errno and friends are
usable.

Thanks to stuart on the kgio mailing list for noticing
ref: <062571308.133355.1353536890665.JavaMail.sas1@172.29.251.236>
---
 ext/kgio/tryopen.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/ext/kgio/tryopen.c b/ext/kgio/tryopen.c
index f8044a5..0ee6a54 100644
--- a/ext/kgio/tryopen.c
+++ b/ext/kgio/tryopen.c
@@ -14,6 +14,7 @@
 #include <sys/types.h>
 #include <sys/stat.h>
 #include <fcntl.h>
+#include <errno.h>
 #include "set_file_path.h"
 #include "ancient_ruby.h"
 
-- 
Eric Wong


  reply	other threads:[~2012-11-21 23:19 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-11-21 22:28 Proplems building on Ubuntu 12.10 server 64bit stuart
2012-11-21 23:14 ` Eric Wong
2012-11-21 23:19   ` Eric Wong [this message]
2012-11-22  0:02   ` stuart

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://yhbt.net/kgio/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20121121231915.GA8670@dcvr.yhbt.net \
    --to=normalperson@yhbt.net \
    --cc=kgio@librelist.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://yhbt.net/kgio.git/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).