From mboxrd@z Thu Jan 1 00:00:00 1970 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS47066 71.19.144.0/20 X-Spam-Status: No, score=-1.9 required=3.0 tests=AWL,BAYES_00, MSGID_FROM_MTA_HEADER shortcircuit=no autolearn=unavailable version=3.3.2 Path: news.gmane.org!not-for-mail From: Eric Wong Newsgroups: gmane.comp.lang.ruby.kgio.general Subject: Re: Test failure caused by commit 377028d99 Date: Wed, 4 Sep 2013 20:51:14 +0000 Message-ID: <20130904205114.GA4864@dcvr.yhbt.net> References: <20130904201440.GA14313@deneb> <20130904201440.GA14313@deneb> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1378327881 11903 80.91.229.3 (4 Sep 2013 20:51:21 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 4 Sep 2013 20:51:21 +0000 (UTC) To: kgio@librelist.org Original-X-From: kgio@librelist.org Wed Sep 04 22:51:24 2013 Return-path: Envelope-to: gclrkg-kgio@m.gmane.org List-Archive: List-Help: List-Id: List-Post: List-Subscribe: List-Unsubscribe: Precedence: list Original-Sender: kgio@librelist.org Xref: news.gmane.org gmane.comp.lang.ruby.kgio.general:207 Archived-At: Received: from zedshaw2.xen.prgmr.com ([71.19.156.177]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1VHK2u-00019P-2Q for gclrkg-kgio@m.gmane.org; Wed, 04 Sep 2013 22:51:24 +0200 Received: from zedshaw2.xen.prgmr.com (unknown [IPv6:::1]) by zedshaw2.xen.prgmr.com (Postfix) with ESMTP id 793C5750A0 for ; Wed, 4 Sep 2013 21:00:24 +0000 (UTC) Hleb Valoshka <375gnu@gmail.com> wrote: > On my Debian Sid with kernel 3.11-rc7 4 of 5 invocations of > test_poll_EINTR_changed finished with failure: Thanks for the report. Unfortunately, I can't seem to reproduce it, here on 1.9.3 nor 2.0.0 with Linux 3.10.10. The test will probably not work well under heavy load, and I've considered removing it, even. Current behavior may not be compatible with all Ruby versions depending on how signal handling is implemented. Does the following change increase reliability for you? --- a/test/test_poll.rb +++ b/test/test_poll.rb @@ -96,7 +96,10 @@ def test_poll_EINTR_changed end thr = Thread.new do sleep 0.100 - Process.kill(:USR1, $$) + 100.times do + Process.kill(:USR1, $$) + Thread.pass + end end t0 = Time.now res = Kgio.poll(pollset, 1000) If not, I think we can just drop the test...