From mboxrd@z Thu Jan 1 00:00:00 1970 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS47066 71.19.144.0/20 X-Spam-Status: No, score=-1.9 required=3.0 tests=AWL,BAYES_00, MSGID_FROM_MTA_HEADER shortcircuit=no autolearn=unavailable version=3.3.2 Path: news.gmane.org!not-for-mail From: Eric Wong Newsgroups: gmane.comp.lang.ruby.kgio.general Subject: Re: Test failure caused by commit 377028d99 Date: Sat, 21 Sep 2013 09:30:33 +0000 Message-ID: <20130921093033.GA680@dcvr.yhbt.net> References: <20130904201440.GA14313@deneb> <20130904205114.GA4864@dcvr.yhbt.net> <20130905231347.GD5823@dcvr.yhbt.net> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1379755839 19527 80.91.229.3 (21 Sep 2013 09:30:39 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 21 Sep 2013 09:30:39 +0000 (UTC) To: kgio@librelist.org Original-X-From: kgio@librelist.org Sat Sep 21 11:30:43 2013 Return-path: Envelope-to: gclrkg-kgio@m.gmane.org List-Archive: List-Help: List-Id: List-Post: List-Subscribe: List-Unsubscribe: Precedence: list Original-Sender: kgio@librelist.org Xref: news.gmane.org gmane.comp.lang.ruby.kgio.general:229 Archived-At: Received: from zedshaw2.xen.prgmr.com ([71.19.156.177]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1VNJWU-0007YY-87 for gclrkg-kgio@m.gmane.org; Sat, 21 Sep 2013 11:30:42 +0200 Received: from zedshaw2.xen.prgmr.com (unknown [IPv6:::1]) by zedshaw2.xen.prgmr.com (Postfix) with ESMTP id D275A74E70 for ; Sat, 21 Sep 2013 09:40:57 +0000 (UTC) Hleb Valoshka <375gnu@gmail.com> wrote: > On 9/6/13, Eric Wong wrote: > >> > Does the following change increase reliability for you? > >> Yes, it helps. Thanks. > > Thanks for testing, pushed as > > commit ff940137dc5098c9d8094e041e9be053cb3e139f > > Another problem has emerged :) Sometimes ruby delivers signals too > late and this test dies because of unhandled USR1. At least Ruby2.0 is > affected (I have no problem with this test under Ruby1.9.3). May be > it's better to remove it. Ugh, yes, this is tricky to test... Does the following help? diff --git a/test/test_poll.rb b/test/test_poll.rb index d9a2b07..5c8071d 100644 --- a/test/test_poll.rb +++ b/test/test_poll.rb @@ -108,6 +108,8 @@ class TestPoll < Test::Unit::TestCase assert_equal({@wr => Kgio::POLLOUT}, res) assert diff < 1.0, "diff=#{diff}" assert ok + + 1000.times { Thread.pass } # let signal handlers fire ensure trap(:USR1, orig) end (I'm sleepy myself and thinking out loud) Or it could be just made to sleep (and slow down the tests even more) Thanks!