From mboxrd@z Thu Jan  1 00:00:00 1970
X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on dcvr.yhbt.net
X-Spam-Level: 
X-Spam-ASN: AS47066 71.19.144.0/20
X-Spam-Status: No, score=-1.9 required=3.0 tests=AWL,BAYES_00,
 MSGID_FROM_MTA_HEADER shortcircuit=no autolearn=unavailable version=3.3.2
Path: news.gmane.org!not-for-mail
From: Eric Wong <normalperson@yhbt.net>
Newsgroups: gmane.comp.lang.ruby.kgio.general
Subject: Re: Test failure caused by commit 377028d99
Date: Wed, 25 Sep 2013 17:46:36 +0000
Message-ID: <20130925174636.GA11878@dcvr.yhbt.net>
References: <20130904201440.GA14313@deneb>
 <20130904205114.GA4864@dcvr.yhbt.net>
 <CAAB-Kc=HbV9HBLy0JR6yOp28NHUzejx7+5EFwj_ppMU-E+-JWg@mail.gmail.com>
 <20130905231347.GD5823@dcvr.yhbt.net>
 <CAAB-Kc=HhGin-JfKamxPFMhUs1yRnS=uPtmFqyp5weEMMx4BPA@mail.gmail.com>
 <20130921093033.GA680@dcvr.yhbt.net>
 <CAAB-KcnpvcG6=OZNsBmvv440OHfCWs6-eDD7L6oD=ziCRXPHLA@mail.gmail.com>
NNTP-Posting-Host: plane.gmane.org
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
X-Trace: ger.gmane.org 1380131214 14875 80.91.229.3 (25 Sep 2013 17:46:54
 GMT)
X-Complaints-To: usenet@ger.gmane.org
NNTP-Posting-Date: Wed, 25 Sep 2013 17:46:54 +0000 (UTC)
To: kgio@librelist.org
Original-X-From: kgio@librelist.org Wed Sep 25 19:46:57 2013
Return-path: <kgio@librelist.org>
Envelope-to: gclrkg-kgio@m.gmane.org
List-Archive: <http://librelist.com/archives/kgio/>
List-Help: <http://librelist.com/help.html>
List-Id: <kgio-public@bogomips.org>
List-Post: <mailto:kgio@librelist.org>
List-Subscribe: <mailto:kgio-subscribe@librelist.com>
List-Unsubscribe: <mailto:kgio-unsubscribe@librelist.com>
Precedence: list
Original-Sender: kgio@librelist.org
Xref: news.gmane.org gmane.comp.lang.ruby.kgio.general:231
Archived-At:
 <http://permalink.gmane.org/gmane.comp.lang.ruby.kgio.general/231>
Received: from zedshaw2.xen.prgmr.com ([71.19.156.177]) by plane.gmane.org
 with esmtp (Exim 4.69) (envelope-from <kgio@librelist.org>) id
 1VOtAv-000081-GR for gclrkg-kgio@m.gmane.org; Wed, 25 Sep 2013 19:46:57 +0200
Received: from zedshaw2.xen.prgmr.com (unknown [IPv6:::1]) by
 zedshaw2.xen.prgmr.com (Postfix) with ESMTP id C71AB73E04 for
 <gclrkg-kgio@m.gmane.org>; Wed, 25 Sep 2013 17:57:33 +0000 (UTC)

Hleb Valoshka <375gnu@gmail.com> wrote:
> On 9/21/13, Eric Wong <normalperson@yhbt.net> wrote:
> 
> > Does the following help?
> 
> No. I was using ruby 2.1.0dev (2013-09-22 trunk 43011) [x86_64-linux].
> 
> 20 runs, 2 signals still were delivered too late, 1 test failure:

Thanks for the report.  I'm not sure what can be done :< git will
remember for us in case we want to resurrect a fixed version of it.
I'll push this out:

Subject: [PATCH] test_poll: remove race prone test_poll_EINTR_changed test

We haven't figured out a way to reliably test this w/o races, so lets
just remove it for now and trust it works by reading the C code.

ref: <CAAB-KcnpvcG6=OZNsBmvv440OHfCWs6-eDD7L6oD=ziCRXPHLA@mail.gmail.com>
---
 test/test_poll.rb | 25 -------------------------
 1 file changed, 25 deletions(-)

diff --git a/test/test_poll.rb b/test/test_poll.rb
index d9a2b07..6463ef9 100644
--- a/test/test_poll.rb
+++ b/test/test_poll.rb
@@ -87,31 +87,6 @@ class TestPoll < Test::Unit::TestCase
       trap(:USR1, orig)
   end
 
-  def test_poll_EINTR_changed
-    ok = false
-    pollset = { @rd => Kgio::POLLIN }
-    orig = trap(:USR1) do
-      pollset[@wr] = Kgio::POLLOUT
-      ok = true
-    end
-    thr = Thread.new do
-      sleep 0.100
-      100.times do
-        Process.kill(:USR1, $$)
-        Thread.pass
-      end
-    end
-    t0 = Time.now
-    res = Kgio.poll(pollset, 1000)
-    diff = Time.now - t0
-    thr.join
-    assert_equal({@wr => Kgio::POLLOUT}, res)
-    assert diff < 1.0, "diff=#{diff}"
-    assert ok
-    ensure
-      trap(:USR1, orig)
-  end
-
   def test_poll_signal_torture
     usr1 = 0
     empty = 0
-- 
1.8.4