kgio RubyGem user+dev discussion/patches/pulls/bugs/help
 help / color / mirror / code / Atom feed
From: Eric Wong <normalperson@yhbt.net>
To: kgio@librelist.org
Subject: [PATCH] test/lib_read_write: fix trywritev blocking test
Date: Wed, 9 Apr 2014 21:57:53 +0000	[thread overview]
Message-ID: <20140409215753.GA16840@dcvr.yhbt.net> (raw)
In-Reply-To: <20140409215753.GA16840@dcvr.yhbt.net>

penultimate return value may be a subarray for writev-related
routines, not a string.

Caught by a pre-upload check by Christian Hofstaedtler
on the debian-ruby list for kgio 2.9.1

Tested-by: Christian Hofstaedtler <zeha@debian.org>
Cc: Hleb Valoshka <375gnu@gmail.com>
Cc: <debian-ruby@lists.debian.org>
Cc: Yura Sokolov <funny.falcon@gmail.com>
---
 test/lib_read_write.rb | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/test/lib_read_write.rb b/test/lib_read_write.rb
index cac87b7..26e7aef 100644
--- a/test/lib_read_write.rb
+++ b/test/lib_read_write.rb
@@ -292,7 +292,8 @@ module LibReadWriteTest
     assert_equal :wait_writable, tmp.pop
     assert tmp.size > 0
     penultimate = tmp.pop
-    assert(penultimate == "I" || penultimate == nil)
+    assert(penultimate == ["I"] || penultimate == nil,
+           "penultimate is #{penultimate.inspect}")
     assert tmp.size > 0
     tmp.each { |count| assert_equal nil, count }
   end
-- 
Eric Wong


           reply	other threads:[~2014-04-09 21:58 UTC|newest]

Thread overview: expand[flat|nested]  mbox.gz  Atom feed
 [parent not found: <20140409215753.GA16840@dcvr.yhbt.net>]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://yhbt.net/kgio/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140409215753.GA16840@dcvr.yhbt.net \
    --to=normalperson@yhbt.net \
    --cc=kgio@librelist.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://yhbt.net/kgio.git/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).