From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: X-Spam-Status: No, score=-4.0 required=3.0 tests=ALL_TRUSTED,BAYES_00 shortcircuit=no autolearn=ham autolearn_force=no version=3.4.0 Received: from localhost (dcvr.yhbt.net [127.0.0.1]) by dcvr.yhbt.net (Postfix) with ESMTP id B67F71FF6D; Thu, 15 Dec 2016 22:50:36 +0000 (UTC) Date: Thu, 15 Dec 2016 22:50:36 +0000 From: Eric Wong To: kgio-public@bogomips.org Subject: Re: [PATCH] remove autopush support and make it a no-op Message-ID: <20161215225036.GA11658@starla> References: <1439499339-29222-1-git-send-email-e@80x24.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <1439499339-29222-1-git-send-email-e@80x24.org> List-Id: Eric Wong wrote: > Maintaining global state in a library like kgio is ugly, and it > is not optimal from a performance standpoint compared to using > MSG_MORE. True; but in the real-world, removing this feature breaks existing some existing deploys. "Few users" is not "no users"; and the regression is COMPLETELY UNACCEPTABLE. Sorry for this monumentally big mistake. Will revert and release 2.11 shortly.