From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: X-Spam-Status: No, score=-4.0 required=3.0 tests=ALL_TRUSTED,AWL,BAYES_00 shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from localhost (dcvr.yhbt.net [127.0.0.1]) by dcvr.yhbt.net (Postfix) with ESMTP id 028E91F4C1 for ; Wed, 30 Oct 2019 09:26:29 +0000 (UTC) From: Eric Wong To: kgio-public@bogomips.org Subject: [PATCH 1/2] test: fix warnings with RUBYOPT=-w Date: Wed, 30 Oct 2019 09:26:27 +0000 Message-Id: <20191030092628.31661-2-e@80x24.org> In-Reply-To: <20191030092628.31661-1-e@80x24.org> References: <20191030092628.31661-1-e@80x24.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit List-Id: --- test/lib_read_write.rb | 2 ++ test/lib_server_accept.rb | 11 +++++++---- test/test_tryopen.rb | 5 +++-- 3 files changed, 12 insertions(+), 6 deletions(-) diff --git a/test/lib_read_write.rb b/test/lib_read_write.rb index 5f70964..a32919f 100644 --- a/test/lib_read_write.rb +++ b/test/lib_read_write.rb @@ -166,6 +166,7 @@ module LibReadWriteTest rescue EOFError break rescue => e + warn "#{e.message} (#{e.class})" end while true dig.hexdigest end @@ -203,6 +204,7 @@ module LibReadWriteTest rescue EOFError break rescue => e + warn "#{e.message} (#{e.class})" end while true dig.hexdigest end diff --git a/test/lib_server_accept.rb b/test/lib_server_accept.rb index db0d120..fcf9c87 100644 --- a/test/lib_server_accept.rb +++ b/test/lib_server_accept.rb @@ -20,6 +20,7 @@ module LibServerAccept b = @srv.kgio_tryaccept assert_kind_of Kgio::Socket, b assert_equal @host, b.kgio_addr + a.close end def test_tryaccept_flags @@ -28,6 +29,7 @@ module LibServerAccept b = @srv.kgio_tryaccept nil, 0 assert_kind_of Kgio::Socket, b assert_equal 0, b.fcntl(Fcntl::F_GETFD) + a.close end def test_blocking_accept_flags @@ -36,6 +38,7 @@ module LibServerAccept b = @srv.kgio_accept nil, 0 assert_kind_of Kgio::Socket, b assert_equal 0, b.fcntl(Fcntl::F_GETFD) + a.close end def test_tryaccept_fail @@ -44,7 +47,7 @@ module LibServerAccept def test_blocking_accept t0 = Time.now - pid = fork { sleep 1; a = client_connect; sleep } + pid = fork { sleep 1; a = client_connect; sleep; a.close } b = @srv.kgio_accept elapsed = Time.now - t0 assert_kind_of Kgio::Socket, b @@ -57,7 +60,7 @@ module LibServerAccept def test_blocking_accept_with_nonblock_socket @srv.nonblock = true t0 = Time.now - pid = fork { sleep 1; a = client_connect; sleep } + pid = fork { sleep 1; a = client_connect; sleep; a.close } b = @srv.kgio_accept elapsed = Time.now - t0 assert_kind_of Kgio::Socket, b @@ -67,7 +70,7 @@ module LibServerAccept assert elapsed >= 1, "elapsed: #{elapsed}" t0 = Time.now - pid = fork { sleep 6; a = client_connect; sleep } + pid = fork { sleep 6; a = client_connect; sleep; a.close } b = @srv.kgio_accept elapsed = Time.now - t0 assert_kind_of Kgio::Socket, b @@ -77,7 +80,7 @@ module LibServerAccept assert elapsed >= 6, "elapsed: #{elapsed}" t0 = Time.now - pid = fork { sleep 1; a = client_connect; sleep } + pid = fork { sleep 1; a = client_connect; sleep; a.close } b = @srv.kgio_accept elapsed = Time.now - t0 assert_kind_of Kgio::Socket, b diff --git a/test/test_tryopen.rb b/test/test_tryopen.rb index abcbd37..2bbbc51 100644 --- a/test/test_tryopen.rb +++ b/test/test_tryopen.rb @@ -59,8 +59,9 @@ class TestTryopen < Test::Unit::TestCase tmp.close! file = Kgio::File.tryopen(path, IO::RDWR|IO::CREAT, 0000) assert_equal 0100000, File.stat(path).mode - ensure - File.unlink path + file.close + ensure + File.unlink path end require "benchmark"