Re: Patch for GC.compact memory issue

[Eric Wong <e@80x24.org>]

Ngan Pham <nganpham@gmail.com> wrote:
> Hey Eric, actually there's 2 more references that need to be marked.

Thanks, will apply those.  More about this at bottom.. +Cc tenderlove

> @nganpham: Regarding actually fixing this on kgio, do you have
> contacts to maintainer(s)? Or should I follow the instructions on the
> (super confusing) site? https://yhbt.net/kgio/

Side note: Sorry if you found it confusing, I figured "README"
  and "HACKING" are clearly labeled.  Not sure how to improve on
  a directory listing for ease-of-navigation (works with "lftp" :>)

> @tenderlove: I think the other "const_gets" in that file probably need
> the same treatment.
> https://yhbt.net/kgio.git/tree/ext/kgio/accept.c#n501 and
> https://yhbt.net/kgio.git/tree/ext/kgio/accept.c#n503 If a constant is
> defined in pure Ruby (not with rb_define_class), then it's also
> allowed to move.
> @nganpham: oof! You're right! I will amend the patch. Good catch.

OK, so rb_const_get for things like Socket, Errno::EPIPE,
Errno::ECONNRESET are fine (for now)?

Anyways, I hope to find time to drop kgio from unicorn later
this year (I started a few years ago...).

And I really wish unicorn never became popular, it was only
created to support buggy legacy apps that were too expensive to
fix.