kgio RubyGem user+dev discussion/patches/pulls/bugs/help
 help / color / mirror / code / Atom feed
From: Eric Wong <>
To: Ngan Pham <>
Cc:, Aaron Patterson <>
Subject: Re: Patch for GC.compact memory issue
Date: Mon, 24 May 2021 20:33:10 +0000	[thread overview]
Message-ID: <20210524203310.GA17864@dcvr> (raw)
In-Reply-To: <>

Ngan Pham <> wrote:
> Hey Eric, actually there's 2 more references that need to be marked.

Thanks, will apply those.  More about this at bottom.. +Cc tenderlove

> @nganpham: Regarding actually fixing this on kgio, do you have
> contacts to maintainer(s)? Or should I follow the instructions on the
> (super confusing) site?

Side note: Sorry if you found it confusing, I figured "README"
  and "HACKING" are clearly labeled.  Not sure how to improve on
  a directory listing for ease-of-navigation (works with "lftp" :>)

> @tenderlove: I think the other "const_gets" in that file probably need
> the same treatment.
> and
> If a constant is
> defined in pure Ruby (not with rb_define_class), then it's also
> allowed to move.
> @nganpham: oof! You're right! I will amend the patch. Good catch.

OK, so rb_const_get for things like Socket, Errno::EPIPE,
Errno::ECONNRESET are fine (for now)?

Anyways, I hope to find time to drop kgio from unicorn later
this year (I started a few years ago...).

And I really wish unicorn never became popular, it was only
created to support buggy legacy apps that were too expensive to

  reply	other threads:[~2021-05-24 20:33 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-24 14:14 Patch for GC.compact memory issue Ngan Pham
2021-05-24 17:22 ` Eric Wong
2021-05-24 19:00   ` Ngan Pham
2021-05-24 20:33     ` Eric Wong [this message]
2021-05-24 21:11       ` Ngan Pham
2021-05-24 21:48         ` [PATCH] HACKING: update docs with "git request-pull" info Eric Wong
2021-05-25 16:41         ` Patch for GC.compact memory issue Aaron Patterson
2021-05-25 22:50           ` Eric Wong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

  List information:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210524203310.GA17864@dcvr \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).