From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: X-Spam-Status: No, score=-4.0 required=3.0 tests=ALL_TRUSTED,BAYES_00 shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from localhost (dcvr.yhbt.net [127.0.0.1]) by dcvr.yhbt.net (Postfix) with ESMTP id E3F5F1F5AE; Mon, 24 May 2021 20:33:10 +0000 (UTC) Date: Mon, 24 May 2021 20:33:10 +0000 From: Eric Wong To: Ngan Pham Cc: kgio-public@yhbt.net, Aaron Patterson Subject: Re: Patch for GC.compact memory issue Message-ID: <20210524203310.GA17864@dcvr> References: <20210524172208.GA7627@dcvr> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: List-Id: Ngan Pham wrote: > Hey Eric, actually there's 2 more references that need to be marked. Thanks, will apply those. More about this at bottom.. +Cc tenderlove > @nganpham: Regarding actually fixing this on kgio, do you have > contacts to maintainer(s)? Or should I follow the instructions on the > (super confusing) site? https://yhbt.net/kgio/ Side note: Sorry if you found it confusing, I figured "README" and "HACKING" are clearly labeled. Not sure how to improve on a directory listing for ease-of-navigation (works with "lftp" :>) > @tenderlove: I think the other "const_gets" in that file probably need > the same treatment. > https://yhbt.net/kgio.git/tree/ext/kgio/accept.c#n501 and > https://yhbt.net/kgio.git/tree/ext/kgio/accept.c#n503 If a constant is > defined in pure Ruby (not with rb_define_class), then it's also > allowed to move. > @nganpham: oof! You're right! I will amend the patch. Good catch. OK, so rb_const_get for things like Socket, Errno::EPIPE, Errno::ECONNRESET are fine (for now)? Anyways, I hope to find time to drop kgio from unicorn later this year (I started a few years ago...). And I really wish unicorn never became popular, it was only created to support buggy legacy apps that were too expensive to fix.