* [PATCH] kgio 2.9.3 - minor cleanups and fixes
@ 2015-01-12 8:50 7% Eric Wong
0 siblings, 0 replies; 2+ results
From: Eric Wong @ 2015-01-12 8:50 UTC (permalink / raw)
To: kgio-public
Most notably there's a new RB_GC_GUARD to fix an occasional segfault at
load time for Ruby 1.8 users thanks to Petr Novodvorskiy for reporting
the issue.
There's been a new mailing list for a few months now at:
kgio-public@bogomips.org
No subscription is required, but if you wish to subscribe
(existing librelist subscribers must resubscribe)
kgio-public+subscribe@bogomips.org
There's also a bunch of code cleanups and packaging
cleanups. Our website is faster now thanks to olddoc:
http://bogomips.org/kgio/
shortlog:
test/lib_read_write: fix trywritev blocking test
new mailing list info: kgio-public@bogomips.org
relax license to allow LGPLv2.1 or later
gemspec: modernize for more recent rubygems
doc: switch to olddoc
remove references to rubyforge and ancient Rubies
TODO: updates for the future of kgio
tryopen: add RB_GC_GUARD for Ruby 1.8
LICENSE: prefer URL to FSF address
cleanup packaging harder
fixup -Wshorten-64-to-32 warnings
cleanup: avoid shadowing rb_str_subseq
cleanup: avoid shadowing rb_ary_subseq
pkg.mk: synchronize with my other projects
gemspec: remove invalid rdoc_options
gemspec: use SPDX license abbreviation
---
GIT-VERSION-GEN | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/GIT-VERSION-GEN b/GIT-VERSION-GEN
index 5cd7851..d0fbba7 100755
--- a/GIT-VERSION-GEN
+++ b/GIT-VERSION-GEN
@@ -1,7 +1,7 @@
#!/bin/sh
GVF=GIT-VERSION-FILE
-DEF_VER=v2.9.2
+DEF_VER=v2.9.3
LF='
'
--
EW
^ permalink raw reply related [relevance 7%]
* [PATCH] cleanup: avoid shadowing rb_ary_subseq
@ 2015-01-10 11:14 6% Eric Wong
0 siblings, 0 replies; 2+ results
From: Eric Wong @ 2015-01-10 11:14 UTC (permalink / raw)
To: kgio-public; +Cc: Eric Wong
Define a MY_ARY_SUBSEQ macro which checks arg counts correctly and
avoids throwing off people who may potentially want to debug this
code.
---
ext/kgio/writev.c | 8 +++++---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/ext/kgio/writev.c b/ext/kgio/writev.c
index 9c1ca15..027cdb5 100644
--- a/ext/kgio/writev.c
+++ b/ext/kgio/writev.c
@@ -27,7 +27,9 @@ static inline VALUE my_ary_subseq(VALUE ary, long idx, long len)
return rb_ary_aref(2, args, ary);
}
-#define rb_ary_subseq my_ary_subseq
+#define MY_ARY_SUBSEQ(ary,idx,len) my_ary_subseq((ary),(idx),(len))
+#else
+#define MY_ARY_SUBSEQ(ary,idx,len) rb_ary_subseq((ary),(idx),(len))
#endif
static VALUE sym_wait_writable;
@@ -105,7 +107,7 @@ static void prepare_writev(struct wrv_args *a, VALUE io, VALUE ary)
if (TYPE(ary) == T_ARRAY)
/* rb_ary_subseq will not copy array unless it modified */
- a->buf = rb_ary_subseq(ary, 0, RARRAY_LEN(ary));
+ a->buf = MY_ARY_SUBSEQ(ary, 0, RARRAY_LEN(ary));
else
a->buf = rb_Array(ary);
@@ -188,7 +190,7 @@ static long trim_writev_buffer(struct wrv_args *a, ssize_t n)
/* partially done, remove fully-written buffers */
if (i > 0)
- a->buf = rb_ary_subseq(a->buf, i, ary_len - i);
+ a->buf = MY_ARY_SUBSEQ(a->buf, i, ary_len - i);
/* setup+replace partially written buffer */
if (n < 0) {
--
EW
^ permalink raw reply related [relevance 6%]
Results 1-2 of 2 | reverse | options above
-- pct% links below jump to the message on this page, permalinks otherwise --
2015-01-10 11:14 6% [PATCH] cleanup: avoid shadowing rb_ary_subseq Eric Wong
2015-01-12 8:50 7% [PATCH] kgio 2.9.3 - minor cleanups and fixes Eric Wong
Code repositories for project(s) associated with this public inbox
https://yhbt.net/kgio.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).