* [ANN] kgio 2.8.1 - minor improvements and test fixes
@ 2013-09-11 0:29 7% Eric Wong
0 siblings, 0 replies; 3+ results
From: Eric Wong @ 2013-09-11 0:29 UTC (permalink / raw)
To: kgio
Changes:
Improved error reporting for kgio_accept/kgio_tryaccept.
Minor size reduction throughout. There are also several
test case fixes for race conditions.
Thanks to Hleb Valoshka and the Debian project for all the
help with this release!
Eric Wong (7):
check syscall returns against < 0 instead of == -1
accept: more informative exception on unknown family
test_tryopen: skip EACCES test when euid == 0
test/lib_read_write: account for larger-than-normal pipes
test_poll: avoid potentially thread-unsafe test
test_poll: preserve original trap(:USR1) handler
test_poll: be less dependent on signal handler ordering
Hleb Valoshka (4):
Change prefix of temporary sockets to prevent races
Don't dump 20M in case of failure
Create own directory for every unix socket in unit tests
Close tempfile and unlink it immediately.
* http://bogomips.org/kgio/
* kgio@librelist.org
* git://bogomips.org/kgio.git
* http://bogomips.org/kgio/NEWS.atom.xml
^ permalink raw reply [relevance 7%]
* Re: Concurrency issue in TestKgioUnixConnect?
2013-09-02 21:24 7% ` Eric Wong
@ 2013-09-03 8:50 0% ` Hleb Valoshka
0 siblings, 0 replies; 3+ results
From: Hleb Valoshka @ 2013-09-03 8:50 UTC (permalink / raw)
To: kgio
On 9/3/13, Eric Wong <normalperson@yhbt.net> wrote:
> I just signed-off and pushed the following out:
>
> Hleb Valoshka (2):
> Change prefix of temporary sockets to prevent races
> Don't dump 20M in case of failure
>
> I've never been hit by the issue even though I've always known it's a
> potential issue on very busy systems. It looks like Tempfile embeds the
I was able to reproduce it only one or two times in virtualized GNU/kFreeBSD.
> PID in the temporary name, so maybe the buildds are recycling PIDs very
> quickly?
I think the problem is caused by parallel tests invocation in ruby 1.9
(ruby 1.8 is
never affected by this issue). Tempfile builds file name using prefix,
PID and random
value, in rare cases this random value isn't random enough.
> I haven't looked closely at your fakeroot workaround.
It's a Debian specific patch.
^ permalink raw reply [relevance 0%]
* Re: Concurrency issue in TestKgioUnixConnect?
@ 2013-09-02 21:24 7% ` Eric Wong
2013-09-03 8:50 0% ` Hleb Valoshka
0 siblings, 1 reply; 3+ results
From: Eric Wong @ 2013-09-02 21:24 UTC (permalink / raw)
To: kgio
Hleb Valoshka <375gnu@gmail.com> wrote:
> On 9/1/13, Eric Wong <normalperson@yhbt.net> wrote:
> >> http://anonscm.debian.org/gitweb/?p=pkg-ruby-extras/ruby-kgio.git;a=blob;f=debian/patches/0002-Change-prefix-of-temporary-sockets-to-prevent-races.patch
> > Btw, do you want me to take that patch into the upstream repo?
>
> As you wish, your tests are also affected by this issue, cause they
> run in parallel too.
I just signed-off and pushed the following out:
Hleb Valoshka (2):
Change prefix of temporary sockets to prevent races
Don't dump 20M in case of failure
I've never been hit by the issue even though I've always known it's a
potential issue on very busy systems. It looks like Tempfile embeds the
PID in the temporary name, so maybe the buildds are recycling PIDs very
quickly?
I haven't looked closely at your fakeroot workaround.
> > It could be improved, too, to use a tmpdir for each test invocation.
> > That would allow multiple instances of the kgio test to run safely at
> > once (e.g. for different versions of ruby/rubinius).
>
> Hmm, interesting idea, currently in Debian tests with different
> versions of ruby are run one-by-one, but who knows how such process
> may be implemented in other OSes.
I used to test some software in parallel under Ruby
1.8/Rubinius/1.9.1/1.9.2/1.9.3; but eventually stopped caring about
1.8, 1.9.{1,2} and Rubinius itself was taking too long to build.
^ permalink raw reply [relevance 7%]
Results 1-3 of 3 | reverse | options above
-- pct% links below jump to the message on this page, permalinks otherwise --
2013-09-01 14:03 Concurrency issue in TestKgioUnixConnect? Jérémy Bobbio
2013-09-01 16:57 ` Hleb Valoshka
2013-09-01 19:58 ` Eric Wong
2013-09-02 12:57 ` Hleb Valoshka
2013-09-02 21:24 7% ` Eric Wong
2013-09-03 8:50 0% ` Hleb Valoshka
2013-09-11 0:29 7% [ANN] kgio 2.8.1 - minor improvements and test fixes Eric Wong
Code repositories for project(s) associated with this public inbox
https://yhbt.net/kgio.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).