* [PATCH 1/3] accept4: require SOCK_NONBLOCK/SOCK_CLOEXEC macros
2012-03-05 23:45 5% ` Eric Wong
@ 2012-03-05 23:47 7% ` Eric Wong
0 siblings, 0 replies; 2+ results
From: Eric Wong @ 2012-03-05 23:47 UTC (permalink / raw)
To: kgio
The check for the accept4() function actually succeeds on a
stock installation of Debian GNU/kFreeBSD 6.0, but the
eglibc headers fail to define the necessary flags.
---
ext/kgio/missing_accept4.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/ext/kgio/missing_accept4.h b/ext/kgio/missing_accept4.h
index 2801b5d..3e9ec67 100644
--- a/ext/kgio/missing_accept4.h
+++ b/ext/kgio/missing_accept4.h
@@ -1,4 +1,4 @@
-#ifndef HAVE_ACCEPT4
+#if !defined(HAVE_ACCEPT4) || !defined(SOCK_CLOEXEC) || !defined(SOCK_NONBLOCK)
# ifndef _GNU_SOURCE
# define _GNU_SOURCE
# endif
--
1.7.9.2.358.g22243
^ permalink raw reply related [relevance 7%]
* Re: kgio, autopush test fails on Debian GNU/kFreeBSD
@ 2012-03-05 23:45 5% ` Eric Wong
2012-03-05 23:47 7% ` [PATCH 1/3] accept4: require SOCK_NONBLOCK/SOCK_CLOEXEC macros Eric Wong
0 siblings, 1 reply; 2+ results
From: Eric Wong @ 2012-03-05 23:45 UTC (permalink / raw)
To: kgio
375gnu <375gnu@gmail.com> wrote:
> On 3/5/12, Eric Wong <normalperson@yhbt.net> wrote:
> >> In the last assertion getsockopt returns 0. May be it's good behavior for
> >> GNU/kFreeBSD, I don't know.
> >
> > I think this problem is partially caused by eglibc/glibc failing to
> > define TCP_NOPUSH in the headers.
>
> No, /usr/include/netinet/tcp.h has definition for TCP_NOPUSH. There is a Debian
> specific patch which defines it.
OK. I've pushed out a 3 fixes to get this building on my
Debian GNU/kFreeBSD 6.0 KVM instance to "master" of
git://bogomips.org/kgio.git
accept4: require SOCK_NONBLOCK/SOCK_CLOEXEC macros
autopush: fix/enable under Debian GNU/kFreeBSD
test: increase delta range for timing-sensitive test
^ permalink raw reply [relevance 5%]
Results 1-2 of 2 | reverse | options above
-- pct% links below jump to the message on this page, permalinks otherwise --
2012-03-04 16:02 kgio, autopush test fails on Debian GNU/kFreeBSD 375gnu
2012-03-05 8:43 ` Eric Wong
2012-03-05 18:59 ` 375gnu
2012-03-05 23:45 5% ` Eric Wong
2012-03-05 23:47 7% ` [PATCH 1/3] accept4: require SOCK_NONBLOCK/SOCK_CLOEXEC macros Eric Wong
Code repositories for project(s) associated with this public inbox
https://yhbt.net/kgio.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).