From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: X-Spam-Status: No, score=-3.3 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from mail-lf1-x136.google.com (mail-lf1-x136.google.com [IPv6:2a00:1450:4864:20::136]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 141331F5AE for ; Mon, 24 May 2021 21:11:32 +0000 (UTC) Received: by mail-lf1-x136.google.com with SMTP id q1so173709lfo.3 for ; Mon, 24 May 2021 14:11:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Lc0aJWgcH5sOZnMJRpzBTxJ2HuoFquXUewvL/4LkQ14=; b=MBWdZNkRMg4Lv+izVha0drJdBLwIviUhDSBdQuGZhHT+lvCWXiH5XZfONdh5VrnxlN hg+2JFwM4pct2JaBYrrvKGYxPtxa7CqpBZJ6W2xHjfa1cGI4fD7xR18ZRXNnaivMPFBP lEhdQNOi/2U4pvKE0YmFTj+Od9xwL2YtgnPrqPHUa2MrF1z1muEzFThRC4PlRrUcrIcZ lknIWQPVXYk14za2GOioQ+Kbo3tT5QQegC/4ty/uVTtQ4xO2IJ6dQCYLojawpNe00FY0 +haeQn7u74iAs1vQTZ4afl4s4EUOuv0WUcy43CqPvZrjXiqT0CXRSl8Okxlp9z7pTiXF 83dQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Lc0aJWgcH5sOZnMJRpzBTxJ2HuoFquXUewvL/4LkQ14=; b=OhYqB6vYRPwX2F3s5cJP6CyX2RHP845GhMO4OwnfpTuDOAc58JDSTkD0UtQP7pN34R 8RBaAQX8Z9cBs4ExTFSJ2kGTFOg6wucAghZ7QGwJzSAgvxdtwiQZmt47ZuhnLi5HYMJo xVx2cNkMPuv3TUgUPpCoEw9nC8koMCgdaP4tkAO0h8pAs9PglU9N7+r6lZNKSF07zuGP cge3t/ckfi6w8SzIE5R7rfbsj6Jk4icnr4x3aSj8Uh3N4jT1TNH8rvINMHhhWR0UDPfy mdD3r08+GAvofpgR09WuWOumSF/nbdYTm40F0QKdMtyjjIjlkXZGS3pH6jrv/y+LA2wb muBg== X-Gm-Message-State: AOAM532D3fpIAgnEwmg98ENT+rCGIBgy7YR+YPo/xj64ZQI2oocN8uVH Zy43T38iMaFLRQ1XAVEP/ywN5XYZx5eo0wjg5kwPaB9qzZmDCw== X-Google-Smtp-Source: ABdhPJxQUODbA4tRkCiC/nL6FRXgJ6Ha5Ds7nLDfE3+T17L0hkFBx5hJraSd/0TrYlc2wztPvkJvGqZRam7NsUfiUlQ= X-Received: by 2002:a19:7f10:: with SMTP id a16mr12057338lfd.238.1621890689220; Mon, 24 May 2021 14:11:29 -0700 (PDT) MIME-Version: 1.0 References: <20210524172208.GA7627@dcvr> <20210524203310.GA17864@dcvr> In-Reply-To: <20210524203310.GA17864@dcvr> From: Ngan Pham Date: Mon, 24 May 2021 14:11:17 -0700 Message-ID: Subject: Re: Patch for GC.compact memory issue To: Eric Wong Cc: kgio-public@yhbt.net, Aaron Patterson Content-Type: text/plain; charset="UTF-8" List-Id: > Side note: Sorry if you found it confusing, I figured "README" > and "HACKING" are clearly labeled. Not sure how to improve on > a directory listing for ease-of-navigation (works with "lftp" :>) My apologies! After actually spending time and reading your docs, it's pretty straight forward. Perhaps I'm spoiled with GitHub pull requests and whatnot. The HACKING doc also says "pull requests" welcome, although I'm not sure where... > OK, so rb_const_get for things like Socket, Errno::EPIPE, > Errno::ECONNRESET are fine (for now)? I'll defer to Aaron. :-) > Anyways, I hope to find time to drop kgio from unicorn later > this year (I started a few years ago...). Cool. > And I really wish unicorn never became popular, it was only > created to support buggy legacy apps that were too expensive to > fix. Shame you feel this way. Unicorn is amazing work and empowered people/businesses across the world to do their job. You should be proud. On Mon, May 24, 2021 at 1:33 PM Eric Wong wrote: > > Ngan Pham wrote: > > Hey Eric, actually there's 2 more references that need to be marked. > > Thanks, will apply those. More about this at bottom.. +Cc tenderlove > > > @nganpham: Regarding actually fixing this on kgio, do you have > > contacts to maintainer(s)? Or should I follow the instructions on the > > (super confusing) site? https://yhbt.net/kgio/ > > Side note: Sorry if you found it confusing, I figured "README" > and "HACKING" are clearly labeled. Not sure how to improve on > a directory listing for ease-of-navigation (works with "lftp" :>) > > > @tenderlove: I think the other "const_gets" in that file probably need > > the same treatment. > > https://yhbt.net/kgio.git/tree/ext/kgio/accept.c#n501 and > > https://yhbt.net/kgio.git/tree/ext/kgio/accept.c#n503 If a constant is > > defined in pure Ruby (not with rb_define_class), then it's also > > allowed to move. > > @nganpham: oof! You're right! I will amend the patch. Good catch. > > OK, so rb_const_get for things like Socket, Errno::EPIPE, > Errno::ECONNRESET are fine (for now)? > > Anyways, I hope to find time to drop kgio from unicorn later > this year (I started a few years ago...). > > And I really wish unicorn never became popular, it was only > created to support buggy legacy apps that were too expensive to > fix.