From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <aaron@tenderlovemaking.com>
X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net
X-Spam-Level: 
X-Spam-ASN: AS15169 209.85.128.0/17
X-Spam-Status: No, score=-2.7 required=3.0 tests=BAYES_00,
	HEADER_FROM_DIFFERENT_DOMAINS,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H3,
	RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE shortcircuit=no autolearn=no
	autolearn_force=no version=3.4.2
Received: from mail-qt1-f173.google.com (mail-qt1-f173.google.com [209.85.160.173])
	(using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)
	 key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256)
	(No client certificate requested)
	by dcvr.yhbt.net (Postfix) with ESMTPS id 02B041F5AE
	for <kgio-public@yhbt.net>; Tue, 25 May 2021 16:41:22 +0000 (UTC)
Received: by mail-qt1-f173.google.com with SMTP id h24so12160409qtm.12
        for <kgio-public@yhbt.net>; Tue, 25 May 2021 09:41:21 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20161025;
        h=x-gm-message-state:mime-version:references:in-reply-to:from:date
         :message-id:subject:to:cc;
        bh=5SJm3r05zHA+e1rfmikXxGfr+zovUYEcCP0ahCrk3mw=;
        b=oDtkOrEkeTFRazE216Da+tplfDOo71ziWxOdK2rWQw/d93bm90pEyfSbign38JLOeo
         bQtBg7NlOTit9CzZo5IY66Roaf412P1uA179YB6CP49hQYsb1fx9TgkPzAF6d48cYsKz
         S+tBHzGygyTf+3i4xQn0YLySUXFyTqdrCuAclPU2WgX593zcmJs7Hm6bLbz3wRBnw1zl
         u0+SB7lwouza4ayyb5yBggEx5u1otzEUUMTc66LTIlkCh2UkpVZaFnIH3+Fjema6omDf
         bQdz5P0yzp4vXxEl5PMfco9MBAKwrwoklTy3qO60RNCNBddk463wN345n7g73uGzo+NY
         ktcQ==
X-Gm-Message-State: AOAM531lOAx1f0cFzHehZoN4PD3OkQsCm4W+bs6JpL+NGJecU83tk/hV
	OUxZBBpyhYW9u7RhVWWNsyKyuqm0lULo4ibaJV9GGw==
X-Google-Smtp-Source: ABdhPJzI2QxUs8olh3ETU4tCPYbrEY4naRgTkEcKMhVdZVqCDgdAUrGn/QRDD7IgKG88xJisgIMgXvu6DifW4SFs8aY=
X-Received: by 2002:ac8:594a:: with SMTP id 10mr32055022qtz.293.1621960880570;
 Tue, 25 May 2021 09:41:20 -0700 (PDT)
MIME-Version: 1.0
References: <CAAvYYt480L4izvVmLnOvQCe5N=bq3cBZ=FrDyQoo=jD3e0qfsg@mail.gmail.com>
 <20210524172208.GA7627@dcvr> <CAAvYYt5Z5f2rMuXO5DMpR1-6uRvu_gXKDvqcyoZ+oNcLiTH39g@mail.gmail.com>
 <20210524203310.GA17864@dcvr> <CAAvYYt6ruhhZcA4OmF=NQZ+-j0RJ0vT5f33tUCrREezo5mUCVQ@mail.gmail.com>
In-Reply-To: <CAAvYYt6ruhhZcA4OmF=NQZ+-j0RJ0vT5f33tUCrREezo5mUCVQ@mail.gmail.com>
From: Aaron Patterson <tenderlove@ruby-lang.org>
Date: Tue, 25 May 2021 09:41:09 -0700
Message-ID: <CAPJJa7txP7D9s5AOLFxs_Kxuvq_Yx_5BBYMbafdn8LaGjb-yvA@mail.gmail.com>
Subject: Re: Patch for GC.compact memory issue
To: Ngan Pham <nganpham@gmail.com>
Cc: Eric Wong <e@80x24.org>, kgio-public@yhbt.net
Content-Type: text/plain; charset="UTF-8"
List-Id: <kgio-public.yhbt.net>

On Mon, May 24, 2021 at 2:11 PM Ngan Pham <nganpham@gmail.com> wrote:
>
> > Side note: Sorry if you found it confusing, I figured "README"
> >   and "HACKING" are clearly labeled.  Not sure how to improve on
> >   a directory listing for ease-of-navigation (works with "lftp" :>)
>
> My apologies! After actually spending time and reading your
> docs, it's pretty straight forward. Perhaps I'm spoiled with GitHub
> pull requests and whatnot. The HACKING doc also says "pull
> requests" welcome, although I'm not sure where...
>
> > OK, so rb_const_get for things like Socket, Errno::EPIPE,
> > Errno::ECONNRESET are fine (for now)?
>
> I'll defer to Aaron. :-)


Yes, they should be fine.  It looks like they're all defined with
`rb_define_const`, and that function adds them to a list that gets
pinned.