From: Rafael J. Wysocki <rafael at kernel.org>
To: devel@acpica.org
Subject: [Devel] Re: [PATCH] ACPI: APEI: Fix num_ghes to unsigned int
Date: Wed, 05 Oct 2022 16:28:40 +0200 [thread overview]
Message-ID: <CAJZ5v0h72L+U60=fBK5LOaNr5bCj9ukwcW8Pn2CCgx0jt1e1Kw@mail.gmail.com> (raw)
In-Reply-To: 20221004230541.449243-1-Ashish.Kalra@amd.com
[-- Attachment #1: Type: text/plain, Size: 1478 bytes --]
On Wed, Oct 5, 2022 at 1:06 AM Ashish Kalra <Ashish.Kalra(a)amd.com> wrote:
>
> From: Ashish Kalra <ashish.kalra(a)amd.com>
>
> Change num_ghes from int to unsigned int, preventing an overflow
> and causing subsequent vmalloc to fail.
So do you have a system where int is not sufficient?
> Signed-off-by: Ashish Kalra <ashish.kalra(a)amd.com>
> ---
> drivers/acpi/apei/ghes.c | 2 +-
> include/acpi/ghes.h | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/acpi/apei/ghes.c b/drivers/acpi/apei/ghes.c
> index d91ad378c00d..6d7c202142a6 100644
> --- a/drivers/acpi/apei/ghes.c
> +++ b/drivers/acpi/apei/ghes.c
> @@ -163,7 +163,7 @@ static void ghes_unmap(void __iomem *vaddr, enum fixed_addresses fixmap_idx)
> clear_fixmap(fixmap_idx);
> }
>
> -int ghes_estatus_pool_init(int num_ghes)
> +int ghes_estatus_pool_init(unsigned int num_ghes)
> {
> unsigned long addr, len;
> int rc;
> diff --git a/include/acpi/ghes.h b/include/acpi/ghes.h
> index 34fb3431a8f3..292a5c40bd0c 100644
> --- a/include/acpi/ghes.h
> +++ b/include/acpi/ghes.h
> @@ -71,7 +71,7 @@ int ghes_register_vendor_record_notifier(struct notifier_block *nb);
> void ghes_unregister_vendor_record_notifier(struct notifier_block *nb);
> #endif
>
> -int ghes_estatus_pool_init(int num_ghes);
> +int ghes_estatus_pool_init(unsigned int num_ghes);
>
> /* From drivers/edac/ghes_edac.c */
>
> --
> 2.25.1
>
next reply other threads:[~2022-10-05 14:28 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-05 14:28 Rafael J. Wysocki [this message]
-- strict thread matches above, loose matches on Subject: below --
2022-10-05 15:49 [Devel] Re: [PATCH] ACPI: APEI: Fix num_ghes to unsigned int Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJZ5v0h72L+U60=fBK5LOaNr5bCj9ukwcW8Pn2CCgx0jt1e1Kw@mail.gmail.com' \
--to=devel@acpica.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).