From: "Rafael J. Wysocki" <rafael@kernel.org>
To: Ben Dooks <ben.dooks@codethink.co.uk>
Cc: linux-acpi@vger.kernel.org,
acpica-devel@lists.linuxfoundation.org, robert.moore@intel.com,
lenb@kernel.org
Subject: Re: [Acpica-devel] [PATCH] ACPI: fix undeclared symbols from saprse
Date: Tue, 4 Jul 2023 19:06:13 +0200 [thread overview]
Message-ID: <CAJZ5v0jXBZNXKJGuMFp7Oh7K6ndnKqruWvAVdiRB4c0LYv48Sw@mail.gmail.com> (raw)
In-Reply-To: <20230703122450.951704-1-ben.dooks@codethink.co.uk>
On Mon, Jul 3, 2023 at 2:24 PM Ben Dooks <ben.dooks@codethink.co.uk> wrote:
>
> The building of drivers/acpi/acpica/utglobal.o is throwing
> a number of sparse warnins about undeclared symbols. This is
> due to defining DEFINE_ACPI_GLOBALS then making the macro
> ACPI_INIT_GLOBAL() define it but never declaring the fact this
> is an extern declared varible.
>
> This is some of the sparse warnings that are being fixed here:
>
> drivers/acpi/acpica/utglobal.c: note: in included file (through include/acpi/acpi.h):
> ./include/acpi/acpixf.h:104:1: warning: symbol 'acpi_gbl_enable_interpreter_slack' was not declared. Should it be static?
> ./include/acpi/acpixf.h:113:1: warning: symbol 'acpi_gbl_auto_serialize_methods' was not declared. Should it be static?
> ./include/acpi/acpixf.h:120:1: warning: symbol 'acpi_gbl_create_osi_method' was not declared. Should it be static?
> ./include/acpi/acpixf.h:126:1: warning: symbol 'acpi_gbl_use_default_register_widths' was not declared. Should it be static?
> ./include/acpi/acpixf.h:136:1: warning: symbol 'acpi_gbl_enable_table_validation' was not declared. Should it be static?
> ./include/acpi/acpixf.h:141:1: warning: symbol 'acpi_gbl_enable_aml_debug_object' was not declared. Should it be static?
> ./include/acpi/acpixf.h:149:1: warning: symbol 'acpi_gbl_copy_dsdt_locally' was not declared. Should it be static?
> ./include/acpi/acpixf.h:157:1: warning: symbol 'acpi_gbl_do_not_use_xsdt' was not declared. Should it be static?
>
> Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>
> ---
> Note, if this isn't the correct place to fix, where should this be
> going?
This file belongs to ACPICA. As a general rule, ACPICA changes should
be submitted as pull requests to the upstream ACPICA project on
GitHub, from where they are backported (semi-automatically) to Linux.
However, if an upstream ACPICA pull request has been submitted, a
corresponding Linux patch can be posted with a Link: tag pointing to
that pull request.
Thanks!
> ---
> include/acpi/acpixf.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/include/acpi/acpixf.h b/include/acpi/acpixf.h
> index 9ffdc0425bc2..8d69d1e39cd9 100644
> --- a/include/acpi/acpixf.h
> +++ b/include/acpi/acpixf.h
> @@ -37,6 +37,7 @@
> type name
>
> #define ACPI_INIT_GLOBAL(type,name,value) \
> + extern type name; \
> type name=value
>
> #else
> --
> 2.40.1
>
prev parent reply other threads:[~2023-07-04 17:06 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-03 13:29 [Acpica-devel] [PATCH] ACPI: fix undeclared symbols from saprse Ben Dooks
2023-07-04 17:06 ` Rafael J. Wysocki [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJZ5v0jXBZNXKJGuMFp7Oh7K6ndnKqruWvAVdiRB4c0LYv48Sw@mail.gmail.com \
--to=rafael@kernel.org \
--cc=acpica-devel@lists.linuxfoundation.org \
--cc=ben.dooks@codethink.co.uk \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=robert.moore@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).