From: Raag Jadav <raag.jadav@intel.com>
To: mika.westerberg@linux.intel.com,
andriy.shevchenko@linux.intel.com, rafael@kernel.org,
lenb@kernel.org, robert.moore@intel.com, ardb@kernel.org,
will@kernel.org, mark.rutland@arm.com
Cc: linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org,
acpica-devel@lists.linuxfoundation.org,
linux-efi@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
mallikarjunappa.sangannavar@intel.com, bala.senthil@intel.com
Subject: Re: [PATCH v3 5/5] perf: arm_cspmu: drop redundant acpi_dev_uid_to_integer()
Date: Sat, 9 Dec 2023 10:48:23 +0200 [thread overview]
Message-ID: <ZXQp18e9IR5w41wW@black.fi.intel.com> (raw)
In-Reply-To: <20231123100617.28020-6-raag.jadav@intel.com>
On Thu, Nov 23, 2023 at 03:36:17PM +0530, Raag Jadav wrote:
> Now that we have _UID matching support for integer types, we can use
> acpi_dev_hid_uid_match() for it.
>
> Signed-off-by: Raag Jadav <raag.jadav@intel.com>
> Acked-by: Will Deacon <will@kernel.org>
> ---
> drivers/perf/arm_cspmu/arm_cspmu.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/perf/arm_cspmu/arm_cspmu.c b/drivers/perf/arm_cspmu/arm_cspmu.c
> index 2cc35dded007..50b89b989ce7 100644
> --- a/drivers/perf/arm_cspmu/arm_cspmu.c
> +++ b/drivers/perf/arm_cspmu/arm_cspmu.c
> @@ -1108,7 +1108,6 @@ static int arm_cspmu_request_irq(struct arm_cspmu *cspmu)
>
> static inline int arm_cspmu_find_cpu_container(int cpu, u32 container_uid)
> {
> - u64 acpi_uid;
> struct device *cpu_dev;
> struct acpi_device *acpi_dev;
>
> @@ -1118,8 +1117,7 @@ static inline int arm_cspmu_find_cpu_container(int cpu, u32 container_uid)
>
> acpi_dev = ACPI_COMPANION(cpu_dev);
> while (acpi_dev) {
> - if (acpi_dev_hid_uid_match(acpi_dev, ACPI_PROCESSOR_CONTAINER_HID, NULL) &&
> - !acpi_dev_uid_to_integer(acpi_dev, &acpi_uid) && acpi_uid == container_uid)
> + if (acpi_dev_hid_uid_match(acpi_dev, ACPI_PROCESSOR_CONTAINER_HID, container_uid))
> return 0;
On second thought, I just realized that this can cause false positive
in case container_uid is integer 0.
I'm not aware if that's a valid value to match against in APMT.
If it is, it's better to drop patches 2 and 5 for now.
Raag
next prev parent reply other threads:[~2023-12-09 8:48 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-23 10:06 [PATCH v3 0/5] Support _UID matching for integer types Raag Jadav
2023-11-23 10:06 ` [PATCH v3 1/5] ACPI: bus: update acpi_dev_uid_match() to support multiple types Raag Jadav
2023-11-23 10:06 ` [PATCH v3 2/5] ACPI: bus: update acpi_dev_hid_uid_match() " Raag Jadav
2023-11-23 10:06 ` [PATCH v3 3/5] ACPI: LPSS: use acpi_dev_uid_match() for matching _UID Raag Jadav
2023-11-23 10:06 ` [PATCH v3 4/5] efi: dev-path-parser: " Raag Jadav
2023-11-23 10:06 ` [PATCH v3 5/5] perf: arm_cspmu: drop redundant acpi_dev_uid_to_integer() Raag Jadav
2023-12-09 8:48 ` Raag Jadav [this message]
2023-12-05 4:10 ` [PATCH v3 0/5] Support _UID matching for integer types Raag Jadav
2023-12-05 11:58 ` Rafael J. Wysocki
2023-12-06 19:44 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZXQp18e9IR5w41wW@black.fi.intel.com \
--to=raag.jadav@intel.com \
--cc=acpica-devel@lists.linuxfoundation.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=ardb@kernel.org \
--cc=bala.senthil@intel.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-efi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mallikarjunappa.sangannavar@intel.com \
--cc=mark.rutland@arm.com \
--cc=mika.westerberg@linux.intel.com \
--cc=rafael@kernel.org \
--cc=robert.moore@intel.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).