From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52029) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z5SCo-0002vL-6l for qemu-devel@nongnu.org; Thu, 18 Jun 2015 01:17:39 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Z5SCg-0001WW-JK for qemu-devel@nongnu.org; Thu, 18 Jun 2015 01:17:38 -0400 Received: from mail.ispras.ru ([83.149.199.45]:55062) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z5SCg-0001Vy-Bs for qemu-devel@nongnu.org; Thu, 18 Jun 2015 01:17:30 -0400 From: "Pavel Dovgaluk" References: <20150617124158.3316.54954.stgit@PASHA-ISP> <20150617124205.3316.81361.stgit@PASHA-ISP> <55816DAE.8090701@redhat.com> In-Reply-To: <55816DAE.8090701@redhat.com> Date: Thu, 18 Jun 2015 08:17:29 +0300 Message-ID: <000901d0a986$139ca850$3ad5f8f0$@Dovgaluk@ispras.ru> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Content-Language: ru Subject: Re: [Qemu-devel] [PATCH v2 1/3] softmmu: add helper function to pass through retaddr List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: 'Paolo Bonzini' , qemu-devel@nongnu.org Cc: rth7680@gmail.com, leon.alrae@imgtec.com, aurelien@aurel32.net > From: Paolo Bonzini [mailto:pbonzini@redhat.com] > On 17/06/2015 14:42, Pavel Dovgalyuk wrote: > > This patch introduces several helpers to pass return address > > which points to the TB. Correct return address allows correct > > restoring of the guest PC and icount. These functions should be used when > > helpers embedded into TB invoke memory operations. > > > > Signed-off-by: Pavel Dovgalyuk > > --- > > include/exec/cpu_ldst_template.h | 42 +++++++++++++++++++++++++++++++------- > > include/exec/exec-all.h | 27 ++++++++++++++++++++++++ > > softmmu_template.h | 18 ++++++++++++++++ > > 3 files changed, 79 insertions(+), 8 deletions(-) > > > > diff --git a/include/exec/cpu_ldst_template.h b/include/exec/cpu_ldst_template.h > > index 95ab750..1847816 100644 > > --- a/include/exec/cpu_ldst_template.h > > +++ b/include/exec/cpu_ldst_template.h > > @@ -62,7 +62,9 @@ > > /* generic load/store macros */ > > > > static inline RES_TYPE > > -glue(glue(cpu_ld, USUFFIX), MEMSUFFIX)(CPUArchState *env, target_ulong ptr) > > +glue(glue(glue(cpu_ld, USUFFIX), MEMSUFFIX), _ra)(CPUArchState *env, > > + target_ulong ptr, > > + uintptr_t retaddr) > > Would it make sense to call these helper_cpu_ld##USUFFIX##MEMSUFFIX? I don't want to use 'helper' prefix, because helper functions are usually called directly from TB. Pavel Dovgalyuk