All the mail mirrored from lore.kernel.org
 help / color / mirror / Atom feed
From: "Jindal, Sonika" <sonika.jindal@intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>,
	Daniel Vetter <daniel@ffwll.ch>,
	"intel-gfx@lists.freedesktop.org"
	<intel-gfx@lists.freedesktop.org>
Subject: Re: [PATCH 4/5] drm/i915: Check live status before reading edid
Date: Tue, 2 Aug 2016 15:04:31 +0000	[thread overview]
Message-ID: <000C66961D35964B9714611E548C10AD0CEA9F2A@BGSMSX104.gar.corp.intel.com> (raw)
In-Reply-To: <20160802143223.GA20686@nuc-i3427.alporthouse.com>

Yes we had the issue of incorrect edid read.
But as of now you can go ahead with the revert.
I have moved to a different group, so I am not working on this anymore.

Regards,
Sonika

-----Original Message-----
From: Chris Wilson [mailto:chris@chris-wilson.co.uk] 
Sent: Tuesday, August 2, 2016 8:02 PM
To: Daniel Vetter <daniel@ffwll.ch>; Jindal, Sonika <sonika.jindal@intel.com>; intel-gfx@lists.freedesktop.org
Subject: Re: [Intel-gfx] [PATCH 4/5] drm/i915: Check live status before reading edid

On Tue, Jul 12, 2016 at 02:39:47PM +0300, David Weinehall wrote:
> I'm feeling sorely tempted to treat this as a proper regression, and 
> simply submit a revert patch, seeing as it slows down resume by 
> something like 200ms, but seeing as there was mention of a case where 
> incorrect EDID-information might end up being read after resume on 
> some Chromebooks, I'll just try to open a discussion instead.

Wrt https://bugs.freedesktop.org/show_bug.cgi?id=97139 this is a regression and I'll ack the revert. Yes, we need to resolve exactly how we get a stall between intel_hdmi_detect() and pageflip/cursor, but the onus is on the submitter of the patch to fix existing issues first to prevent such regressions (if possible, or else mitigate them).
-Chris

--
Chris Wilson, Intel Open Source Technology Centre
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  reply	other threads:[~2016-08-02 15:05 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-09 12:04 [PATCH 0/5] HDMI optimization series Sonika Jindal
2015-07-09 12:04 ` [PATCH 1/5] drm/i915: add attached connector to hdmi container Sonika Jindal
2015-07-09 12:04 ` [PATCH 2/5] drm/i915: Add HDMI probe function Sonika Jindal
2015-07-09 12:04 ` [PATCH 3/5] drm/i915: Read HDMI EDID only when required Sonika Jindal
2015-07-09 12:04 ` [PATCH 4/5] drm/i915: Check live status before reading edid Sonika Jindal
2015-07-09 17:27   ` Daniel Vetter
2015-07-10  4:31     ` Jindal, Sonika
2015-07-13 11:05       ` [PATCH] " Sonika Jindal
2015-07-13 14:55         ` Daniel Vetter
2015-07-14  4:46           ` Jindal, Sonika
2015-07-14  7:55             ` Daniel Vetter
2016-07-12 11:39     ` [PATCH 4/5] " David Weinehall
2016-07-13 11:59       ` Daniel Vetter
2016-07-13 12:09         ` Chris Wilson
2016-07-13 12:17           ` Chris Wilson
2016-07-14 17:42             ` David Weinehall
2016-08-01 10:09       ` Chris Wilson
2016-08-02 14:32       ` Chris Wilson
2016-08-02 15:04         ` Jindal, Sonika [this message]
2015-07-09 12:04 ` [PATCH 5/5] drm/i915: Set edid from detect only if forced Sonika Jindal
2015-07-09 15:24   ` shuang.he
2015-07-13 10:49   ` [PATCH] drm/i915: Set edid from init and not from detect Sonika Jindal
2015-07-13 11:40     ` Chris Wilson
2015-07-13 11:59       ` Jindal, Sonika
2015-07-13 14:57         ` Daniel Vetter
2015-07-14  3:48           ` Sharma, Shashank
2015-07-14  7:59             ` Daniel Vetter
2015-07-14  8:09               ` Sharma, Shashank
2015-07-14  9:03                 ` Daniel Vetter
2015-07-14 11:33                   ` Sharma, Shashank

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=000C66961D35964B9714611E548C10AD0CEA9F2A@BGSMSX104.gar.corp.intel.com \
    --to=sonika.jindal@intel.com \
    --cc=chris@chris-wilson.co.uk \
    --cc=daniel@ffwll.ch \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.