All the mail mirrored from lore.kernel.org
 help / color / mirror / Atom feed
From: "Namjae Jeon" <namjae.jeon@samsung.com>
To: "'Eric Sandeen'" <sandeen@sandeen.net>,
	"'Namjae Jeon'" <linkinjeon@kernel.org>
Cc: "'linux-fsdevel'" <linux-fsdevel@vger.kernel.org>,
	"'Pavel Reichl'" <preichl@redhat.com>,
	<chritophe.vu-brugier@seagate.com>,
	"'Hyeoncheol Lee'" <hyc.lee@gmail.com>
Subject: RE: problem with exfat on 4k logical sector devices
Date: Wed, 12 May 2021 08:53:10 +0900	[thread overview]
Message-ID: <001201d746c0$cc8da8e0$65a8faa0$@samsung.com> (raw)
In-Reply-To: <276da0be-a44b-841e-6984-ecf3dc5da6f0@sandeen.net>

> On 5/11/21 4:21 PM, Namjae Jeon wrote:
> >> Hi Namjae -
> > Hi Eric,
> >>
> >> It seems that exfat is unhappy on 4k logical sector size devices:
> > Thanks for your report!
> > We have got same report from Christophe Vu-Brugier. And he sent us the
> > patch(https://protect2.fireeye.com/v1/url?k=ac8f77ef-f3144ef5-ac8efca0
> > -000babff24ad-8b7be88b031de920&q=1&e=0e9634f8-7ff9-4eb8-b5af-2316b62e9
> > 236&u=https%3A%2F%2Fgithub.com%2Fexfatprogs%2Fexfatprogs%2Fpull%2F164)
> > to fix it yesterday.(Thanks Christophe!), I will check it today
> 
> Oh, good timing! ;)
> 
> gI'll try to look at that in more depth. It does seem to make everything work for me, and resolves a
> couple other misunderstandings I may have had, and they seem to match with the spec.
> 
> For example, I now see that boot sector signature does go at the end of 512 for the primary boot
> sector, and at the end of $SECTOR_SIZE for the extended boot sector.
Thanks for your check:)

> 
> One other thing that I ran across is that fsck seems to validate an image against the sector size of
> the device hosting the image rather than the sector size found in the boot sector, which seems like
> another issue that will come up:
> 
> # fsck/fsck.exfat /dev/sdb
> exfatprogs version : 1.1.1
> /dev/sdb: clean. directories 1, files 0
> 
> # dd if=/dev/sdb of=test.img
> 524288+0 records in
> 524288+0 records out
> 268435456 bytes (268 MB) copied, 1.27619 s, 210 MB/s
> 
> # fsck.exfat test.img
> exfatprogs version : 1.1.1
> checksum of boot region is not correct. 0, but expected 0x3ee721 boot region is corrupted. try to
> restore the region from backup. Fix (y/N)? n
> 
> Right now the utilities seem to assume that the device they're pointed at is always a block device,
> and image files are problematic.
Okay, Will fix it.
> 
> Also, as an aside, it might be useful to have a "set sector size" commandline option at least for
> testing, or to create 4k images that could be transferred to a 4k device.
Agreed, We will add that option:)

Thanks!
> 
> Thanks,
> -Eric


  reply	other threads:[~2021-05-11 23:53 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-11 17:28 problem with exfat on 4k logical sector devices Eric Sandeen
2021-05-11 21:21 ` Namjae Jeon
2021-05-11 23:33   ` Eric Sandeen
2021-05-11 23:53     ` Namjae Jeon [this message]
2021-05-11 23:57       ` Eric Sandeen
2021-05-12 14:09         ` Hyunchul Lee
2021-05-12 16:44           ` Eric Sandeen
2021-05-12 17:56             ` Eric Sandeen
2021-05-13  6:53               ` Namjae Jeon
2021-05-13  6:52             ` Namjae Jeon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='001201d746c0$cc8da8e0$65a8faa0$@samsung.com' \
    --to=namjae.jeon@samsung.com \
    --cc=chritophe.vu-brugier@seagate.com \
    --cc=hyc.lee@gmail.com \
    --cc=linkinjeon@kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=preichl@redhat.com \
    --cc=sandeen@sandeen.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.