From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kukjin Kim Subject: RE: [PATCHv6] ARM: dts: add exynos5422-cpus.dtsi to correct cpu order Date: Wed, 29 Jul 2015 10:05:22 +0900 Message-ID: <044601d0c99a$a5218b90$ef64a2b0$@kernel.org> References: <1436833441-8405-1-git-send-email-parkch98@gmail.com> <55A45C63.2030907@samsung.com> <06b101d0bdf2$8aad8fb0$a008af10$@kernel.org> <075c01d0be0e$587fe260$097fa720$@kernel.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Received: from mailout2.samsung.com ([203.254.224.25]:57449 "EHLO mailout2.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750932AbbG2BFY convert rfc822-to-8bit (ORCPT ); Tue, 28 Jul 2015 21:05:24 -0400 Received: from epcpsbgr2.samsung.com (u142.gpu120.samsung.co.kr [203.254.230.142]) by mailout2.samsung.com (Oracle Communications Messaging Server 7.0.5.31.0 64bit (built May 5 2014)) with ESMTP id <0NS802Z3C5OYJT00@mailout2.samsung.com> for linux-samsung-soc@vger.kernel.org; Wed, 29 Jul 2015 10:05:22 +0900 (KST) In-reply-to: Content-language: ko Sender: linux-samsung-soc-owner@vger.kernel.org List-Id: linux-samsung-soc@vger.kernel.org To: chanho61.park@samsung.com, 'Kukjin Kim' Cc: 'Krzysztof Kozlowski' , linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org Chanho Park wrote: >=20 > Hi, >=20 > On Tue, Jul 14, 2015 at 5:23 PM, Kukjin Kim wrote: > > Chanho Park wrote: > >> > >> Hi Kukjin, > >> > >> On Tue, Jul 14, 2015 at 2:04 PM, Kukjin Kim wro= te: > >> > Krzysztof Kozlowski wrote: > >> >> > >> >> On 14.07.2015 09:24, Chanho Park wrote: > >> >> > The odroid-xu3 board which is based on exynos5422 not exynos5= 800 is > >> >> > booted from cortex-a7 core unlike exynos5800. The odroid-xu3'= s cpu order > >> >> > is quite strange. cpu0 and cpu5-7 are cortex-a7 cores and cpu= 1-4 are > >> >> > cortex-a15 cores. To correct this mis-odering, I added exynos= 5422-cpus.dtsi > >> >> > and reversing cpu orders from exynos5420. Now, cpu0-3 are cor= tex-a7 and > >> >> > cpu4-7 are cortex-a15. > >> >> > > >> >> > Reviewed-by: Krzysztof Kozlowski > >> >> > Signed-off-by: Chanho Park > >> >> > --- > > > > [...] > > > >> >> > > >> >> > Secondary cpu booting problem[1] is not resolved yet. Need mo= re investigations > >> >> > to work booting 8 cores correctly. > >> >> > > >> >> > [1]: http://www.spinics.net/lists/linux-samsung-soc/msg45525.= html > >> >> > > >> >> > arch/arm/boot/dts/exynos5422-cpus.dtsi | 81 ++++= ++++++++++++++++++ > >> >> > arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi | 1 + > >> >> > 2 files changed, 82 insertions(+) > >> >> > create mode 100644 arch/arm/boot/dts/exynos5422-cpus.dtsi > >> >> > >> >> Thanks, applied to my tree. I'll send it to Kukjin for v4.3 unl= ess he > >> >> picks it also. > >> >> > >> > Well, let me see. I'm thinking we need to sort out the cpu order= ing and dtsi > >> > inclusions for exynos5420, 5422 and 5800 related to DT files. > >> > > >> > See, > >> > > >> > 1) exynos5420 DT (cpu0~3: a15, cpu 4~7: a7) > >> > 2) exynos5800 DT is including exynos5420 DT > >> > 3) exynos5422 and exynos5800 based boards are including exynos58= 00 DT. > >> > > >> > Then making exynos5422-cpus DT for exynos5422 based boards? > >> > (cpu0~3: a7, cpu4~7: a15) > >> > > >> > I think, it could cause confusion when new board based on them a= re added > >> > because it's not clear and the boot cpu could be selected by boo= tloader part. > >> > >> The iROM will check the GPIO pin to select which core is run as cp= u0. > >> I think no one will change the GPIO pin if a new board which is ba= sed > >> on exynos5422 :) > >> > > Yes, I know the boot sequence and it means it depends on board conf= iguration > > not SoC. That=E2=80=99s why I'm saying it should be handled in boar= d DT file. I think, > > most of current exynos big.LITTLE model should do if it could be ch= anged > > according to board configuration. >=20 > I also agreed it's not a SoC configuration since second > patch(exynos5422.dtsi -> exynos5422-cpu.dtsi). >=20 > > > >> > > >> > So how about creating exynos5422-cpus and exynos5420-cpus then i= ncluding the > >> > cpus DT file in each board accordingly? > >> > > >> > Or more clear way to avoid confusion? > >> > >> In this situation, all exynos5422 boards(odroid xu3 series and mob= ile > >> phone) have same cpu configurations. If we move the exynos5420 cpu > >> configuration from exynos5420.dtsi, we should change all dts which > >> including exynos5420.dtsi. > > > > Maybe same board configuration. Just adding inclusion should be fin= e at this > > moment. > > > >> I think we'd better to defer the change until a new exynos5422 boa= rd > >> which has different cpu configurations is added. > >> > > I mean, according to current inclusion of exynos5422 based boards' = DT file, it > > is including exynos5420 DT via exynos5800 DT and then override diff= erent cpu > > ordering (5422-cpu DT) because of different board configuration (ju= st GPIO > > value) and it is not a good way in this case. >=20 > Actually, I don't want to disturb current dts hierarchy even though i= t > looks strange. The common features of exynos5800 and exynos5422 shoul= d > be in the exynos5800.dtsi because they shared many things except the > cpu order. > Please consider the exynos5422-cpu.dtsi is just board configurations > to represent cpu order. >=20 Yeah, strange and it can cause some confusing...but OK, we don't have m= uch choice at the moment, so applied to support it even we need some re-wor= k 'current dts hierarchy' next time. Thanks, Kukjin From mboxrd@z Thu Jan 1 00:00:00 1970 From: kgene@kernel.org (Kukjin Kim) Date: Wed, 29 Jul 2015 10:05:22 +0900 Subject: [PATCHv6] ARM: dts: add exynos5422-cpus.dtsi to correct cpu order In-Reply-To: References: <1436833441-8405-1-git-send-email-parkch98@gmail.com> <55A45C63.2030907@samsung.com> <06b101d0bdf2$8aad8fb0$a008af10$@kernel.org> <075c01d0be0e$587fe260$097fa720$@kernel.org> Message-ID: <044601d0c99a$a5218b90$ef64a2b0$@kernel.org> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Chanho Park wrote: > > Hi, > > On Tue, Jul 14, 2015 at 5:23 PM, Kukjin Kim wrote: > > Chanho Park wrote: > >> > >> Hi Kukjin, > >> > >> On Tue, Jul 14, 2015 at 2:04 PM, Kukjin Kim wrote: > >> > Krzysztof Kozlowski wrote: > >> >> > >> >> On 14.07.2015 09:24, Chanho Park wrote: > >> >> > The odroid-xu3 board which is based on exynos5422 not exynos5800 is > >> >> > booted from cortex-a7 core unlike exynos5800. The odroid-xu3's cpu order > >> >> > is quite strange. cpu0 and cpu5-7 are cortex-a7 cores and cpu1-4 are > >> >> > cortex-a15 cores. To correct this mis-odering, I added exynos5422-cpus.dtsi > >> >> > and reversing cpu orders from exynos5420. Now, cpu0-3 are cortex-a7 and > >> >> > cpu4-7 are cortex-a15. > >> >> > > >> >> > Reviewed-by: Krzysztof Kozlowski > >> >> > Signed-off-by: Chanho Park > >> >> > --- > > > > [...] > > > >> >> > > >> >> > Secondary cpu booting problem[1] is not resolved yet. Need more investigations > >> >> > to work booting 8 cores correctly. > >> >> > > >> >> > [1]: http://www.spinics.net/lists/linux-samsung-soc/msg45525.html > >> >> > > >> >> > arch/arm/boot/dts/exynos5422-cpus.dtsi | 81 ++++++++++++++++++++++ > >> >> > arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi | 1 + > >> >> > 2 files changed, 82 insertions(+) > >> >> > create mode 100644 arch/arm/boot/dts/exynos5422-cpus.dtsi > >> >> > >> >> Thanks, applied to my tree. I'll send it to Kukjin for v4.3 unless he > >> >> picks it also. > >> >> > >> > Well, let me see. I'm thinking we need to sort out the cpu ordering and dtsi > >> > inclusions for exynos5420, 5422 and 5800 related to DT files. > >> > > >> > See, > >> > > >> > 1) exynos5420 DT (cpu0~3: a15, cpu 4~7: a7) > >> > 2) exynos5800 DT is including exynos5420 DT > >> > 3) exynos5422 and exynos5800 based boards are including exynos5800 DT. > >> > > >> > Then making exynos5422-cpus DT for exynos5422 based boards? > >> > (cpu0~3: a7, cpu4~7: a15) > >> > > >> > I think, it could cause confusion when new board based on them are added > >> > because it's not clear and the boot cpu could be selected by bootloader part. > >> > >> The iROM will check the GPIO pin to select which core is run as cpu0. > >> I think no one will change the GPIO pin if a new board which is based > >> on exynos5422 :) > >> > > Yes, I know the boot sequence and it means it depends on board configuration > > not SoC. That?s why I'm saying it should be handled in board DT file. I think, > > most of current exynos big.LITTLE model should do if it could be changed > > according to board configuration. > > I also agreed it's not a SoC configuration since second > patch(exynos5422.dtsi -> exynos5422-cpu.dtsi). > > > > >> > > >> > So how about creating exynos5422-cpus and exynos5420-cpus then including the > >> > cpus DT file in each board accordingly? > >> > > >> > Or more clear way to avoid confusion? > >> > >> In this situation, all exynos5422 boards(odroid xu3 series and mobile > >> phone) have same cpu configurations. If we move the exynos5420 cpu > >> configuration from exynos5420.dtsi, we should change all dts which > >> including exynos5420.dtsi. > > > > Maybe same board configuration. Just adding inclusion should be fine at this > > moment. > > > >> I think we'd better to defer the change until a new exynos5422 board > >> which has different cpu configurations is added. > >> > > I mean, according to current inclusion of exynos5422 based boards' DT file, it > > is including exynos5420 DT via exynos5800 DT and then override different cpu > > ordering (5422-cpu DT) because of different board configuration (just GPIO > > value) and it is not a good way in this case. > > Actually, I don't want to disturb current dts hierarchy even though it > looks strange. The common features of exynos5800 and exynos5422 should > be in the exynos5800.dtsi because they shared many things except the > cpu order. > Please consider the exynos5422-cpu.dtsi is just board configurations > to represent cpu order. > Yeah, strange and it can cause some confusing...but OK, we don't have much choice at the moment, so applied to support it even we need some re-work 'current dts hierarchy' next time. Thanks, Kukjin