From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from vps0.lunn.ch (vps0.lunn.ch [156.67.10.101]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 09D5018C19; Fri, 26 Apr 2024 19:43:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=156.67.10.101 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714160635; cv=none; b=g3riy1gPEAqbOkFDDjLsxdCEJhEcjWgRHHdVzSg9ALY9I777wgMEsoaZWeVnnEOj4uEbt8Rrq75LhFJrBp8vPoWCuxcq2b00BfSSrmEtNOHoAdjgJcUZazgHtku3KYWLB6MrjQHOgqpssIGvj6pGKEg6jvTe0P+nkqb2ygk4ExU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714160635; c=relaxed/simple; bh=1m2KZnSkE8Z9rLOvusGPzukGeEbYzq7AQEGoOjvrcvg=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=T5UnbClfUb8oYoHTGxjAQI2kqS/ogeMaW8MDlCeHgxj5dCdx4D6O2YUl1CXfxrdyF9jXuFAWD5WDRqx8ZHKNx//lDgUOpwnlhTc2CfgadiVgYRAJF6dLZ868zOOsHOVfxWd3B9J1hMUKhNJsmq762uD0U9TixvNuI++uy1cwnJo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lunn.ch; spf=pass smtp.mailfrom=lunn.ch; dkim=pass (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b=09/7GHIC; arc=none smtp.client-ip=156.67.10.101 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lunn.ch Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=lunn.ch Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="09/7GHIC" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=o6y2LJ14txpTdXHbp38HomD5dRIYV/HuQPJ4h1ryQbI=; b=09/7GHICi894+Vn1EAB+6+3+A4 tQBIFsrsvyf9k1FIR7QcIBJXkc3Gz3u6pitSWD94UQiGtqeY12M2u9AbwMgslV8VAlNw/OPqqN7kg oKOVYcTEFHay4kevOmcCxx0QGPhMT4zca1Z+b3eU+R3c6MBoUicpECCv/JVukM4Ey4tc=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1s0RTy-00E6Pj-I9; Fri, 26 Apr 2024 21:43:42 +0200 Date: Fri, 26 Apr 2024 21:43:42 +0200 From: Andrew Lunn To: Josua Mayer Cc: Gregory Clement , Sebastian Hesselbarth , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Rob Herring , Yazan Shhady , "linux-arm-kernel@lists.infradead.org" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH v3 4/4] arm64: dts: add description for solidrun cn9131 solidwan board Message-ID: <053fff95-4a7d-4d00-ad38-17ffe76a4525@lunn.ch> References: <20240414-cn9130-som-v3-0-350a67d44e0a@solid-run.com> <20240414-cn9130-som-v3-4-350a67d44e0a@solid-run.com> <3958052d-fc09-4c4c-a9e3-4923871cff44@solid-run.com> <15b79794-41f4-43e0-888e-286ca1fc4321@solid-run.com> <32ec3ef4-0ecc-4ae2-bf76-c7b10f54a583@solid-run.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <32ec3ef4-0ecc-4ae2-bf76-c7b10f54a583@solid-run.com> On Fri, Apr 26, 2024 at 06:51:02PM +0000, Josua Mayer wrote: > Am 26.04.24 um 20:18 schrieb Andrew Lunn: > >>>> Colours are similar to RJ45 connectors (yellow, green), > >>>> and are intended for the same purpose: link, activity. > >>> For the switch LEDs you used label = "LED10"; Does the silk screen > >>> have similar numbers for these LEDs? > >> Correct, on CN9130 Clearfog Pro DSA switch, all LEDs are labeled > >> individually on the silk screen. > >> > >> The SolidWAN SFP leds are dual-colour leds with 3 terminals: > >> anode to 3.3V, 2x cathode to gpio-controlled transistors. > >> They are labeled on the silk-screen as "LED9", "LED10". > >> > >> Duplicate labels are not great, is there a better way? > >> old style "LED9:green" e.g. ...? > > So you have copper LEDs and SFP LEDs, each with the same silk screen > > label? Maybe put 'copper' and 'sfp' as a prefix into the label? > > No, not quite. > > We have 2x SFP Connectors. > On the bottom side of PCB immediately below each connector is > a single LED (as in physical component), each with a silk-screen label. > > "J28"/"SFP 0": "LED10" > "J42"/"SFP 1": "LED9" > > The problem is that these leds are each two leds in single-package, Ah! Sorry, you clearly said they were dual-colour. > which is why I put 4 led nodes in dts, two labeled "sfp-0", > other two "sfp-1". > But I don't think this duplication of label in dts is a good idea. Agreed. Then i would use the colour as a postfix. Andrew From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 24251C4345F for ; Fri, 26 Apr 2024 19:44:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=WJ/Ur+nhnlnRp/Zc5FSq/2ghYzDs2aXYutgTLrw1Y5o=; b=Tha4v2Xt87zrjv wbR+N3SuwogknP8lBghD9S/nnydjlqHrwNElhHkv/q+5/Jybm3n0/h0odouXznJbCRPRW2Kxw7E+P 17+I9uxTSP8wNbAAaYzU7wfcTJM7aOxefYbzIRlHhNG9gikvYGS91+qbr8Hm2b2f56qUqkf+RVl+r Jw8Y4wMEooHl0QNGGHHD+XelWAOs3vOyKK6pmUV1gkoGME6DCaPYwmGv/HXmOLpZrRvJryFDq1t+U EZGkdUYMrBmfughBpBVNYqd97NzTnP6FDeKjVnTQheJhuTJ3Yb7+qVhQID40b7CTbrcTVhKVFb7Un 57biVoEtnEWU5Y+FHRhg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1s0RUB-0000000Dq3t-1UD4; Fri, 26 Apr 2024 19:43:55 +0000 Received: from vps0.lunn.ch ([156.67.10.101]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1s0RU8-0000000Dq3I-3fgo for linux-arm-kernel@lists.infradead.org; Fri, 26 Apr 2024 19:43:54 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=o6y2LJ14txpTdXHbp38HomD5dRIYV/HuQPJ4h1ryQbI=; b=09/7GHICi894+Vn1EAB+6+3+A4 tQBIFsrsvyf9k1FIR7QcIBJXkc3Gz3u6pitSWD94UQiGtqeY12M2u9AbwMgslV8VAlNw/OPqqN7kg oKOVYcTEFHay4kevOmcCxx0QGPhMT4zca1Z+b3eU+R3c6MBoUicpECCv/JVukM4Ey4tc=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1s0RTy-00E6Pj-I9; Fri, 26 Apr 2024 21:43:42 +0200 Date: Fri, 26 Apr 2024 21:43:42 +0200 From: Andrew Lunn To: Josua Mayer Cc: Gregory Clement , Sebastian Hesselbarth , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Rob Herring , Yazan Shhady , "linux-arm-kernel@lists.infradead.org" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH v3 4/4] arm64: dts: add description for solidrun cn9131 solidwan board Message-ID: <053fff95-4a7d-4d00-ad38-17ffe76a4525@lunn.ch> References: <20240414-cn9130-som-v3-0-350a67d44e0a@solid-run.com> <20240414-cn9130-som-v3-4-350a67d44e0a@solid-run.com> <3958052d-fc09-4c4c-a9e3-4923871cff44@solid-run.com> <15b79794-41f4-43e0-888e-286ca1fc4321@solid-run.com> <32ec3ef4-0ecc-4ae2-bf76-c7b10f54a583@solid-run.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <32ec3ef4-0ecc-4ae2-bf76-c7b10f54a583@solid-run.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240426_124352_934984_FB735A27 X-CRM114-Status: GOOD ( 16.41 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Apr 26, 2024 at 06:51:02PM +0000, Josua Mayer wrote: > Am 26.04.24 um 20:18 schrieb Andrew Lunn: > >>>> Colours are similar to RJ45 connectors (yellow, green), > >>>> and are intended for the same purpose: link, activity. > >>> For the switch LEDs you used label = "LED10"; Does the silk screen > >>> have similar numbers for these LEDs? > >> Correct, on CN9130 Clearfog Pro DSA switch, all LEDs are labeled > >> individually on the silk screen. > >> > >> The SolidWAN SFP leds are dual-colour leds with 3 terminals: > >> anode to 3.3V, 2x cathode to gpio-controlled transistors. > >> They are labeled on the silk-screen as "LED9", "LED10". > >> > >> Duplicate labels are not great, is there a better way? > >> old style "LED9:green" e.g. ...? > > So you have copper LEDs and SFP LEDs, each with the same silk screen > > label? Maybe put 'copper' and 'sfp' as a prefix into the label? > > No, not quite. > > We have 2x SFP Connectors. > On the bottom side of PCB immediately below each connector is > a single LED (as in physical component), each with a silk-screen label. > > "J28"/"SFP 0": "LED10" > "J42"/"SFP 1": "LED9" > > The problem is that these leds are each two leds in single-package, Ah! Sorry, you clearly said they were dual-colour. > which is why I put 4 led nodes in dts, two labeled "sfp-0", > other two "sfp-1". > But I don't think this duplication of label in dts is a good idea. Agreed. Then i would use the colour as a postfix. Andrew _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel