* [PATCH 1/2] drm/amdkfd: Fix getting unique_id in topology
@ 2020-10-28 15:22 Kent Russell
2020-10-28 15:22 ` [PATCH 2/2] drm/amdkfd: Change unique_id to print hex format Kent Russell
2020-10-28 16:15 ` [PATCH 1/2] drm/amdkfd: Fix getting unique_id in topology Felix Kuehling
0 siblings, 2 replies; 8+ messages in thread
From: Kent Russell @ 2020-10-28 15:22 UTC (permalink / raw
To: amd-gfx; +Cc: Kent Russell
Since the unique_id is now obtained in amdgpu in smu_late_init,
topology's device addition is now happening before the unique_id is
saved, thus topology misses it. To work around this, we use the
amdgpu_amdkfd_get_unique_id to get the unique_id at read time.
Signed-off-by: Kent Russell <kent.russell@amd.com>
---
drivers/gpu/drm/amd/amdkfd/kfd_topology.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_topology.c b/drivers/gpu/drm/amd/amdkfd/kfd_topology.c
index 3f2aa055c32c..a3fc23873819 100644
--- a/drivers/gpu/drm/amd/amdkfd/kfd_topology.c
+++ b/drivers/gpu/drm/amd/amdkfd/kfd_topology.c
@@ -1340,7 +1340,7 @@ int kfd_topology_add_device(struct kfd_dev *gpu)
dev->gpu->dqm->sched_policy != KFD_SCHED_POLICY_NO_HWS) ?
amdgpu_amdkfd_get_num_gws(dev->gpu->kgd) : 0;
dev->node_props.num_cp_queues = get_cp_queues_num(dev->gpu->dqm);
- dev->node_props.unique_id = gpu->unique_id;
+ dev->node_props.unique_id = amdgpu_amdkfd_get_unique_id(dev->gpu->kgd);
kfd_fill_mem_clk_max_info(dev);
kfd_fill_iolink_non_crat_info(dev);
--
2.17.1
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH 2/2] drm/amdkfd: Change unique_id to print hex format
2020-10-28 15:22 [PATCH 1/2] drm/amdkfd: Fix getting unique_id in topology Kent Russell
@ 2020-10-28 15:22 ` Kent Russell
2020-10-28 15:54 ` Felix Kuehling
2020-10-28 16:15 ` [PATCH 1/2] drm/amdkfd: Fix getting unique_id in topology Felix Kuehling
1 sibling, 1 reply; 8+ messages in thread
From: Kent Russell @ 2020-10-28 15:22 UTC (permalink / raw
To: amd-gfx; +Cc: Kent Russell
amdgpu's unique_id prints in hex format, so change topology's printout
to hex by adding a new sysfs_print macro specifically for hex output,
and use it for unique_id
Signed-off-by: Kent Russell <kent.russell@amd.com>
---
drivers/gpu/drm/amd/amdkfd/kfd_topology.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_topology.c b/drivers/gpu/drm/amd/amdkfd/kfd_topology.c
index a3fc23873819..d13c68c52bbc 100644
--- a/drivers/gpu/drm/amd/amdkfd/kfd_topology.c
+++ b/drivers/gpu/drm/amd/amdkfd/kfd_topology.c
@@ -217,6 +217,8 @@ struct kfd_topology_device *kfd_create_topology_device(
sysfs_show_gen_prop(buffer, offs, "%s %u\n", name, value)
#define sysfs_show_64bit_prop(buffer, offs, name, value) \
sysfs_show_gen_prop(buffer, offs, "%s %llu\n", name, value)
+#define sysfs_show_64bit_prop_hex(buffer, offs, name, value) \
+ sysfs_show_gen_prop(buffer, offs, "%s %llx\n", name, value)
#define sysfs_show_32bit_val(buffer, offs, value) \
sysfs_show_gen_prop(buffer, offs, "%u\n", value)
#define sysfs_show_str_val(buffer, offs, value) \
@@ -497,7 +499,7 @@ static ssize_t node_show(struct kobject *kobj, struct attribute *attr,
dev->node_props.num_sdma_queues_per_engine);
sysfs_show_32bit_prop(buffer, offs, "num_cp_queues",
dev->node_props.num_cp_queues);
- sysfs_show_64bit_prop(buffer, offs, "unique_id",
+ sysfs_show_64bit_prop_hex(buffer, offs, "unique_id",
dev->node_props.unique_id);
if (dev->gpu) {
--
2.17.1
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH 2/2] drm/amdkfd: Change unique_id to print hex format
2020-10-28 15:22 ` [PATCH 2/2] drm/amdkfd: Change unique_id to print hex format Kent Russell
@ 2020-10-28 15:54 ` Felix Kuehling
2020-10-28 16:02 ` Russell, Kent
0 siblings, 1 reply; 8+ messages in thread
From: Felix Kuehling @ 2020-10-28 15:54 UTC (permalink / raw
To: amd-gfx, Russell, Kent
This is an ABI-breaking change. Is any user mode code using this already?
Regards,
Felix
Am 2020-10-28 um 11:22 a.m. schrieb Kent Russell:
> amdgpu's unique_id prints in hex format, so change topology's printout
> to hex by adding a new sysfs_print macro specifically for hex output,
> and use it for unique_id
>
> Signed-off-by: Kent Russell <kent.russell@amd.com>
> ---
> drivers/gpu/drm/amd/amdkfd/kfd_topology.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_topology.c b/drivers/gpu/drm/amd/amdkfd/kfd_topology.c
> index a3fc23873819..d13c68c52bbc 100644
> --- a/drivers/gpu/drm/amd/amdkfd/kfd_topology.c
> +++ b/drivers/gpu/drm/amd/amdkfd/kfd_topology.c
> @@ -217,6 +217,8 @@ struct kfd_topology_device *kfd_create_topology_device(
> sysfs_show_gen_prop(buffer, offs, "%s %u\n", name, value)
> #define sysfs_show_64bit_prop(buffer, offs, name, value) \
> sysfs_show_gen_prop(buffer, offs, "%s %llu\n", name, value)
> +#define sysfs_show_64bit_prop_hex(buffer, offs, name, value) \
> + sysfs_show_gen_prop(buffer, offs, "%s %llx\n", name, value)
> #define sysfs_show_32bit_val(buffer, offs, value) \
> sysfs_show_gen_prop(buffer, offs, "%u\n", value)
> #define sysfs_show_str_val(buffer, offs, value) \
> @@ -497,7 +499,7 @@ static ssize_t node_show(struct kobject *kobj, struct attribute *attr,
> dev->node_props.num_sdma_queues_per_engine);
> sysfs_show_32bit_prop(buffer, offs, "num_cp_queues",
> dev->node_props.num_cp_queues);
> - sysfs_show_64bit_prop(buffer, offs, "unique_id",
> + sysfs_show_64bit_prop_hex(buffer, offs, "unique_id",
> dev->node_props.unique_id);
>
> if (dev->gpu) {
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply [flat|nested] 8+ messages in thread
* RE: [PATCH 2/2] drm/amdkfd: Change unique_id to print hex format
2020-10-28 15:54 ` Felix Kuehling
@ 2020-10-28 16:02 ` Russell, Kent
2020-10-28 16:10 ` Felix Kuehling
0 siblings, 1 reply; 8+ messages in thread
From: Russell, Kent @ 2020-10-28 16:02 UTC (permalink / raw
To: Kuehling, Felix, amd-gfx@lists.freedesktop.org
[AMD Public Use]
rocminfo uses it, but that's all that I am aware of. I can drop this though and stick with patch1, I just didn't know if we'd end up getting complaints of:
"Well, rocm-smi (amdgpu) says that the unique_id is F, while rocminfo (amdkfd) says that the unique_id is 16" . Probably too late to try to change it now though, as you pointed out.
Kent
> -----Original Message-----
> From: Kuehling, Felix <Felix.Kuehling@amd.com>
> Sent: Wednesday, October 28, 2020 11:55 AM
> To: amd-gfx@lists.freedesktop.org; Russell, Kent <Kent.Russell@amd.com>
> Subject: Re: [PATCH 2/2] drm/amdkfd: Change unique_id to print hex format
>
> This is an ABI-breaking change. Is any user mode code using this already?
>
> Regards,
> Felix
>
> Am 2020-10-28 um 11:22 a.m. schrieb Kent Russell:
> > amdgpu's unique_id prints in hex format, so change topology's printout
> > to hex by adding a new sysfs_print macro specifically for hex output,
> > and use it for unique_id
> >
> > Signed-off-by: Kent Russell <kent.russell@amd.com>
> > ---
> > drivers/gpu/drm/amd/amdkfd/kfd_topology.c | 4 +++-
> > 1 file changed, 3 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_topology.c
> b/drivers/gpu/drm/amd/amdkfd/kfd_topology.c
> > index a3fc23873819..d13c68c52bbc 100644
> > --- a/drivers/gpu/drm/amd/amdkfd/kfd_topology.c
> > +++ b/drivers/gpu/drm/amd/amdkfd/kfd_topology.c
> > @@ -217,6 +217,8 @@ struct kfd_topology_device *kfd_create_topology_device(
> > sysfs_show_gen_prop(buffer, offs, "%s %u\n", name, value)
> > #define sysfs_show_64bit_prop(buffer, offs, name, value) \
> > sysfs_show_gen_prop(buffer, offs, "%s %llu\n", name, value)
> > +#define sysfs_show_64bit_prop_hex(buffer, offs, name, value) \
> > + sysfs_show_gen_prop(buffer, offs, "%s %llx\n", name, value)
> > #define sysfs_show_32bit_val(buffer, offs, value) \
> > sysfs_show_gen_prop(buffer, offs, "%u\n", value)
> > #define sysfs_show_str_val(buffer, offs, value) \
> > @@ -497,7 +499,7 @@ static ssize_t node_show(struct kobject *kobj, struct attribute
> *attr,
> > dev->node_props.num_sdma_queues_per_engine);
> > sysfs_show_32bit_prop(buffer, offs, "num_cp_queues",
> > dev->node_props.num_cp_queues);
> > - sysfs_show_64bit_prop(buffer, offs, "unique_id",
> > + sysfs_show_64bit_prop_hex(buffer, offs, "unique_id",
> > dev->node_props.unique_id);
> >
> > if (dev->gpu) {
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 2/2] drm/amdkfd: Change unique_id to print hex format
2020-10-28 16:02 ` Russell, Kent
@ 2020-10-28 16:10 ` Felix Kuehling
2020-10-28 16:21 ` Russell, Kent
0 siblings, 1 reply; 8+ messages in thread
From: Felix Kuehling @ 2020-10-28 16:10 UTC (permalink / raw
To: Russell, Kent, amd-gfx@lists.freedesktop.org
So rocm-smi reads the decimal and converts it to hex? Then changing KFD
will break rocm-smi. If you want to fix rocminfo, you'll need to fix it
in the rocminfo code to do the conversion to hex.
Regards,
Felix
Am 2020-10-28 um 12:02 p.m. schrieb Russell, Kent:
> [AMD Public Use]
>
> rocminfo uses it, but that's all that I am aware of. I can drop this though and stick with patch1, I just didn't know if we'd end up getting complaints of:
> "Well, rocm-smi (amdgpu) says that the unique_id is F, while rocminfo (amdkfd) says that the unique_id is 16" . Probably too late to try to change it now though, as you pointed out.
>
> Kent
>
>> -----Original Message-----
>> From: Kuehling, Felix <Felix.Kuehling@amd.com>
>> Sent: Wednesday, October 28, 2020 11:55 AM
>> To: amd-gfx@lists.freedesktop.org; Russell, Kent <Kent.Russell@amd.com>
>> Subject: Re: [PATCH 2/2] drm/amdkfd: Change unique_id to print hex format
>>
>> This is an ABI-breaking change. Is any user mode code using this already?
>>
>> Regards,
>> Felix
>>
>> Am 2020-10-28 um 11:22 a.m. schrieb Kent Russell:
>>> amdgpu's unique_id prints in hex format, so change topology's printout
>>> to hex by adding a new sysfs_print macro specifically for hex output,
>>> and use it for unique_id
>>>
>>> Signed-off-by: Kent Russell <kent.russell@amd.com>
>>> ---
>>> drivers/gpu/drm/amd/amdkfd/kfd_topology.c | 4 +++-
>>> 1 file changed, 3 insertions(+), 1 deletion(-)
>>>
>>> diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_topology.c
>> b/drivers/gpu/drm/amd/amdkfd/kfd_topology.c
>>> index a3fc23873819..d13c68c52bbc 100644
>>> --- a/drivers/gpu/drm/amd/amdkfd/kfd_topology.c
>>> +++ b/drivers/gpu/drm/amd/amdkfd/kfd_topology.c
>>> @@ -217,6 +217,8 @@ struct kfd_topology_device *kfd_create_topology_device(
>>> sysfs_show_gen_prop(buffer, offs, "%s %u\n", name, value)
>>> #define sysfs_show_64bit_prop(buffer, offs, name, value) \
>>> sysfs_show_gen_prop(buffer, offs, "%s %llu\n", name, value)
>>> +#define sysfs_show_64bit_prop_hex(buffer, offs, name, value) \
>>> + sysfs_show_gen_prop(buffer, offs, "%s %llx\n", name, value)
>>> #define sysfs_show_32bit_val(buffer, offs, value) \
>>> sysfs_show_gen_prop(buffer, offs, "%u\n", value)
>>> #define sysfs_show_str_val(buffer, offs, value) \
>>> @@ -497,7 +499,7 @@ static ssize_t node_show(struct kobject *kobj, struct attribute
>> *attr,
>>> dev->node_props.num_sdma_queues_per_engine);
>>> sysfs_show_32bit_prop(buffer, offs, "num_cp_queues",
>>> dev->node_props.num_cp_queues);
>>> - sysfs_show_64bit_prop(buffer, offs, "unique_id",
>>> + sysfs_show_64bit_prop_hex(buffer, offs, "unique_id",
>>> dev->node_props.unique_id);
>>>
>>> if (dev->gpu) {
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 1/2] drm/amdkfd: Fix getting unique_id in topology
2020-10-28 15:22 [PATCH 1/2] drm/amdkfd: Fix getting unique_id in topology Kent Russell
2020-10-28 15:22 ` [PATCH 2/2] drm/amdkfd: Change unique_id to print hex format Kent Russell
@ 2020-10-28 16:15 ` Felix Kuehling
2020-10-28 16:18 ` Russell, Kent
1 sibling, 1 reply; 8+ messages in thread
From: Felix Kuehling @ 2020-10-28 16:15 UTC (permalink / raw
To: Kent Russell, amd-gfx
Please also remove the broken code that initializes gpu->unique_id and
remove the unique_id field from the structure.
Regards,
Felix
Am 2020-10-28 um 11:22 a.m. schrieb Kent Russell:
> Since the unique_id is now obtained in amdgpu in smu_late_init,
> topology's device addition is now happening before the unique_id is
> saved, thus topology misses it. To work around this, we use the
> amdgpu_amdkfd_get_unique_id to get the unique_id at read time.
>
> Signed-off-by: Kent Russell <kent.russell@amd.com>
> ---
> drivers/gpu/drm/amd/amdkfd/kfd_topology.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_topology.c b/drivers/gpu/drm/amd/amdkfd/kfd_topology.c
> index 3f2aa055c32c..a3fc23873819 100644
> --- a/drivers/gpu/drm/amd/amdkfd/kfd_topology.c
> +++ b/drivers/gpu/drm/amd/amdkfd/kfd_topology.c
> @@ -1340,7 +1340,7 @@ int kfd_topology_add_device(struct kfd_dev *gpu)
> dev->gpu->dqm->sched_policy != KFD_SCHED_POLICY_NO_HWS) ?
> amdgpu_amdkfd_get_num_gws(dev->gpu->kgd) : 0;
> dev->node_props.num_cp_queues = get_cp_queues_num(dev->gpu->dqm);
> - dev->node_props.unique_id = gpu->unique_id;
> + dev->node_props.unique_id = amdgpu_amdkfd_get_unique_id(dev->gpu->kgd);
>
> kfd_fill_mem_clk_max_info(dev);
> kfd_fill_iolink_non_crat_info(dev);
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply [flat|nested] 8+ messages in thread
* RE: [PATCH 1/2] drm/amdkfd: Fix getting unique_id in topology
2020-10-28 16:15 ` [PATCH 1/2] drm/amdkfd: Fix getting unique_id in topology Felix Kuehling
@ 2020-10-28 16:18 ` Russell, Kent
0 siblings, 0 replies; 8+ messages in thread
From: Russell, Kent @ 2020-10-28 16:18 UTC (permalink / raw
To: Kuehling, Felix, amd-gfx@lists.freedesktop.org
[AMD Public Use]
Right, will do!
Kent
> -----Original Message-----
> From: Kuehling, Felix <Felix.Kuehling@amd.com>
> Sent: Wednesday, October 28, 2020 12:16 PM
> To: Russell, Kent <Kent.Russell@amd.com>; amd-gfx@lists.freedesktop.org
> Subject: Re: [PATCH 1/2] drm/amdkfd: Fix getting unique_id in topology
>
> Please also remove the broken code that initializes gpu->unique_id and
> remove the unique_id field from the structure.
>
> Regards,
> Felix
>
> Am 2020-10-28 um 11:22 a.m. schrieb Kent Russell:
> > Since the unique_id is now obtained in amdgpu in smu_late_init,
> > topology's device addition is now happening before the unique_id is
> > saved, thus topology misses it. To work around this, we use the
> > amdgpu_amdkfd_get_unique_id to get the unique_id at read time.
> >
> > Signed-off-by: Kent Russell <kent.russell@amd.com>
> > ---
> > drivers/gpu/drm/amd/amdkfd/kfd_topology.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_topology.c
> b/drivers/gpu/drm/amd/amdkfd/kfd_topology.c
> > index 3f2aa055c32c..a3fc23873819 100644
> > --- a/drivers/gpu/drm/amd/amdkfd/kfd_topology.c
> > +++ b/drivers/gpu/drm/amd/amdkfd/kfd_topology.c
> > @@ -1340,7 +1340,7 @@ int kfd_topology_add_device(struct kfd_dev *gpu)
> > dev->gpu->dqm->sched_policy != KFD_SCHED_POLICY_NO_HWS) ?
> > amdgpu_amdkfd_get_num_gws(dev->gpu->kgd) : 0;
> > dev->node_props.num_cp_queues = get_cp_queues_num(dev->gpu->dqm);
> > - dev->node_props.unique_id = gpu->unique_id;
> > + dev->node_props.unique_id = amdgpu_amdkfd_get_unique_id(dev->gpu->kgd);
> >
> > kfd_fill_mem_clk_max_info(dev);
> > kfd_fill_iolink_non_crat_info(dev);
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply [flat|nested] 8+ messages in thread
* RE: [PATCH 2/2] drm/amdkfd: Change unique_id to print hex format
2020-10-28 16:10 ` Felix Kuehling
@ 2020-10-28 16:21 ` Russell, Kent
0 siblings, 0 replies; 8+ messages in thread
From: Russell, Kent @ 2020-10-28 16:21 UTC (permalink / raw
To: Kuehling, Felix, amd-gfx@lists.freedesktop.org
[AMD Public Use]
amdgpu actually prints it as hex:
return snprintf(buf, PAGE_SIZE, "%016llx\n", adev->unique_id);
But either way, we can address it in rocminfo if anyone complains. Thanks for the review!
Kent
> -----Original Message-----
> From: Kuehling, Felix <Felix.Kuehling@amd.com>
> Sent: Wednesday, October 28, 2020 12:11 PM
> To: Russell, Kent <Kent.Russell@amd.com>; amd-gfx@lists.freedesktop.org
> Subject: Re: [PATCH 2/2] drm/amdkfd: Change unique_id to print hex format
>
> So rocm-smi reads the decimal and converts it to hex? Then changing KFD
> will break rocm-smi. If you want to fix rocminfo, you'll need to fix it
> in the rocminfo code to do the conversion to hex.
>
> Regards,
> Felix
>
> Am 2020-10-28 um 12:02 p.m. schrieb Russell, Kent:
> > [AMD Public Use]
> >
> > rocminfo uses it, but that's all that I am aware of. I can drop this though and stick with
> patch1, I just didn't know if we'd end up getting complaints of:
> > "Well, rocm-smi (amdgpu) says that the unique_id is F, while rocminfo (amdkfd) says that
> the unique_id is 16" . Probably too late to try to change it now though, as you pointed out.
> >
> > Kent
> >
> >> -----Original Message-----
> >> From: Kuehling, Felix <Felix.Kuehling@amd.com>
> >> Sent: Wednesday, October 28, 2020 11:55 AM
> >> To: amd-gfx@lists.freedesktop.org; Russell, Kent <Kent.Russell@amd.com>
> >> Subject: Re: [PATCH 2/2] drm/amdkfd: Change unique_id to print hex format
> >>
> >> This is an ABI-breaking change. Is any user mode code using this already?
> >>
> >> Regards,
> >> Felix
> >>
> >> Am 2020-10-28 um 11:22 a.m. schrieb Kent Russell:
> >>> amdgpu's unique_id prints in hex format, so change topology's printout
> >>> to hex by adding a new sysfs_print macro specifically for hex output,
> >>> and use it for unique_id
> >>>
> >>> Signed-off-by: Kent Russell <kent.russell@amd.com>
> >>> ---
> >>> drivers/gpu/drm/amd/amdkfd/kfd_topology.c | 4 +++-
> >>> 1 file changed, 3 insertions(+), 1 deletion(-)
> >>>
> >>> diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_topology.c
> >> b/drivers/gpu/drm/amd/amdkfd/kfd_topology.c
> >>> index a3fc23873819..d13c68c52bbc 100644
> >>> --- a/drivers/gpu/drm/amd/amdkfd/kfd_topology.c
> >>> +++ b/drivers/gpu/drm/amd/amdkfd/kfd_topology.c
> >>> @@ -217,6 +217,8 @@ struct kfd_topology_device *kfd_create_topology_device(
> >>> sysfs_show_gen_prop(buffer, offs, "%s %u\n", name, value)
> >>> #define sysfs_show_64bit_prop(buffer, offs, name, value) \
> >>> sysfs_show_gen_prop(buffer, offs, "%s %llu\n", name, value)
> >>> +#define sysfs_show_64bit_prop_hex(buffer, offs, name, value) \
> >>> + sysfs_show_gen_prop(buffer, offs, "%s %llx\n", name, value)
> >>> #define sysfs_show_32bit_val(buffer, offs, value) \
> >>> sysfs_show_gen_prop(buffer, offs, "%u\n", value)
> >>> #define sysfs_show_str_val(buffer, offs, value) \
> >>> @@ -497,7 +499,7 @@ static ssize_t node_show(struct kobject *kobj, struct attribute
> >> *attr,
> >>> dev->node_props.num_sdma_queues_per_engine);
> >>> sysfs_show_32bit_prop(buffer, offs, "num_cp_queues",
> >>> dev->node_props.num_cp_queues);
> >>> - sysfs_show_64bit_prop(buffer, offs, "unique_id",
> >>> + sysfs_show_64bit_prop_hex(buffer, offs, "unique_id",
> >>> dev->node_props.unique_id);
> >>>
> >>> if (dev->gpu) {
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2020-10-28 16:21 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-10-28 15:22 [PATCH 1/2] drm/amdkfd: Fix getting unique_id in topology Kent Russell
2020-10-28 15:22 ` [PATCH 2/2] drm/amdkfd: Change unique_id to print hex format Kent Russell
2020-10-28 15:54 ` Felix Kuehling
2020-10-28 16:02 ` Russell, Kent
2020-10-28 16:10 ` Felix Kuehling
2020-10-28 16:21 ` Russell, Kent
2020-10-28 16:15 ` [PATCH 1/2] drm/amdkfd: Fix getting unique_id in topology Felix Kuehling
2020-10-28 16:18 ` Russell, Kent
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.