* [PATCH bluetooth-next] at86rf230: remove hrtimer on 1 usec delay
@ 2015-07-30 10:13 Alexander Aring
2015-07-30 12:02 ` Marcel Holtmann
0 siblings, 1 reply; 2+ messages in thread
From: Alexander Aring @ 2015-07-30 10:13 UTC (permalink / raw
To: linux-wpan; +Cc: kernel, Alexander Aring
According Documentation/timers/timers-howto.txt the usually case for
setting up a hrtimer takes > ~10us. So we should use udelay in this
case so we are sure that the state change was done, before doing the
state change assert.
Signed-off-by: Alexander Aring <alex.aring@gmail.com>
---
drivers/net/ieee802154/at86rf230.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/net/ieee802154/at86rf230.c b/drivers/net/ieee802154/at86rf230.c
index f7bd9f3..d0d5bf6 100644
--- a/drivers/net/ieee802154/at86rf230.c
+++ b/drivers/net/ieee802154/at86rf230.c
@@ -545,7 +545,9 @@ at86rf230_async_state_delay(void *context)
}
/* Default delay is 1us in the most cases */
- tim = ktime_set(0, NSEC_PER_USEC);
+ udelay(1);
+ at86rf230_async_state_timer(&ctx->timer);
+ return;
change:
hrtimer_start(&ctx->timer, tim, HRTIMER_MODE_REL);
--
2.5.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH bluetooth-next] at86rf230: remove hrtimer on 1 usec delay
2015-07-30 10:13 [PATCH bluetooth-next] at86rf230: remove hrtimer on 1 usec delay Alexander Aring
@ 2015-07-30 12:02 ` Marcel Holtmann
0 siblings, 0 replies; 2+ messages in thread
From: Marcel Holtmann @ 2015-07-30 12:02 UTC (permalink / raw
To: Alexander Aring; +Cc: linux-wpan, kernel
Hi Alex,
> According Documentation/timers/timers-howto.txt the usually case for
> setting up a hrtimer takes > ~10us. So we should use udelay in this
> case so we are sure that the state change was done, before doing the
> state change assert.
>
> Signed-off-by: Alexander Aring <alex.aring@gmail.com>
> ---
> drivers/net/ieee802154/at86rf230.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
patch has been applied to bluetooth-next tree.
Regards
Marcel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-07-30 12:03 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-07-30 10:13 [PATCH bluetooth-next] at86rf230: remove hrtimer on 1 usec delay Alexander Aring
2015-07-30 12:02 ` Marcel Holtmann
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.