From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 00231C468C6 for ; Wed, 12 May 2021 17:02:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E17F261408 for ; Wed, 12 May 2021 17:02:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344467AbhELRBx (ORCPT ); Wed, 12 May 2021 13:01:53 -0400 Received: from mga11.intel.com ([192.55.52.93]:17410 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238059AbhELP5O (ORCPT ); Wed, 12 May 2021 11:57:14 -0400 IronPort-SDR: 7+Axw4a2GdTdJZYGr5p+xK+EevTTfQcb2LyJ34mdjWtG82rszEa9lKmLiCK/oMKVeRgKQvmVdi Hmv7vfvJGpeA== X-IronPort-AV: E=McAfee;i="6200,9189,9982"; a="196646154" X-IronPort-AV: E=Sophos;i="5.82,293,1613462400"; d="scan'208";a="196646154" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 May 2021 08:56:05 -0700 IronPort-SDR: UWeTj3jQdhWF1YEWQNpBm0lw4wCt6SSJLjjdVbtjgKaH+1h5T0zsfunZVjXASgzqZfYXdSAkpD 6nq/IoMY81KA== X-IronPort-AV: E=Sophos;i="5.82,293,1613462400"; d="scan'208";a="392799988" Received: from rchatre-mobl3.amr.corp.intel.com (HELO [10.251.0.238]) ([10.251.0.238]) by orsmga006-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 May 2021 08:56:04 -0700 Subject: Re: [PATCH v4 2/2] selftests/sgx: Migrate to kselftest harness To: Jarkko Sakkinen Cc: Shuah Khan , linux-sgx@vger.kernel.org, Dave Hansen , linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org References: <20210508035648.18176-1-jarkko@kernel.org> <20210508035648.18176-2-jarkko@kernel.org> <960f1cd8-d805-8ed8-6af0-eed1f49e3c65@intel.com> From: Reinette Chatre Message-ID: <0b68cf8e-994d-3c85-cb93-5701722d9336@intel.com> Date: Wed, 12 May 2021 08:56:03 -0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Jarkko, On 5/11/2021 6:10 PM, Jarkko Sakkinen wrote: > On Tue, May 11, 2021 at 11:42:49AM -0700, Reinette Chatre wrote: >> Hi Jarkko, >> >> On 5/7/2021 8:56 PM, Jarkko Sakkinen wrote: >>> Migrate to kselftest harness. Use a fixture test with enclave initialized >>> and de-initialized for each of the existing three tests, in other words: >>> >>> 1. One FIXTURE() for managing the enclave life-cycle. >>> 2. Three TEST_F()'s, one for each test case. >> >> These changes make it easier to add tests and I think it is a valuable >> addition. >> >>> >>> This gives a leaps better reporting than before. Here's an example >>> transcript: >>> >>> TAP version 13 >>> 1..3 >>> 0x0000000000000000 0x0000000000002000 0x03 >>> 0x0000000000002000 0x0000000000001000 0x05 >>> 0x0000000000003000 0x0000000000003000 0x03 >>> ok 1 enclave.unclobbered_vdso >>> 0x0000000000000000 0x0000000000002000 0x03 >>> 0x0000000000002000 0x0000000000001000 0x05 >>> 0x0000000000003000 0x0000000000003000 0x03 >>> ok 2 enclave.clobbered_vdso >>> 0x0000000000000000 0x0000000000002000 0x03 >>> 0x0000000000002000 0x0000000000001000 0x05 >>> 0x0000000000003000 0x0000000000003000 0x03 >>> ok 3 enclave.clobbered_vdso_and_user_function >>> >> >> The output claims to conform to TAP13 but it does not seem as though all of >> the output conforms to TAP13. I assume such output would confuse automated >> systems. > > You mean > > 0x0000000000000000 0x0000000000002000 0x03 > 0x0000000000002000 0x0000000000001000 0x05 > 0x0000000000003000 0x0000000000003000 0x03 > > ? Yes Reinette