From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756195AbbGQF20 (ORCPT ); Fri, 17 Jul 2015 01:28:26 -0400 Received: from mout.kundenserver.de ([212.227.126.187]:58042 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753415AbbGQF2Z (ORCPT ); Fri, 17 Jul 2015 01:28:25 -0400 Date: Fri, 17 Jul 2015 07:28:19 +0200 (CEST) From: Stefan Wahren Reply-To: Stefan Wahren To: Viresh Kumar Cc: linux-kernel@vger.kernel.org, Shawn Guo , linux-arm-kernel@lists.infradead.org, linaro-kernel@lists.linaro.org, Thomas Gleixner , Daniel Lezcano , Fabio Estevam , Marek Vasut , Sascha Hauer Message-ID: <1002917180.81547.1437110899188.JavaMail.open-xchange@oxbsltgw05.schlund.de> In-Reply-To: <5505013f2020eef13aa55f7d748f79e344ce6c69.1434622147.git.viresh.kumar@linaro.org> References: <5505013f2020eef13aa55f7d748f79e344ce6c69.1434622147.git.viresh.kumar@linaro.org> Subject: Re: [PATCH 14/41] clocksource: mxs: Migrate to new 'set-state' interface MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Priority: 3 Importance: Medium X-Mailer: Open-Xchange Mailer v7.6.2-Rev24 X-Originating-Client: com.openexchange.ox.gui.dhtml X-Provags-ID: V03:K0:fuiTUAEesOnZqLEucwU6g+5lc/B5FHew3otJh2r8wX6R3gechlQ DHU8tIpwumw0EJimnyyRC8JOn7h6L2RACUj1N4BJDrFcRSx15NTaDQFwZfyFiW+052LtLem arotx5omKAsTajoKH7EjNEaJeyEyK9UJ3uB44XS75LAR8vL+ZDVv0gq9k0GFE+Y0ygUZB6X VGde+KwxAz1mqN8cnxULg== X-UI-Out-Filterresults: notjunk:1;V01:K0:VSmeI7WxOos=:WS1Vg7unErgqkRW7VebF+2 0I4VAY8bNmMEZgVwq8uFv+ZYEf5fOb6F22CMtDH58x9VO79z27zWCRRsglqMTNHs6+vZRqUPK pp7eZxgCUNfVAlQ0JnvhFEk5ODMn3w549uPiLzefVDqewatusmR3VL8J98fwVfVVgItWxdjxn kwX0saaQzEYF4N/GlG9Vsu30wXTHG6J0pzJX8FxrsoA5cZmILQwDIbfUvhR7roZJix9Psvshm djwSru14Xvcx7ltvAsMP45XFZ6SIl0Uyz/z5KjKWMflPHfaQge7kihfxPr2mpnHfTG0dQU15Q ugUj1pLc7SdfTQ4Ip2GrpiaF2ehxp5UG+6xFaK0sfHn/ezjg6rl6YJZn+z1oyKIPgKcAOHAr+ Es0et5VHKrS5ga0td32h+itXWk99GNhW0PrGNAGPfyu8jRuobKXa66Gbubb+2Sr6QfVtz0Vog luaYYgv/YK+lTPkImz4uAzMBo8PzZ3rNaUfMFvWLczG8tXhmocMeyzxsO2o25r506wltZK0YH 0eShRo+t5667wPozxiurnATP7gN3x2aCOIFRxP7auceuxRPctWjynoZBLsi3aDLj+Vlf55Ytq At23XSqc3AMhVjWMec2Cc6SPJSXTsqpq/oFPigOapgQjLuq6fEiDRf5EBfEhyorBSWPL6j/Hh n/wsKn+vWQxo5aq72MxcpMSKhn+g9hUuoQ0ZlKcSVf9VZtA== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Viresh, [add Fabio, Marek and Pengutronix to CC] > Viresh Kumar hat am 18. Juni 2015 um 12:54 > geschrieben: > > > Migrate mxs driver to the new 'set-state' interface provided by > clockevents core, the earlier 'set-mode' interface is marked obsolete > now. > > This also enables us to implement callbacks for new states of clockevent > devices, for example: ONESHOT_STOPPED. > > Also drop: > - 'mxs_clockevent_mode': as we have helpers available from core for the > same. > same state twice and so perhaps the check wasn't required. > - 'clock_event_mode_label': CLOCK_EVT_MODE_* shouldn't be used anymore > by drivers and it was used just to print old-state:new-state. The > debug prints are called from mxs_irq_clear() now based on the > state-name passed to it. The printed name will be same for shutdown > and resume states as they use the same callback pointer. > > Cc: Shawn Guo > Signed-off-by: Viresh Kumar > > --- > @Shawn: Please let me know if you want to print "resume" for resume > state, as that will require a separate callback for resume state, just > to print the name correctly. I thought it might not be worth enough :) > --- sorry for the late feedback. I've tested the patch with an i.MX23 and an i.MX28 board without any problems. Tested-by: Stefan Wahren Regards Stefan From mboxrd@z Thu Jan 1 00:00:00 1970 From: stefan.wahren@i2se.com (Stefan Wahren) Date: Fri, 17 Jul 2015 07:28:19 +0200 (CEST) Subject: [PATCH 14/41] clocksource: mxs: Migrate to new 'set-state' interface In-Reply-To: <5505013f2020eef13aa55f7d748f79e344ce6c69.1434622147.git.viresh.kumar@linaro.org> References: <5505013f2020eef13aa55f7d748f79e344ce6c69.1434622147.git.viresh.kumar@linaro.org> Message-ID: <1002917180.81547.1437110899188.JavaMail.open-xchange@oxbsltgw05.schlund.de> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Viresh, [add Fabio, Marek and Pengutronix to CC] > Viresh Kumar hat am 18. Juni 2015 um 12:54 > geschrieben: > > > Migrate mxs driver to the new 'set-state' interface provided by > clockevents core, the earlier 'set-mode' interface is marked obsolete > now. > > This also enables us to implement callbacks for new states of clockevent > devices, for example: ONESHOT_STOPPED. > > Also drop: > - 'mxs_clockevent_mode': as we have helpers available from core for the > same. > same state twice and so perhaps the check wasn't required. > - 'clock_event_mode_label': CLOCK_EVT_MODE_* shouldn't be used anymore > by drivers and it was used just to print old-state:new-state. The > debug prints are called from mxs_irq_clear() now based on the > state-name passed to it. The printed name will be same for shutdown > and resume states as they use the same callback pointer. > > Cc: Shawn Guo > Signed-off-by: Viresh Kumar > > --- > @Shawn: Please let me know if you want to print "resume" for resume > state, as that will require a separate callback for resume state, just > to print the name correctly. I thought it might not be worth enough :) > --- sorry for the late feedback. I've tested the patch with an i.MX23 and an i.MX28 board without any problems. Tested-by: Stefan Wahren Regards Stefan