From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH v16 0/6] User-space Ethtool Date: Wed, 15 Jul 2015 07:53:05 +0200 Message-ID: <10500550.BxuzPEpZpz@xps13> References: <1432946276-9424-1-git-send-email-liang-min.wang@intel.com> <3613205.a925kSz8Fg@xps13> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org To: "Wang, Liang-min" Return-path: Received: from mail-wg0-f43.google.com (mail-wg0-f43.google.com [74.125.82.43]) by dpdk.org (Postfix) with ESMTP id E33AE376D for ; Wed, 15 Jul 2015 08:19:30 +0200 (CEST) Received: by wgkl9 with SMTP id l9so24701449wgk.1 for ; Tue, 14 Jul 2015 23:19:30 -0700 (PDT) In-Reply-To: List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 2015-07-14 20:56, Wang, Liang-min: > Thomas, > The mac_addr_set is needed for ethtool net-op as described in > examples/ethtool-ethtool/lib/rte_ethtool.c (rte_ethtool_net_set/get_mac_addr). That's why it should be the first patch of this series. You probably misread "another patch" which means different patch in same series. > Could you use the v15 for the release? No, there are more comments. > > -----Original Message----- > > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > > Sent: Tuesday, July 14, 2015 4:14 PM > > To: Wang, Liang-min > > Cc: dev@dpdk.org > > Subject: Re: [dpdk-dev] [PATCH v16 0/6] User-space Ethtool > > > > 2015-07-14 09:11, Liang-Min Larry Wang: > > > v16 changes: > > > - Re-do patch v15 and separate changes between v15 and v14 into patch > > files 005 and 006 > > > > No, you misunderstood the need. > > You must merge your fixes in appropriate patches. > > But you must separate the mac_addr_set feature in another patch as it is > > not related to ethtool dumps. > > > > You are winning the record of patch iterations :)