From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas.monjalon@6wind.com>
Subject: Re: [PATCH v17 5/5] examples: new example: l2fwd-ethtool
Date: Thu, 16 Jul 2015 23:25:05 +0200
Message-ID: <12190549.MS8Ux4Gd0m@xps13>
References: <1432946276-9424-1-git-send-email-liang-min.wang@intel.com>
 <1437053137-10460-1-git-send-email-liang-min.wang@intel.com>
 <1437053137-10460-6-git-send-email-liang-min.wang@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org
To: Liang-Min Larry Wang <liang-min.wang@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wg0-f49.google.com (mail-wg0-f49.google.com [74.125.82.49])
 by dpdk.org (Postfix) with ESMTP id 6EDA35A6C
 for <dev@dpdk.org>; Thu, 16 Jul 2015 23:26:18 +0200 (CEST)
Received: by wgxm20 with SMTP id m20so68188397wgx.3
 for <dev@dpdk.org>; Thu, 16 Jul 2015 14:26:18 -0700 (PDT)
In-Reply-To: <1437053137-10460-6-git-send-email-liang-min.wang@intel.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

2015-07-16 09:25, Liang-Min Larry Wang:
> The example includes an ethtool library and two applications:
> one application is a non- DPDK process (nic-control)
> and the other is a DPDK l2fwd applicaiton (l2fwd-app).
> The nic-control process sends ethtool alike device management
> requests to l2fwd-app through a named pipe IPC. This example
> is designed to show how to build a ethtool shim library and
> how to use ethtool apis to manage device parameters.

The makefiles need some clean-up and it does not build in shared lib mode.

Beginning of a cleanup patch to merge with this one:

--- a/examples/Makefile
+++ b/examples/Makefile
@@ -50,12 +50,10 @@ DIRS-y += ip_reassembly
 DIRS-$(CONFIG_RTE_IP_FRAG) += ip_fragmentation
 DIRS-y += ipv4_multicast
 DIRS-$(CONFIG_RTE_LIBRTE_KNI) += kni
-DIRS-y += l2fwd-ethtool/lib
-DIRS-y += l2fwd-ethtool/nic-control
-DIRS-y += l2fwd-ethtool/l2fwd-app
 DIRS-y += l2fwd
 DIRS-$(CONFIG_RTE_LIBRTE_IVSHMEM) += l2fwd-ivshmem
 DIRS-$(CONFIG_RTE_LIBRTE_JOBSTATS) += l2fwd-jobstats
+DIRS-$(CONFIG_RTE_EXEC_ENV_LINUXAPP) += l2fwd-ethtool
 DIRS-y += l3fwd
 DIRS-$(CONFIG_RTE_LIBRTE_ACL) += l3fwd-acl
 DIRS-$(CONFIG_RTE_LIBRTE_POWER) += l3fwd-power

--- a/examples/l2fwd-ethtool/Makefile
+++ b/examples/l2fwd-ethtool/Makefile
@@ -37,7 +37,6 @@ endif
 RTE_TARGET ?= x86_64-native-linuxapp-gcc
 
 include $(RTE_SDK)/mk/rte.vars.mk
-unexport RTE_SRCDIR RTE_OUTPUT RTE_EXTMK
 
 ifneq ($(CONFIG_RTE_EXEC_ENV),"linuxapp")
 $(error This application can only operate in a linuxapp environment, \
@@ -46,10 +45,4 @@ endif
 
 DIRS-y += lib nic-control l2fwd-app
 
-.PHONY: all clean $(DIRS-y)
-
-all: $(DIRS-y)
-clean: $(DIRS-y)
-
-$(DIRS-y):
-       $(MAKE) -C $@ $(MAKECMDGOALS) O=$(RTE_OUTPUT)
+include $(RTE_SDK)/mk/rte.extsubdir.mk