All the mail mirrored from lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH net-next] rtnetlink: Fix inverted check in ndo_dflt_fdb_del()
@ 2013-08-08 22:19 Sridhar Samudrala
  2013-08-10  8:24 ` David Miller
  0 siblings, 1 reply; 2+ messages in thread
From: Sridhar Samudrala @ 2013-08-08 22:19 UTC (permalink / raw
  To: davem; +Cc: netdev

Fix inverted check when deleting an fdb entry.

Signed-off-by: Sridhar Samudrala <sri@us.ibm.com>
---
diff --git a/net/core/rtnetlink.c b/net/core/rtnetlink.c
index 0b2972c..618dbe4 100644
--- a/net/core/rtnetlink.c
+++ b/net/core/rtnetlink.c
@@ -2179,7 +2179,7 @@ int ndo_dflt_fdb_del(struct ndmsg *ndm,
 	/* If aging addresses are supported device will need to
 	 * implement its own handler for this.
 	 */
-	if (ndm->ndm_state & NUD_PERMANENT) {
+	if (!(ndm->ndm_state & NUD_PERMANENT)) {
 		pr_info("%s: FDB only supports static addresses\n", dev->name);
 		return -EINVAL;
 	}

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH net-next] rtnetlink: Fix inverted check in ndo_dflt_fdb_del()
  2013-08-08 22:19 [PATCH net-next] rtnetlink: Fix inverted check in ndo_dflt_fdb_del() Sridhar Samudrala
@ 2013-08-10  8:24 ` David Miller
  0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2013-08-10  8:24 UTC (permalink / raw
  To: sri; +Cc: netdev

From: Sridhar Samudrala <sri@us.ibm.com>
Date: Thu, 08 Aug 2013 15:19:48 -0700

> Fix inverted check when deleting an fdb entry.
> 
> Signed-off-by: Sridhar Samudrala <sri@us.ibm.com>

This fixes a bug that has been around for a release or two, so I've
applied it to 'net'.

Thanks.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2013-08-10  8:24 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-08-08 22:19 [PATCH net-next] rtnetlink: Fix inverted check in ndo_dflt_fdb_del() Sridhar Samudrala
2013-08-10  8:24 ` David Miller

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.