All the mail mirrored from lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH v2 2/2] libglib2: the system PCRE needs to have UTF and UCP enabled
@ 2013-11-22 21:58 Sven Neumann
  2013-11-22 22:33 ` Peter Korsgaard
  0 siblings, 1 reply; 6+ messages in thread
From: Sven Neumann @ 2013-11-22 21:58 UTC (permalink / raw
  To: buildroot


If glib2 is compiled with the system PCRE instead of the included
copy, then that system PCRE needs to have support for UTF-8 and
Unicode properties enabled. Otherwise you will get such warnings
at run-time:

GLib-CRITICAL **: PCRE library is compiled without UTF8 support
GLib-CRITICAL **: PCRE library is compiled without UTF8 properties support

Signed-off-by: Sven Neumann <neumann@teufel.de>
---
 package/libglib2/Config.in | 1 +
 1 file changed, 1 insertion(+)

diff --git a/package/libglib2/Config.in b/package/libglib2/Config.in
index db6a950..7cbfea5 100644
--- a/package/libglib2/Config.in
+++ b/package/libglib2/Config.in
@@ -3,6 +3,7 @@ config BR2_PACKAGE_LIBGLIB2
 	select BR2_PACKAGE_GETTEXT if BR2_NEEDS_GETTEXT
 	select BR2_PACKAGE_LIBICONV if !BR2_ENABLE_LOCALE
 	select BR2_PACKAGE_LIBFFI
+	select BR2_PACKAGE_PCRE_UCP if BR2_PACKAGE_PCRE
 	select BR2_PACKAGE_ZLIB
 	depends on BR2_USE_WCHAR # gettext
 	depends on BR2_TOOLCHAIN_HAS_THREADS
-- 
1.8.4.2

^ permalink raw reply related	[flat|nested] 6+ messages in thread

* [Buildroot] [PATCH v2 2/2] libglib2: the system PCRE needs to have UTF and UCP enabled
  2013-11-22 21:58 [Buildroot] [PATCH v2 2/2] libglib2: the system PCRE needs to have UTF and UCP enabled Sven Neumann
@ 2013-11-22 22:33 ` Peter Korsgaard
  2013-11-25  7:49   ` Sven Neumann
  0 siblings, 1 reply; 6+ messages in thread
From: Peter Korsgaard @ 2013-11-22 22:33 UTC (permalink / raw
  To: buildroot

>>>>> "Sven" == Sven Neumann <neumann@teufel.de> writes:

 > If glib2 is compiled with the system PCRE instead of the included
 > copy, then that system PCRE needs to have support for UTF-8 and
 > Unicode properties enabled. Otherwise you will get such warnings
 > at run-time:

 > GLib-CRITICAL **: PCRE library is compiled without UTF8 support
 > GLib-CRITICAL **: PCRE library is compiled without UTF8 properties support

 > Signed-off-by: Sven Neumann <neumann@teufel.de>

Committed to next, thanks.

-- 
Bye, Peter Korsgaard

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [Buildroot] [PATCH v2 2/2] libglib2: the system PCRE needs to have UTF and UCP enabled
  2013-11-22 22:33 ` Peter Korsgaard
@ 2013-11-25  7:49   ` Sven Neumann
  2013-11-25  9:17     ` Peter Korsgaard
  0 siblings, 1 reply; 6+ messages in thread
From: Sven Neumann @ 2013-11-25  7:49 UTC (permalink / raw
  To: buildroot

Hello,

On Fr, 2013-11-22 at 23:33 +0100, Peter Korsgaard wrote:
> >>>>> "Sven" == Sven Neumann <neumann@teufel.de> writes:
> 
>  > If glib2 is compiled with the system PCRE instead of the included
>  > copy, then that system PCRE needs to have support for UTF-8 and
>  > Unicode properties enabled. Otherwise you will get such warnings
>  > at run-time:
> 
>  > GLib-CRITICAL **: PCRE library is compiled without UTF8 support
>  > GLib-CRITICAL **: PCRE library is compiled without UTF8 properties support
> 
>  > Signed-off-by: Sven Neumann <neumann@teufel.de>
> 
> Committed to next, thanks.

May I suggest that you also merge this to the stable tree. Otherwise
glib2 will be unusable on any system that also has pcre selected (which
is for example pulled in by gnutls).


Regards,
Sven

-- 
Sven Neumann
Senior System Architect

Lautsprecher Teufel GmbH
Gewerbehof B?lowbogen - Aufgang D1
B?lowstr. 66 - 10783 Berlin - Germany

Registernummer HRB 20271 beim Amtsgericht Berlin-Charlottenburg
Gesch?ftsf?hrer: Edgar van Velzen

Tel. +49 (0)30 - 300 930 - 0, Direkt -153
neumann at teufel.de  

www.teufel.de  www.teufelaudio.com  http://blog.teufel.de

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [Buildroot] [PATCH v2 2/2] libglib2: the system PCRE needs to have UTF and UCP enabled
  2013-11-25  7:49   ` Sven Neumann
@ 2013-11-25  9:17     ` Peter Korsgaard
  2013-11-25  9:54       ` Sven Neumann
  0 siblings, 1 reply; 6+ messages in thread
From: Peter Korsgaard @ 2013-11-25  9:17 UTC (permalink / raw
  To: buildroot

>>>>> "Sven" == Sven Neumann <neumann@teufel.de> writes:

 > Hello,
 > On Fr, 2013-11-22 at 23:33 +0100, Peter Korsgaard wrote:
 >> >>>>> "Sven" == Sven Neumann <neumann@teufel.de> writes:
 >> 
 >> > If glib2 is compiled with the system PCRE instead of the included
 >> > copy, then that system PCRE needs to have support for UTF-8 and
 >> > Unicode properties enabled. Otherwise you will get such warnings
 >> > at run-time:
 >> 
 >> > GLib-CRITICAL **: PCRE library is compiled without UTF8 support
 >> > GLib-CRITICAL **: PCRE library is compiled without UTF8 properties support
 >> 
 >> > Signed-off-by: Sven Neumann <neumann@teufel.de>
 >> 
 >> Committed to next, thanks.

 > May I suggest that you also merge this to the stable tree. Otherwise
 > glib2 will be unusable on any system that also has pcre selected (which
 > is for example pulled in by gnutls).

Hmm, ok - That wasn't completely clear to me. So even though it's just a
warning, this is something critical?

When was this introduced? By the 2.36.1 -> 2.36.3 bump or is 2013.08
also affected?

For the future, it is nice if patches that should go to the current
release are clearly marked as such.

-- 
Bye, Peter Korsgaard

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [Buildroot] [PATCH v2 2/2] libglib2: the system PCRE needs to have UTF and UCP enabled
  2013-11-25  9:17     ` Peter Korsgaard
@ 2013-11-25  9:54       ` Sven Neumann
  2013-11-25 10:04         ` Peter Korsgaard
  0 siblings, 1 reply; 6+ messages in thread
From: Sven Neumann @ 2013-11-25  9:54 UTC (permalink / raw
  To: buildroot

Hi Peter,

On Mo, 2013-11-25 at 10:17 +0100, Peter Korsgaard wrote:
> >>>>> "Sven" == Sven Neumann <neumann@teufel.de> writes:
> 
>  > Hello,
>  > On Fr, 2013-11-22 at 23:33 +0100, Peter Korsgaard wrote:
>  >> >>>>> "Sven" == Sven Neumann <neumann@teufel.de> writes:
>  >> 
>  >> > If glib2 is compiled with the system PCRE instead of the included
>  >> > copy, then that system PCRE needs to have support for UTF-8 and
>  >> > Unicode properties enabled. Otherwise you will get such warnings
>  >> > at run-time:
>  >> 
>  >> > GLib-CRITICAL **: PCRE library is compiled without UTF8 support
>  >> > GLib-CRITICAL **: PCRE library is compiled without UTF8 properties support
>  >> 
>  >> > Signed-off-by: Sven Neumann <neumann@teufel.de>
>  >> 
>  >> Committed to next, thanks.
> 
>  > May I suggest that you also merge this to the stable tree. Otherwise
>  > glib2 will be unusable on any system that also has pcre selected (which
>  > is for example pulled in by gnutls).
> 
> Hmm, ok - That wasn't completely clear to me. So even though it's just a
> warning, this is something critical?

Any functionality that use GRegex won't work if the system PCRE is not
compiled with UTF-8 and UCP support. There might be glib-based
applications that won't be affected by this, but there is a good chance
that people will run into unexpected problems because of this.

> When was this introduced? By the 2.36.1 -> 2.36.3 bump or is 2013.08
> also affected?

As far as I can see this was introduced with commit fe192908a4e:

 commit fe192908a4e3195b6f724310fe83fadaf18b66e7
 Author: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
 Date:   Sat Mar 9 08:21:30 2013 +0000

    libglib2: use system pcre when available


Regards,
Sven

-- 
Sven Neumann
Senior System Architect

Lautsprecher Teufel GmbH
Gewerbehof B?lowbogen - Aufgang D1
B?lowstr. 66 - 10783 Berlin - Germany

Registernummer HRB 20271 beim Amtsgericht Berlin-Charlottenburg
Gesch?ftsf?hrer: Edgar van Velzen

Tel. +49 (0)30 - 300 930 - 0, Direkt -153
neumann at teufel.de  

www.teufel.de  www.teufelaudio.com  http://blog.teufel.de

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [Buildroot] [PATCH v2 2/2] libglib2: the system PCRE needs to have UTF and UCP enabled
  2013-11-25  9:54       ` Sven Neumann
@ 2013-11-25 10:04         ` Peter Korsgaard
  0 siblings, 0 replies; 6+ messages in thread
From: Peter Korsgaard @ 2013-11-25 10:04 UTC (permalink / raw
  To: buildroot

>>>>> "Sven" == Sven Neumann <neumann@teufel.de> writes:

Hi,

 >> Hmm, ok - That wasn't completely clear to me. So even though it's
 >> just a warning, this is something critical?

 > Any functionality that use GRegex won't work if the system PCRE is not
 > compiled with UTF-8 and UCP support. There might be glib-based
 > applications that won't be affected by this, but there is a good chance
 > that people will run into unexpected problems because of this.

Ok, thanks for the details.


 >> When was this introduced? By the 2.36.1 -> 2.36.3 bump or is 2013.08
 >> also affected?

 > As far as I can see this was introduced with commit fe192908a4e:

 >  commit fe192908a4e3195b6f724310fe83fadaf18b66e7
 >  Author: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
 >  Date:   Sat Mar 9 08:21:30 2013 +0000

 >     libglib2: use system pcre when available

Ok, so 2013.08 is also affected. We afaik didn't have any bug reports
related to this, but I have added the 2 patches for 2013.11 - Thanks.

-- 
Bye, Peter Korsgaard

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2013-11-25 10:04 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-11-22 21:58 [Buildroot] [PATCH v2 2/2] libglib2: the system PCRE needs to have UTF and UCP enabled Sven Neumann
2013-11-22 22:33 ` Peter Korsgaard
2013-11-25  7:49   ` Sven Neumann
2013-11-25  9:17     ` Peter Korsgaard
2013-11-25  9:54       ` Sven Neumann
2013-11-25 10:04         ` Peter Korsgaard

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.