* [PATCH v4 0/2] cpufreq: opp: Add device tree based lookup of boost mode frequency
@ 2014-05-23 13:37 ` Thomas Abraham
0 siblings, 0 replies; 12+ messages in thread
From: Thomas Abraham @ 2014-05-23 13:37 UTC (permalink / raw
To: linux-pm, devicetree, linux-arm-kernel
Cc: rjw, linux-samsung-soc, kgene.kim, t.figa, l.majewski,
viresh.kumar, thomas.ab, nm
Changes since v3:
- Minor changes as suggested in the last version.
Changes since v2:
- Reworked based on the "PM / OPP: move cpufreq specific helpers out of OPP
layer" patch series posted by Nishanth Menon <n...@ti.com>.
Changes since v1:
- Boost mode frequencies are specfied as a set of frequencies instead of
specifying them as OPPs. Thanks to Nishanth, Lukasz and Rob for the
feedback.
Commit 6f19efc0 ("cpufreq: Add boost frequency support in core") adds
support for CPU boost mode for CPUfreq drivers. To use the new boost
mode, CPUfreq drivers have to specify the boost mode frequency and
voltage within the CPUfreq driver, which is the case for Exynos4x12
CPUfreq driver.
But for CPUfreq drivers which obtain the OPPs from cpus node, this
patch series adds support to specify boost mode frequencies in the
cpu device tree node. This requirement came up when Lukasz pointed
out the regression caused by the Exynos CPUfreq driver consolidation
patches.
Thomas Abraham (2):
cpufreq / OPP: Allow boost frequency to be looked up from device tree
Documentation: devicetree: Add boost-frequency binding to list boost
mode frequency
.../devicetree/bindings/cpufreq/cpufreq-boost.txt | 38 +++++++++++++++++
drivers/cpufreq/cpufreq_opp.c | 44 ++++++++++++++++++++
2 files changed, 82 insertions(+)
create mode 100644 Documentation/devicetree/bindings/cpufreq/cpufreq-boost.txt
--
1.7.9.5
^ permalink raw reply [flat|nested] 12+ messages in thread
* [PATCH v4 0/2] cpufreq: opp: Add device tree based lookup of boost mode frequency
@ 2014-05-23 13:37 ` Thomas Abraham
0 siblings, 0 replies; 12+ messages in thread
From: Thomas Abraham @ 2014-05-23 13:37 UTC (permalink / raw
To: linux-arm-kernel
Changes since v3:
- Minor changes as suggested in the last version.
Changes since v2:
- Reworked based on the "PM / OPP: move cpufreq specific helpers out of OPP
layer" patch series posted by Nishanth Menon <n...@ti.com>.
Changes since v1:
- Boost mode frequencies are specfied as a set of frequencies instead of
specifying them as OPPs. Thanks to Nishanth, Lukasz and Rob for the
feedback.
Commit 6f19efc0 ("cpufreq: Add boost frequency support in core") adds
support for CPU boost mode for CPUfreq drivers. To use the new boost
mode, CPUfreq drivers have to specify the boost mode frequency and
voltage within the CPUfreq driver, which is the case for Exynos4x12
CPUfreq driver.
But for CPUfreq drivers which obtain the OPPs from cpus node, this
patch series adds support to specify boost mode frequencies in the
cpu device tree node. This requirement came up when Lukasz pointed
out the regression caused by the Exynos CPUfreq driver consolidation
patches.
Thomas Abraham (2):
cpufreq / OPP: Allow boost frequency to be looked up from device tree
Documentation: devicetree: Add boost-frequency binding to list boost
mode frequency
.../devicetree/bindings/cpufreq/cpufreq-boost.txt | 38 +++++++++++++++++
drivers/cpufreq/cpufreq_opp.c | 44 ++++++++++++++++++++
2 files changed, 82 insertions(+)
create mode 100644 Documentation/devicetree/bindings/cpufreq/cpufreq-boost.txt
--
1.7.9.5
^ permalink raw reply [flat|nested] 12+ messages in thread
* [PATCH v4 1/2] cpufreq / OPP: Allow boost frequency to be looked up from device tree
2014-05-23 13:37 ` Thomas Abraham
@ 2014-05-23 13:37 ` Thomas Abraham
-1 siblings, 0 replies; 12+ messages in thread
From: Thomas Abraham @ 2014-05-23 13:37 UTC (permalink / raw
To: linux-pm, devicetree, linux-arm-kernel
Cc: rjw, linux-samsung-soc, kgene.kim, t.figa, l.majewski,
viresh.kumar, thomas.ab, nm
From: Thomas Abraham <thomas.ab@samsung.com>
Commit 6f19efc0 ("cpufreq: Add boost frequency support in core") adds
support for CPU boost mode. This patch adds support for finding available
boost frequencies from device tree and marking them as usable in boost mode.
Cc: Nishanth Menon <nm@ti.com>
Cc: Lukasz Majewski <l.majewski@samsung.com>
Signed-off-by: Thomas Abraham <thomas.ab@samsung.com>
---
drivers/cpufreq/cpufreq_opp.c | 44 +++++++++++++++++++++++++++++++++++++++++
1 file changed, 44 insertions(+)
diff --git a/drivers/cpufreq/cpufreq_opp.c b/drivers/cpufreq/cpufreq_opp.c
index c0c6f4a..2b3905b 100644
--- a/drivers/cpufreq/cpufreq_opp.c
+++ b/drivers/cpufreq/cpufreq_opp.c
@@ -19,6 +19,7 @@
#include <linux/pm_opp.h>
#include <linux/rcupdate.h>
#include <linux/slab.h>
+#include <linux/of.h>
/**
* dev_pm_opp_init_cpufreq_table() - create a cpufreq table for a device
@@ -51,6 +52,10 @@ int dev_pm_opp_init_cpufreq_table(struct device *dev,
struct cpufreq_frequency_table *freq_table = NULL;
int i, max_opps, ret = 0;
unsigned long rate;
+#ifdef CONFIG_CPU_FREQ_BOOST_SW
+ int j, len;
+ u32 *boost_freqs = NULL;
+#endif
rcu_read_lock();
@@ -82,6 +87,45 @@ int dev_pm_opp_init_cpufreq_table(struct device *dev,
*table = &freq_table[0];
+#ifdef CONFIG_CPU_FREQ_BOOST_SW
+ if (of_find_property(dev->of_node, "boost-frequencies", &len)) {
+ struct cpufreq_frequency_table *ft;
+
+ if (len == 0 || (len & (sizeof(u32) - 1)) != 0) {
+ dev_err(dev, "%s: invalid boost frequency\n", __func__);
+ ret = -EINVAL;
+ goto out;
+ }
+
+ boost_freqs = kzalloc(len, GFP_KERNEL);
+ if (!boost_freqs) {
+ dev_warn(dev, "%s: no memory for boost freq table\n",
+ __func__);
+ ret = -ENOMEM;
+ goto out;
+ }
+ of_property_read_u32_array(dev->of_node, "boost-frequencies",
+ boost_freqs, len / sizeof(u32));
+
+ for (j = 0; j < len / sizeof(u32); j++) {
+ ft = *table;
+ for (i = 0; ft->frequency != CPUFREQ_TABLE_END; i++) {
+ if (boost_freqs[j] == ft->frequency) {
+ ft->flags |= CPUFREQ_BOOST_FREQ;
+ break;
+ }
+ ft++;
+ }
+
+ if (ft->frequency == CPUFREQ_TABLE_END)
+ pr_err("%s: invalid boost frequency %d\n",
+ __func__, boost_freqs[j]);
+ }
+ }
+
+ kfree(boost_freqs);
+#endif
+
out:
rcu_read_unlock();
if (ret)
--
1.7.9.5
^ permalink raw reply related [flat|nested] 12+ messages in thread
* [PATCH v4 1/2] cpufreq / OPP: Allow boost frequency to be looked up from device tree
@ 2014-05-23 13:37 ` Thomas Abraham
0 siblings, 0 replies; 12+ messages in thread
From: Thomas Abraham @ 2014-05-23 13:37 UTC (permalink / raw
To: linux-arm-kernel
From: Thomas Abraham <thomas.ab@samsung.com>
Commit 6f19efc0 ("cpufreq: Add boost frequency support in core") adds
support for CPU boost mode. This patch adds support for finding available
boost frequencies from device tree and marking them as usable in boost mode.
Cc: Nishanth Menon <nm@ti.com>
Cc: Lukasz Majewski <l.majewski@samsung.com>
Signed-off-by: Thomas Abraham <thomas.ab@samsung.com>
---
drivers/cpufreq/cpufreq_opp.c | 44 +++++++++++++++++++++++++++++++++++++++++
1 file changed, 44 insertions(+)
diff --git a/drivers/cpufreq/cpufreq_opp.c b/drivers/cpufreq/cpufreq_opp.c
index c0c6f4a..2b3905b 100644
--- a/drivers/cpufreq/cpufreq_opp.c
+++ b/drivers/cpufreq/cpufreq_opp.c
@@ -19,6 +19,7 @@
#include <linux/pm_opp.h>
#include <linux/rcupdate.h>
#include <linux/slab.h>
+#include <linux/of.h>
/**
* dev_pm_opp_init_cpufreq_table() - create a cpufreq table for a device
@@ -51,6 +52,10 @@ int dev_pm_opp_init_cpufreq_table(struct device *dev,
struct cpufreq_frequency_table *freq_table = NULL;
int i, max_opps, ret = 0;
unsigned long rate;
+#ifdef CONFIG_CPU_FREQ_BOOST_SW
+ int j, len;
+ u32 *boost_freqs = NULL;
+#endif
rcu_read_lock();
@@ -82,6 +87,45 @@ int dev_pm_opp_init_cpufreq_table(struct device *dev,
*table = &freq_table[0];
+#ifdef CONFIG_CPU_FREQ_BOOST_SW
+ if (of_find_property(dev->of_node, "boost-frequencies", &len)) {
+ struct cpufreq_frequency_table *ft;
+
+ if (len == 0 || (len & (sizeof(u32) - 1)) != 0) {
+ dev_err(dev, "%s: invalid boost frequency\n", __func__);
+ ret = -EINVAL;
+ goto out;
+ }
+
+ boost_freqs = kzalloc(len, GFP_KERNEL);
+ if (!boost_freqs) {
+ dev_warn(dev, "%s: no memory for boost freq table\n",
+ __func__);
+ ret = -ENOMEM;
+ goto out;
+ }
+ of_property_read_u32_array(dev->of_node, "boost-frequencies",
+ boost_freqs, len / sizeof(u32));
+
+ for (j = 0; j < len / sizeof(u32); j++) {
+ ft = *table;
+ for (i = 0; ft->frequency != CPUFREQ_TABLE_END; i++) {
+ if (boost_freqs[j] == ft->frequency) {
+ ft->flags |= CPUFREQ_BOOST_FREQ;
+ break;
+ }
+ ft++;
+ }
+
+ if (ft->frequency == CPUFREQ_TABLE_END)
+ pr_err("%s: invalid boost frequency %d\n",
+ __func__, boost_freqs[j]);
+ }
+ }
+
+ kfree(boost_freqs);
+#endif
+
out:
rcu_read_unlock();
if (ret)
--
1.7.9.5
^ permalink raw reply related [flat|nested] 12+ messages in thread
* [PATCH v4 2/2] Documentation: devicetree: Add boost-frequency binding to list boost mode frequency
2014-05-23 13:37 ` Thomas Abraham
@ 2014-05-23 13:37 ` Thomas Abraham
-1 siblings, 0 replies; 12+ messages in thread
From: Thomas Abraham @ 2014-05-23 13:37 UTC (permalink / raw
To: linux-pm, devicetree, linux-arm-kernel
Cc: rjw, linux-samsung-soc, kgene.kim, t.figa, l.majewski,
viresh.kumar, thomas.ab, nm, Rob Herring, Pawel Moll,
Mark Rutland, Ian Campbell, Kumar Gala
From: Thomas Abraham <thomas.ab@samsung.com>
Add a new optional boost-frequency binding for specifying the frequencies
usable in boost mode.
Cc: Nishanth Menon <nm@ti.com>
Cc: Lukasz Majewski <l.majewski@samsung.com>
Cc: Rob Herring <robh+dt@kernel.org>
Cc: Pawel Moll <pawel.moll@arm.com>
Cc: Mark Rutland <mark.rutland@arm.com>
Cc: Ian Campbell <ijc+devicetree@hellion.org.uk>
Cc: Kumar Gala <galak@codeaurora.org>
Signed-off-by: Thomas Abraham <thomas.ab@samsung.com>
---
.../devicetree/bindings/cpufreq/cpufreq-boost.txt | 38 ++++++++++++++++++++
1 file changed, 38 insertions(+)
create mode 100644 Documentation/devicetree/bindings/cpufreq/cpufreq-boost.txt
diff --git a/Documentation/devicetree/bindings/cpufreq/cpufreq-boost.txt b/Documentation/devicetree/bindings/cpufreq/cpufreq-boost.txt
new file mode 100644
index 0000000..63ed0fc
--- /dev/null
+++ b/Documentation/devicetree/bindings/cpufreq/cpufreq-boost.txt
@@ -0,0 +1,38 @@
+* Device tree binding for CPU boost frequency (aka over-clocking)
+
+Certain CPU's can be operated in optional 'boost' mode (or sometimes referred as
+overclocking) in which the CPU can operate at frequencies which are not
+specified by the manufacturer as CPU's operating frequency.
+
+Optional Properties:
+- boost-frequencies: list of frequencies in KHz to be used only in boost mode.
+ This list should be a subset of frequencies listed in "operating-points"
+ property. Refer to Documentation/devicetree/bindings/power/opp.txt for
+ details about "operating-points" property.
+
+Example:
+
+ cpus {
+ #address-cells = <1>;
+ #size-cells = <0>;
+ cpu@0 {
+ device_type = "cpu";
+ compatible = "arm,cortex-a9";
+ reg = <0>;
+
+ operating-points = <
+ 1500000 1350000
+ 1400000 1287500
+ 1300000 1250000
+ 1200000 1187500
+ 1100000 1137500
+ 1000000 1087500
+ >;
+ boost-frequencies = <1500000 1400000>;
+ };
+ cpu@1 {
+ device_type = "cpu";
+ compatible = "arm,cortex-a9";
+ reg = <1>;
+ };
+ };
--
1.7.9.5
^ permalink raw reply related [flat|nested] 12+ messages in thread
* [PATCH v4 2/2] Documentation: devicetree: Add boost-frequency binding to list boost mode frequency
@ 2014-05-23 13:37 ` Thomas Abraham
0 siblings, 0 replies; 12+ messages in thread
From: Thomas Abraham @ 2014-05-23 13:37 UTC (permalink / raw
To: linux-arm-kernel
From: Thomas Abraham <thomas.ab@samsung.com>
Add a new optional boost-frequency binding for specifying the frequencies
usable in boost mode.
Cc: Nishanth Menon <nm@ti.com>
Cc: Lukasz Majewski <l.majewski@samsung.com>
Cc: Rob Herring <robh+dt@kernel.org>
Cc: Pawel Moll <pawel.moll@arm.com>
Cc: Mark Rutland <mark.rutland@arm.com>
Cc: Ian Campbell <ijc+devicetree@hellion.org.uk>
Cc: Kumar Gala <galak@codeaurora.org>
Signed-off-by: Thomas Abraham <thomas.ab@samsung.com>
---
.../devicetree/bindings/cpufreq/cpufreq-boost.txt | 38 ++++++++++++++++++++
1 file changed, 38 insertions(+)
create mode 100644 Documentation/devicetree/bindings/cpufreq/cpufreq-boost.txt
diff --git a/Documentation/devicetree/bindings/cpufreq/cpufreq-boost.txt b/Documentation/devicetree/bindings/cpufreq/cpufreq-boost.txt
new file mode 100644
index 0000000..63ed0fc
--- /dev/null
+++ b/Documentation/devicetree/bindings/cpufreq/cpufreq-boost.txt
@@ -0,0 +1,38 @@
+* Device tree binding for CPU boost frequency (aka over-clocking)
+
+Certain CPU's can be operated in optional 'boost' mode (or sometimes referred as
+overclocking) in which the CPU can operate at frequencies which are not
+specified by the manufacturer as CPU's operating frequency.
+
+Optional Properties:
+- boost-frequencies: list of frequencies in KHz to be used only in boost mode.
+ This list should be a subset of frequencies listed in "operating-points"
+ property. Refer to Documentation/devicetree/bindings/power/opp.txt for
+ details about "operating-points" property.
+
+Example:
+
+ cpus {
+ #address-cells = <1>;
+ #size-cells = <0>;
+ cpu at 0 {
+ device_type = "cpu";
+ compatible = "arm,cortex-a9";
+ reg = <0>;
+
+ operating-points = <
+ 1500000 1350000
+ 1400000 1287500
+ 1300000 1250000
+ 1200000 1187500
+ 1100000 1137500
+ 1000000 1087500
+ >;
+ boost-frequencies = <1500000 1400000>;
+ };
+ cpu at 1 {
+ device_type = "cpu";
+ compatible = "arm,cortex-a9";
+ reg = <1>;
+ };
+ };
--
1.7.9.5
^ permalink raw reply related [flat|nested] 12+ messages in thread
* Re: [PATCH v4 1/2] cpufreq / OPP: Allow boost frequency to be looked up from device tree
2014-05-23 13:37 ` Thomas Abraham
@ 2014-05-26 5:58 ` Viresh Kumar
-1 siblings, 0 replies; 12+ messages in thread
From: Viresh Kumar @ 2014-05-26 5:58 UTC (permalink / raw
To: Thomas Abraham
Cc: linux-pm@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, Rafael J. Wysocki,
linux-samsung-soc, Kukjin Kim, Tomasz Figa, Lukasz Majewski,
Nishanth Menon
On 23 May 2014 19:07, Thomas Abraham <thomas.ab@samsung.com> wrote:
> From: Thomas Abraham <thomas.ab@samsung.com>
>
> Commit 6f19efc0 ("cpufreq: Add boost frequency support in core") adds
> support for CPU boost mode. This patch adds support for finding available
> boost frequencies from device tree and marking them as usable in boost mode.
>
> Cc: Nishanth Menon <nm@ti.com>
> Cc: Lukasz Majewski <l.majewski@samsung.com>
> Signed-off-by: Thomas Abraham <thomas.ab@samsung.com>
> ---
> drivers/cpufreq/cpufreq_opp.c | 44 +++++++++++++++++++++++++++++++++++++++++
> 1 file changed, 44 insertions(+)
>
> diff --git a/drivers/cpufreq/cpufreq_opp.c b/drivers/cpufreq/cpufreq_opp.c
> index c0c6f4a..2b3905b 100644
> --- a/drivers/cpufreq/cpufreq_opp.c
> +++ b/drivers/cpufreq/cpufreq_opp.c
> @@ -19,6 +19,7 @@
> #include <linux/pm_opp.h>
> #include <linux/rcupdate.h>
> #include <linux/slab.h>
> +#include <linux/of.h>
>
> /**
> * dev_pm_opp_init_cpufreq_table() - create a cpufreq table for a device
> @@ -51,6 +52,10 @@ int dev_pm_opp_init_cpufreq_table(struct device *dev,
> struct cpufreq_frequency_table *freq_table = NULL;
> int i, max_opps, ret = 0;
> unsigned long rate;
> +#ifdef CONFIG_CPU_FREQ_BOOST_SW
> + int j, len;
> + u32 *boost_freqs = NULL;
> +#endif
>
> rcu_read_lock();
>
> @@ -82,6 +87,45 @@ int dev_pm_opp_init_cpufreq_table(struct device *dev,
>
> *table = &freq_table[0];
>
> +#ifdef CONFIG_CPU_FREQ_BOOST_SW
> + if (of_find_property(dev->of_node, "boost-frequencies", &len)) {
Maybe:
if(!of_find_property(...))
goto out;
To get rid of extra indentation levels below..
> + struct cpufreq_frequency_table *ft;
Declare at the top with boost_freqs, etc..
> + if (len == 0 || (len & (sizeof(u32) - 1)) != 0) {
s/len == 0/!len
And use IS_ALIGNED() instead of the right hand side of ||
> + dev_err(dev, "%s: invalid boost frequency\n", __func__);
> + ret = -EINVAL;
> + goto out;
> + }
> +
> + boost_freqs = kzalloc(len, GFP_KERNEL);
Can we do a devm_kzalloc instead? And why not kmalloc BTW ?
> + if (!boost_freqs) {
> + dev_warn(dev, "%s: no memory for boost freq table\n",
dev_err ?
> + __func__);
> + ret = -ENOMEM;
> + goto out;
> + }
> + of_property_read_u32_array(dev->of_node, "boost-frequencies",
> + boost_freqs, len / sizeof(u32));
Create int count = len / sizeof(u32) instead.. You have used this
multiple times.
> + for (j = 0; j < len / sizeof(u32); j++) {
> + ft = *table;
> + for (i = 0; ft->frequency != CPUFREQ_TABLE_END; i++) {
See if new macros can be used here instead. cpufreq_for_each_valid_entry().
> + if (boost_freqs[j] == ft->frequency) {
> + ft->flags |= CPUFREQ_BOOST_FREQ;
> + break;
> + }
> + ft++;
> + }
> +
> + if (ft->frequency == CPUFREQ_TABLE_END)
> + pr_err("%s: invalid boost frequency %d\n",
> + __func__, boost_freqs[j]);
Maybe a pr_debug on the else part as well ? With boost freqs ..
> + }
> + }
> +
> + kfree(boost_freqs);
> +#endif
> +
> out:
> rcu_read_unlock();
> if (ret)
> --
> 1.7.9.5
>
^ permalink raw reply [flat|nested] 12+ messages in thread
* [PATCH v4 1/2] cpufreq / OPP: Allow boost frequency to be looked up from device tree
@ 2014-05-26 5:58 ` Viresh Kumar
0 siblings, 0 replies; 12+ messages in thread
From: Viresh Kumar @ 2014-05-26 5:58 UTC (permalink / raw
To: linux-arm-kernel
On 23 May 2014 19:07, Thomas Abraham <thomas.ab@samsung.com> wrote:
> From: Thomas Abraham <thomas.ab@samsung.com>
>
> Commit 6f19efc0 ("cpufreq: Add boost frequency support in core") adds
> support for CPU boost mode. This patch adds support for finding available
> boost frequencies from device tree and marking them as usable in boost mode.
>
> Cc: Nishanth Menon <nm@ti.com>
> Cc: Lukasz Majewski <l.majewski@samsung.com>
> Signed-off-by: Thomas Abraham <thomas.ab@samsung.com>
> ---
> drivers/cpufreq/cpufreq_opp.c | 44 +++++++++++++++++++++++++++++++++++++++++
> 1 file changed, 44 insertions(+)
>
> diff --git a/drivers/cpufreq/cpufreq_opp.c b/drivers/cpufreq/cpufreq_opp.c
> index c0c6f4a..2b3905b 100644
> --- a/drivers/cpufreq/cpufreq_opp.c
> +++ b/drivers/cpufreq/cpufreq_opp.c
> @@ -19,6 +19,7 @@
> #include <linux/pm_opp.h>
> #include <linux/rcupdate.h>
> #include <linux/slab.h>
> +#include <linux/of.h>
>
> /**
> * dev_pm_opp_init_cpufreq_table() - create a cpufreq table for a device
> @@ -51,6 +52,10 @@ int dev_pm_opp_init_cpufreq_table(struct device *dev,
> struct cpufreq_frequency_table *freq_table = NULL;
> int i, max_opps, ret = 0;
> unsigned long rate;
> +#ifdef CONFIG_CPU_FREQ_BOOST_SW
> + int j, len;
> + u32 *boost_freqs = NULL;
> +#endif
>
> rcu_read_lock();
>
> @@ -82,6 +87,45 @@ int dev_pm_opp_init_cpufreq_table(struct device *dev,
>
> *table = &freq_table[0];
>
> +#ifdef CONFIG_CPU_FREQ_BOOST_SW
> + if (of_find_property(dev->of_node, "boost-frequencies", &len)) {
Maybe:
if(!of_find_property(...))
goto out;
To get rid of extra indentation levels below..
> + struct cpufreq_frequency_table *ft;
Declare at the top with boost_freqs, etc..
> + if (len == 0 || (len & (sizeof(u32) - 1)) != 0) {
s/len == 0/!len
And use IS_ALIGNED() instead of the right hand side of ||
> + dev_err(dev, "%s: invalid boost frequency\n", __func__);
> + ret = -EINVAL;
> + goto out;
> + }
> +
> + boost_freqs = kzalloc(len, GFP_KERNEL);
Can we do a devm_kzalloc instead? And why not kmalloc BTW ?
> + if (!boost_freqs) {
> + dev_warn(dev, "%s: no memory for boost freq table\n",
dev_err ?
> + __func__);
> + ret = -ENOMEM;
> + goto out;
> + }
> + of_property_read_u32_array(dev->of_node, "boost-frequencies",
> + boost_freqs, len / sizeof(u32));
Create int count = len / sizeof(u32) instead.. You have used this
multiple times.
> + for (j = 0; j < len / sizeof(u32); j++) {
> + ft = *table;
> + for (i = 0; ft->frequency != CPUFREQ_TABLE_END; i++) {
See if new macros can be used here instead. cpufreq_for_each_valid_entry().
> + if (boost_freqs[j] == ft->frequency) {
> + ft->flags |= CPUFREQ_BOOST_FREQ;
> + break;
> + }
> + ft++;
> + }
> +
> + if (ft->frequency == CPUFREQ_TABLE_END)
> + pr_err("%s: invalid boost frequency %d\n",
> + __func__, boost_freqs[j]);
Maybe a pr_debug on the else part as well ? With boost freqs ..
> + }
> + }
> +
> + kfree(boost_freqs);
> +#endif
> +
> out:
> rcu_read_unlock();
> if (ret)
> --
> 1.7.9.5
>
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH v4 2/2] Documentation: devicetree: Add boost-frequency binding to list boost mode frequency
2014-05-23 13:37 ` Thomas Abraham
@ 2014-05-26 6:09 ` Viresh Kumar
-1 siblings, 0 replies; 12+ messages in thread
From: Viresh Kumar @ 2014-05-26 6:09 UTC (permalink / raw
To: Thomas Abraham
Cc: linux-pm@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, Rafael J. Wysocki,
linux-samsung-soc, Kukjin Kim, Tomasz Figa, Lukasz Majewski,
Nishanth Menon, Rob Herring, Pawel Moll, Mark Rutland,
Ian Campbell, Kumar Gala
On 23 May 2014 19:07, Thomas Abraham <thomas.ab@samsung.com> wrote:
> From: Thomas Abraham <thomas.ab@samsung.com>
>
> Add a new optional boost-frequency binding for specifying the frequencies
> usable in boost mode.
>
> Cc: Nishanth Menon <nm@ti.com>
> Cc: Lukasz Majewski <l.majewski@samsung.com>
> Cc: Rob Herring <robh+dt@kernel.org>
> Cc: Pawel Moll <pawel.moll@arm.com>
> Cc: Mark Rutland <mark.rutland@arm.com>
> Cc: Ian Campbell <ijc+devicetree@hellion.org.uk>
> Cc: Kumar Gala <galak@codeaurora.org>
> Signed-off-by: Thomas Abraham <thomas.ab@samsung.com>
> ---
> .../devicetree/bindings/cpufreq/cpufreq-boost.txt | 38 ++++++++++++++++++++
> 1 file changed, 38 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/cpufreq/cpufreq-boost.txt
>
> diff --git a/Documentation/devicetree/bindings/cpufreq/cpufreq-boost.txt b/Documentation/devicetree/bindings/cpufreq/cpufreq-boost.txt
> new file mode 100644
> index 0000000..63ed0fc
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/cpufreq/cpufreq-boost.txt
> @@ -0,0 +1,38 @@
> +* Device tree binding for CPU boost frequency (aka over-clocking)
> +
> +Certain CPU's can be operated in optional 'boost' mode (or sometimes referred as
> +overclocking) in which the CPU can operate at frequencies which are not
> +specified by the manufacturer as CPU's operating frequency.
> +
> +Optional Properties:
> +- boost-frequencies: list of frequencies in KHz to be used only in boost mode.
> + This list should be a subset of frequencies listed in "operating-points"
> + property. Refer to Documentation/devicetree/bindings/power/opp.txt for
> + details about "operating-points" property.
> +
> +Example:
> +
> + cpus {
> + #address-cells = <1>;
> + #size-cells = <0>;
> + cpu@0 {
> + device_type = "cpu";
> + compatible = "arm,cortex-a9";
> + reg = <0>;
> +
> + operating-points = <
> + 1500000 1350000
> + 1400000 1287500
> + 1300000 1250000
> + 1200000 1187500
> + 1100000 1137500
> + 1000000 1087500
> + >;
> + boost-frequencies = <1500000 1400000>;
> + };
> + cpu@1 {
> + device_type = "cpu";
> + compatible = "arm,cortex-a9";
> + reg = <1>;
> + };
> + };
Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
^ permalink raw reply [flat|nested] 12+ messages in thread
* [PATCH v4 2/2] Documentation: devicetree: Add boost-frequency binding to list boost mode frequency
@ 2014-05-26 6:09 ` Viresh Kumar
0 siblings, 0 replies; 12+ messages in thread
From: Viresh Kumar @ 2014-05-26 6:09 UTC (permalink / raw
To: linux-arm-kernel
On 23 May 2014 19:07, Thomas Abraham <thomas.ab@samsung.com> wrote:
> From: Thomas Abraham <thomas.ab@samsung.com>
>
> Add a new optional boost-frequency binding for specifying the frequencies
> usable in boost mode.
>
> Cc: Nishanth Menon <nm@ti.com>
> Cc: Lukasz Majewski <l.majewski@samsung.com>
> Cc: Rob Herring <robh+dt@kernel.org>
> Cc: Pawel Moll <pawel.moll@arm.com>
> Cc: Mark Rutland <mark.rutland@arm.com>
> Cc: Ian Campbell <ijc+devicetree@hellion.org.uk>
> Cc: Kumar Gala <galak@codeaurora.org>
> Signed-off-by: Thomas Abraham <thomas.ab@samsung.com>
> ---
> .../devicetree/bindings/cpufreq/cpufreq-boost.txt | 38 ++++++++++++++++++++
> 1 file changed, 38 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/cpufreq/cpufreq-boost.txt
>
> diff --git a/Documentation/devicetree/bindings/cpufreq/cpufreq-boost.txt b/Documentation/devicetree/bindings/cpufreq/cpufreq-boost.txt
> new file mode 100644
> index 0000000..63ed0fc
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/cpufreq/cpufreq-boost.txt
> @@ -0,0 +1,38 @@
> +* Device tree binding for CPU boost frequency (aka over-clocking)
> +
> +Certain CPU's can be operated in optional 'boost' mode (or sometimes referred as
> +overclocking) in which the CPU can operate at frequencies which are not
> +specified by the manufacturer as CPU's operating frequency.
> +
> +Optional Properties:
> +- boost-frequencies: list of frequencies in KHz to be used only in boost mode.
> + This list should be a subset of frequencies listed in "operating-points"
> + property. Refer to Documentation/devicetree/bindings/power/opp.txt for
> + details about "operating-points" property.
> +
> +Example:
> +
> + cpus {
> + #address-cells = <1>;
> + #size-cells = <0>;
> + cpu at 0 {
> + device_type = "cpu";
> + compatible = "arm,cortex-a9";
> + reg = <0>;
> +
> + operating-points = <
> + 1500000 1350000
> + 1400000 1287500
> + 1300000 1250000
> + 1200000 1187500
> + 1100000 1137500
> + 1000000 1087500
> + >;
> + boost-frequencies = <1500000 1400000>;
> + };
> + cpu at 1 {
> + device_type = "cpu";
> + compatible = "arm,cortex-a9";
> + reg = <1>;
> + };
> + };
Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH v4 1/2] cpufreq / OPP: Allow boost frequency to be looked up from device tree
2014-05-26 5:58 ` Viresh Kumar
@ 2014-05-29 14:23 ` Thomas Abraham
-1 siblings, 0 replies; 12+ messages in thread
From: Thomas Abraham @ 2014-05-29 14:23 UTC (permalink / raw
To: Viresh Kumar
Cc: linux-pm@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, Rafael J. Wysocki,
linux-samsung-soc, Kukjin Kim, Tomasz Figa, Lukasz Majewski,
Nishanth Menon
On Mon, May 26, 2014 at 11:28 AM, Viresh Kumar <viresh.kumar@linaro.org> wrote:
> On 23 May 2014 19:07, Thomas Abraham <thomas.ab@samsung.com> wrote:
>> From: Thomas Abraham <thomas.ab@samsung.com>
>>
>> Commit 6f19efc0 ("cpufreq: Add boost frequency support in core") adds
>> support for CPU boost mode. This patch adds support for finding available
>> boost frequencies from device tree and marking them as usable in boost mode.
>>
>> Cc: Nishanth Menon <nm@ti.com>
>> Cc: Lukasz Majewski <l.majewski@samsung.com>
>> Signed-off-by: Thomas Abraham <thomas.ab@samsung.com>
>> ---
>> drivers/cpufreq/cpufreq_opp.c | 44 +++++++++++++++++++++++++++++++++++++++++
>> 1 file changed, 44 insertions(+)
>>
>> diff --git a/drivers/cpufreq/cpufreq_opp.c b/drivers/cpufreq/cpufreq_opp.c
>> index c0c6f4a..2b3905b 100644
>> --- a/drivers/cpufreq/cpufreq_opp.c
>> +++ b/drivers/cpufreq/cpufreq_opp.c
>> @@ -19,6 +19,7 @@
>> #include <linux/pm_opp.h>
>> #include <linux/rcupdate.h>
>> #include <linux/slab.h>
>> +#include <linux/of.h>
>>
>> /**
>> * dev_pm_opp_init_cpufreq_table() - create a cpufreq table for a device
>> @@ -51,6 +52,10 @@ int dev_pm_opp_init_cpufreq_table(struct device *dev,
>> struct cpufreq_frequency_table *freq_table = NULL;
>> int i, max_opps, ret = 0;
>> unsigned long rate;
>> +#ifdef CONFIG_CPU_FREQ_BOOST_SW
>> + int j, len;
>> + u32 *boost_freqs = NULL;
>> +#endif
>>
>> rcu_read_lock();
>>
>> @@ -82,6 +87,45 @@ int dev_pm_opp_init_cpufreq_table(struct device *dev,
>>
>> *table = &freq_table[0];
>>
>> +#ifdef CONFIG_CPU_FREQ_BOOST_SW
>> + if (of_find_property(dev->of_node, "boost-frequencies", &len)) {
>
> Maybe:
> if(!of_find_property(...))
> goto out;
>
> To get rid of extra indentation levels below..
>
>> + struct cpufreq_frequency_table *ft;
>
> Declare at the top with boost_freqs, etc..
>
>> + if (len == 0 || (len & (sizeof(u32) - 1)) != 0) {
>
> s/len == 0/!len
>
> And use IS_ALIGNED() instead of the right hand side of ||
>
>> + dev_err(dev, "%s: invalid boost frequency\n", __func__);
>> + ret = -EINVAL;
>> + goto out;
>> + }
>> +
>> + boost_freqs = kzalloc(len, GFP_KERNEL);
>
> Can we do a devm_kzalloc instead? And why not kmalloc BTW ?
This is a temporary storage that is freed at the end of this function.
So devm_kzalloc is not used. Yes, kmalloc can be used.
>
>> + if (!boost_freqs) {
>> + dev_warn(dev, "%s: no memory for boost freq table\n",
>
> dev_err ?
>
>> + __func__);
>> + ret = -ENOMEM;
>> + goto out;
>> + }
>> + of_property_read_u32_array(dev->of_node, "boost-frequencies",
>> + boost_freqs, len / sizeof(u32));
>
>
> Create int count = len / sizeof(u32) instead.. You have used this
> multiple times.
>
>> + for (j = 0; j < len / sizeof(u32); j++) {
>> + ft = *table;
>> + for (i = 0; ft->frequency != CPUFREQ_TABLE_END; i++) {
>
> See if new macros can be used here instead. cpufreq_for_each_valid_entry().
>
>> + if (boost_freqs[j] == ft->frequency) {
>> + ft->flags |= CPUFREQ_BOOST_FREQ;
>> + break;
>> + }
>> + ft++;
>> + }
>> +
>> + if (ft->frequency == CPUFREQ_TABLE_END)
>> + pr_err("%s: invalid boost frequency %d\n",
>> + __func__, boost_freqs[j]);
>
> Maybe a pr_debug on the else part as well ? With boost freqs ..
>
>> + }
>> + }
>> +
>> + kfree(boost_freqs);
>> +#endif
>> +
>> out:
>> rcu_read_unlock();
>> if (ret)
>> --
>> 1.7.9.5
>>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 12+ messages in thread
* [PATCH v4 1/2] cpufreq / OPP: Allow boost frequency to be looked up from device tree
@ 2014-05-29 14:23 ` Thomas Abraham
0 siblings, 0 replies; 12+ messages in thread
From: Thomas Abraham @ 2014-05-29 14:23 UTC (permalink / raw
To: linux-arm-kernel
On Mon, May 26, 2014 at 11:28 AM, Viresh Kumar <viresh.kumar@linaro.org> wrote:
> On 23 May 2014 19:07, Thomas Abraham <thomas.ab@samsung.com> wrote:
>> From: Thomas Abraham <thomas.ab@samsung.com>
>>
>> Commit 6f19efc0 ("cpufreq: Add boost frequency support in core") adds
>> support for CPU boost mode. This patch adds support for finding available
>> boost frequencies from device tree and marking them as usable in boost mode.
>>
>> Cc: Nishanth Menon <nm@ti.com>
>> Cc: Lukasz Majewski <l.majewski@samsung.com>
>> Signed-off-by: Thomas Abraham <thomas.ab@samsung.com>
>> ---
>> drivers/cpufreq/cpufreq_opp.c | 44 +++++++++++++++++++++++++++++++++++++++++
>> 1 file changed, 44 insertions(+)
>>
>> diff --git a/drivers/cpufreq/cpufreq_opp.c b/drivers/cpufreq/cpufreq_opp.c
>> index c0c6f4a..2b3905b 100644
>> --- a/drivers/cpufreq/cpufreq_opp.c
>> +++ b/drivers/cpufreq/cpufreq_opp.c
>> @@ -19,6 +19,7 @@
>> #include <linux/pm_opp.h>
>> #include <linux/rcupdate.h>
>> #include <linux/slab.h>
>> +#include <linux/of.h>
>>
>> /**
>> * dev_pm_opp_init_cpufreq_table() - create a cpufreq table for a device
>> @@ -51,6 +52,10 @@ int dev_pm_opp_init_cpufreq_table(struct device *dev,
>> struct cpufreq_frequency_table *freq_table = NULL;
>> int i, max_opps, ret = 0;
>> unsigned long rate;
>> +#ifdef CONFIG_CPU_FREQ_BOOST_SW
>> + int j, len;
>> + u32 *boost_freqs = NULL;
>> +#endif
>>
>> rcu_read_lock();
>>
>> @@ -82,6 +87,45 @@ int dev_pm_opp_init_cpufreq_table(struct device *dev,
>>
>> *table = &freq_table[0];
>>
>> +#ifdef CONFIG_CPU_FREQ_BOOST_SW
>> + if (of_find_property(dev->of_node, "boost-frequencies", &len)) {
>
> Maybe:
> if(!of_find_property(...))
> goto out;
>
> To get rid of extra indentation levels below..
>
>> + struct cpufreq_frequency_table *ft;
>
> Declare at the top with boost_freqs, etc..
>
>> + if (len == 0 || (len & (sizeof(u32) - 1)) != 0) {
>
> s/len == 0/!len
>
> And use IS_ALIGNED() instead of the right hand side of ||
>
>> + dev_err(dev, "%s: invalid boost frequency\n", __func__);
>> + ret = -EINVAL;
>> + goto out;
>> + }
>> +
>> + boost_freqs = kzalloc(len, GFP_KERNEL);
>
> Can we do a devm_kzalloc instead? And why not kmalloc BTW ?
This is a temporary storage that is freed at the end of this function.
So devm_kzalloc is not used. Yes, kmalloc can be used.
>
>> + if (!boost_freqs) {
>> + dev_warn(dev, "%s: no memory for boost freq table\n",
>
> dev_err ?
>
>> + __func__);
>> + ret = -ENOMEM;
>> + goto out;
>> + }
>> + of_property_read_u32_array(dev->of_node, "boost-frequencies",
>> + boost_freqs, len / sizeof(u32));
>
>
> Create int count = len / sizeof(u32) instead.. You have used this
> multiple times.
>
>> + for (j = 0; j < len / sizeof(u32); j++) {
>> + ft = *table;
>> + for (i = 0; ft->frequency != CPUFREQ_TABLE_END; i++) {
>
> See if new macros can be used here instead. cpufreq_for_each_valid_entry().
>
>> + if (boost_freqs[j] == ft->frequency) {
>> + ft->flags |= CPUFREQ_BOOST_FREQ;
>> + break;
>> + }
>> + ft++;
>> + }
>> +
>> + if (ft->frequency == CPUFREQ_TABLE_END)
>> + pr_err("%s: invalid boost frequency %d\n",
>> + __func__, boost_freqs[j]);
>
> Maybe a pr_debug on the else part as well ? With boost freqs ..
>
>> + }
>> + }
>> +
>> + kfree(boost_freqs);
>> +#endif
>> +
>> out:
>> rcu_read_unlock();
>> if (ret)
>> --
>> 1.7.9.5
>>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
> the body of a message to majordomo at vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 12+ messages in thread
end of thread, other threads:[~2014-05-29 14:23 UTC | newest]
Thread overview: 12+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-05-23 13:37 [PATCH v4 0/2] cpufreq: opp: Add device tree based lookup of boost mode frequency Thomas Abraham
2014-05-23 13:37 ` Thomas Abraham
2014-05-23 13:37 ` [PATCH v4 1/2] cpufreq / OPP: Allow boost frequency to be looked up from device tree Thomas Abraham
2014-05-23 13:37 ` Thomas Abraham
2014-05-26 5:58 ` Viresh Kumar
2014-05-26 5:58 ` Viresh Kumar
2014-05-29 14:23 ` Thomas Abraham
2014-05-29 14:23 ` Thomas Abraham
2014-05-23 13:37 ` [PATCH v4 2/2] Documentation: devicetree: Add boost-frequency binding to list boost mode frequency Thomas Abraham
2014-05-23 13:37 ` Thomas Abraham
2014-05-26 6:09 ` Viresh Kumar
2014-05-26 6:09 ` Viresh Kumar
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.